mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Matthew Dobson <colpatch@us.ibm.com>
To: Pekka J Enberg <penberg@cs.Helsinki.FI>
Cc: kernel-janitors@lists.osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 8/8] Inline 3 functions
Date: Tue, 08 Nov 2005 11:08:30 -0800	[thread overview]
Message-ID: <4370F7AE.5090505@us.ibm.com> (raw)
In-Reply-To: <Pine.LNX.4.58.0511080937060.9530@sbz-30.cs.Helsinki.FI>

Pekka J Enberg wrote:
> On Mon, 7 Nov 2005, Matthew Dobson wrote:
> 
>>I found three functions in slab.c that have only 1 caller (kmem_getpages,
>>alloc_slabmgmt, and set_slab_attr), so let's inline them.
> 
> 
> Why? They aren't on the hot path and I don't see how this is an 
> improvement...
> 
> 			Pekka

Well, no, they aren't on the hot path.  I just figured since they are only
ever called from one other function, why not inline them?  If the sentiment
is that it's a BAD idea, I'll drop it.

-Matt

  parent reply	other threads:[~2005-11-08 19:08 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08  0:45 [PATCH 0/8] Cleanup slab.c Matthew Dobson
2005-11-08  0:48 ` [PATCH 1/8] Apply CodingStyle to mm/slab.c Matthew Dobson
2005-11-08  0:50 ` [PATCH 2/8] Use 'nid' in slab.c Matthew Dobson
2005-11-08  7:52   ` Pekka J Enberg
2005-11-08  0:52 ` [PATCH 3/8] Fix alloc_percpu()'s args Matthew Dobson
2005-11-08  0:53 ` [PATCH 4/8] Cleanup kmem_cache_create() Matthew Dobson
2005-11-08  2:14   ` Roland Dreier
2005-11-08  7:34     ` Pekka J Enberg
2005-11-08 18:49       ` Matthew Dobson
2005-11-08 18:52     ` Christoph Lameter
2005-11-08 19:04       ` Matthew Dobson
2005-11-08 19:09         ` Christoph Lameter
2005-11-08 19:21           ` Matthew Dobson
2005-11-08 19:59             ` Manfred Spraul
2005-11-08  7:51   ` Pekka J Enberg
2005-11-08 18:54     ` Matthew Dobson
2005-11-08 15:00   ` [KJ] " Matthew Wilcox
2005-11-08 15:11     ` Pekka J Enberg
2005-11-08 19:10       ` Matthew Dobson
2005-11-08  0:55 ` [PATCH 5/8] Cleanup cache_reap() Matthew Dobson
2005-11-08  0:57 ` [PATCH 6/8] Cleanup slabinfo_write() Matthew Dobson
2005-11-08 10:50   ` [KJ] " Alexey Dobriyan
2005-11-08 18:56     ` Christoph Lameter
2005-11-08 19:09       ` Matthew Dobson
2005-11-08  0:58 ` [PATCH 7/8] Cleanup set_slab_attr() Matthew Dobson
2005-11-08  1:00 ` [PATCH 8/8] Inline 3 functions Matthew Dobson
2005-11-08  7:39   ` Pekka J Enberg
2005-11-08 18:59     ` Christoph Lameter
2005-11-08 19:08     ` Matthew Dobson [this message]
2005-11-10 10:42       ` Adrian Bunk
2005-11-10 17:04         ` Matthew Dobson
2005-11-10 17:38           ` Adrian Bunk
2005-11-10 18:04             ` Oliver Neukum
2005-11-10 18:20               ` Adrian Bunk
2005-11-10 19:22                 ` Oliver Neukum
2005-11-10 20:43                   ` Adrian Bunk
2005-11-08  7:58 ` [PATCH 0/8] Cleanup slab.c Pekka J Enberg
2005-11-08 18:56   ` Matthew Dobson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4370F7AE.5090505@us.ibm.com \
    --to=colpatch@us.ibm.com \
    --cc=kernel-janitors@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=penberg@cs.Helsinki.FI \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome