From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB3AAC433EF for ; Thu, 14 Apr 2022 11:30:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234585AbiDNLdB (ORCPT ); Thu, 14 Apr 2022 07:33:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229854AbiDNLc4 (ORCPT ); Thu, 14 Apr 2022 07:32:56 -0400 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 766473B554; Thu, 14 Apr 2022 04:30:28 -0700 (PDT) X-UUID: 07e456226ac141088f6f5809255d7a44-20220414 X-UUID: 07e456226ac141088f6f5809255d7a44-20220414 Received: from mtkmbs10n2.mediatek.inc [(172.21.101.183)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1569299293; Thu, 14 Apr 2022 19:30:22 +0800 Received: from mtkexhb01.mediatek.inc (172.21.101.102) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.2.792.3; Thu, 14 Apr 2022 19:30:21 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkexhb01.mediatek.inc (172.21.101.102) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 14 Apr 2022 19:30:20 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 14 Apr 2022 19:30:20 +0800 Message-ID: <4374e31115bbcbd783003cd5c648163a1f4ff0d1.camel@mediatek.com> Subject: Re: [PATCH V2 11/15] cpufreq: mediatek: Update logic of voltage_tracking() From: Rex-BC Chen To: Kevin Hilman , , , , CC: , , , , , , , , , Date: Thu, 14 Apr 2022 19:30:20 +0800 In-Reply-To: <7hczhr5lm3.fsf@baylibre.com> References: <20220408045908.21671-1-rex-bc.chen@mediatek.com> <20220408045908.21671-12-rex-bc.chen@mediatek.com> <7hczhr5lm3.fsf@baylibre.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2022-04-08 at 14:08 -0700, Kevin Hilman wrote: > Rex-BC Chen writes: > > > From: Jia-Wei Chang > > > > - Remove VOLT_TOL because CCI may share the same sram and vproc > > regulators with CPU. Therefore, set the max voltage in > > regulator_set_voltage() to the proc{sram}_max_volt. > > This could you a bit more detailed explanation. Why does VOLT_TOL > get > in the way when regulators are shared between CPU & CCI? Hello Kevin, Here we use 'sram_min_volt' and 'sram_max_volt' to determine the voltage boundary of sram regulator. And use (sram_min_volt - min_volt_shift) and 'proc_max_volt' to determine the voltage boundary of vproc regulator. We use them as platform data to replace VOLT_TOL (voltage tolerance) when determing the voltage boundary and invoking regulator_set_voltage. I will add this to commit message in next version. > > > - Move comparison of new and old voltages to > > mtk_cpufreq_voltage_tracking(). > > Why? And how is this related to the above change? Seems to me that > it > belongs in a separate patch. > > Kevin I think there are some mistake for this. I will remove this commit message in next version. BRs, Rex