From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CEA0C41513 for ; Thu, 17 Aug 2023 05:33:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348094AbjHQFc2 (ORCPT ); Thu, 17 Aug 2023 01:32:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54172 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348049AbjHQFbz (ORCPT ); Thu, 17 Aug 2023 01:31:55 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A508F2D4F for ; Wed, 16 Aug 2023 22:31:53 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-9936b3d0286so1016071166b.0 for ; Wed, 16 Aug 2023 22:31:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1692250312; x=1692855112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sxtLgJIa1RLbTpPePXFhmwlCNeczWbrDyc8vA8a49A8=; b=Dwcb9tErmXCvVjYBoYcW3kHNCygFeA3lzAmCwd+kfkN+5pjVwMguvij4dluYqYB79X dH5yN+OosG5FF8OXqVyYc01ub1PSQyySQ/ufAp/3VwAb0yTkTX3sizw5t/6EJH0fd809 64AzcIZuAVTQmUpvlCpVmWpbaQHqARn1Oa3M4TidP/ycZ/s4jj8cyc1bMSzHYI6RGS2d qr9WZfCvjtsloy5r5s/IDAUwy5rshfJJYVsSPdCFBpbmUqnbh6wl1kfGyYLMixiALZsh FdbrOeJrcohdvwkrm8kiGARC3DvArBdnnxjfMgo0vyo0spm9t5CB3ynkiWT6Iok/Agbb m6rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692250312; x=1692855112; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=sxtLgJIa1RLbTpPePXFhmwlCNeczWbrDyc8vA8a49A8=; b=Bb9gGWKoETJnGaZ81a8qhwji0zJBgt014/oEzh4k8xnGEHq0VTb7PqGWTjoU/SFUZY m2HN0qDeec6fDBKSIio235lnYQdNEzeLZVKMkO5JInvIvAQHognJuIFZzG0Ig3gWf0x+ ozC7wSOiTStOIGF0v32+etY9fXcBLYPBp6j/keOHdtoSxmrCZidUcJk+FCHDG5fwX13D geRabDqJWEPp7eQ0rZACZjTcBeYJIRn65KEUUybHFdNeiP/G0FgE/wNW84i+WineilVd FRFewtmS3yp3KKizY45HEYyH/LAFyjg0TPKGFgFWgfp3I922gN5xFW9gEEKnActlbgFw 6HRQ== X-Gm-Message-State: AOJu0YwDM5rLENKjD03q2fVQkqdgPwWayjspn2orGF+nz+dz/ESOpGkE yKOXf0EUrdE/EeyveCH3YdqkwQ== X-Google-Smtp-Source: AGHT+IGd2XE7EL4DOlllWQeJM9YR/hImZD2DS4HJs5yBVB5vQwAT9kfmUKJR71ROmgg0YDXHetdscQ== X-Received: by 2002:a17:906:698a:b0:99c:444c:e4bb with SMTP id i10-20020a170906698a00b0099c444ce4bbmr2686161ejr.42.1692250312013; Wed, 16 Aug 2023 22:31:52 -0700 (PDT) Received: from [192.168.32.2] ([82.78.167.46]) by smtp.gmail.com with ESMTPSA id n13-20020a170906b30d00b0099b4d86fbccsm9697520ejz.141.2023.08.16.22.31.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Aug 2023 22:31:51 -0700 (PDT) Message-ID: <43796724-4926-c7e0-9532-92b863550780@tuxon.dev> Date: Thu, 17 Aug 2023 08:31:48 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH] ARM: dts: at91: sama5d29_curiosity: Add device tree for sama5d29_curiosity board To: Mihai.Sain@microchip.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, Nicolas.Ferre@microchip.com, Cristian.Birsan@microchip.com, alexandre.belloni@bootlin.com, andre.przywara@arm.com, Jerry.Ray@microchip.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Andrei.Simion@microchip.com, Varshini Rajendran References: <20230804101043.4063-1-mihai.sain@microchip.com> <127fc712-d924-f27f-5449-33385e89d6c3@tuxon.dev> <98d01db3-3eba-0731-0dd9-4310ed293bd6@tuxon.dev> Content-Language: en-US From: claudiu beznea In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/16/23 12:05, Mihai.Sain@microchip.com wrote: > Hi Claudiu, > > ---------------------- > > Hi, Mihai, > > On 8/10/23 09:47, Mihai.Sain@microchip.com wrote: >>> +&i2s0 { >>> + pinctrl-names = "default"; >>> + pinctrl-0 = <&pinctrl_i2s0_default>; >>> + status = "okay"; >> I see no sound bindings on DT. Is there any reason for having this here? >> # i2s0 bus is wired to RPi 40-pin connector. I want to have this node and its pinctrl here. >> # i2c1, flx4-spi, pwm0, uart1 are also wired to Rpi connector, and are defined here. >> # The same logic we apply also for mikroBUS sockets: i2c, pwm, spi and uart nodes are defined here. >> > > Can you use it (either with user space tools or other kernel consumers) w/o additional device tree bindings? > # Yes. We have added in dt-overlay the codec which uses the i2s0 and i2c1 nodes and pinctrls. overlay means additional DT bindings to me. So, I suggest to move the i2s node there, too. It is the same approach that you've taken for ethernet node.