From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A7A7C04A68 for ; Thu, 28 Jul 2022 12:04:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237365AbiG1MEW (ORCPT ); Thu, 28 Jul 2022 08:04:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237827AbiG1MEM (ORCPT ); Thu, 28 Jul 2022 08:04:12 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FC7569F38; Thu, 28 Jul 2022 05:04:07 -0700 (PDT) Received: from [192.168.1.111] (91-158-154-79.elisa-laajakaista.fi [91.158.154.79]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 888D156D; Thu, 28 Jul 2022 14:04:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1659009845; bh=W8KWOIaou5r+VZS1JZiD6LrDaQ9bIBoLAeqLxYhMnDc=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=G5npxURHTqXY8u1iyD1KqtbRO7P8zd7pxttdTNeOyMazaL+pLXYliOwBq/7GlTupo o9w6kt8yw/PscOKGZA4d3GRK+ivp2OoCJA8I6iK2io3VqOGZIIlC3iHQNBXCgqZOcN sxXkHxHRU3sEk5AIPxrUwEzdT3lVvNV2F4fu94C8= Message-ID: <4382b760-418f-4033-97f2-47e082a30232@ideasonboard.com> Date: Thu, 28 Jul 2022 15:04:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v3 2/2] drm/tidss: Add support for AM625 DSS Content-Language: en-US To: Aradhya Bhatia , Jyri Sarha , Rob Herring , David Airlie , Daniel Vetter , Krzysztof Kozlowski Cc: Nishanth Menon , Vignesh Raghavendra , Rahul T R , Devarsh Thakkar , DRI Development List , Devicetree List , Linux Kernel List References: <20220627151200.4693-1-a-bhatia1@ti.com> <20220627151200.4693-3-a-bhatia1@ti.com> From: Tomi Valkeinen In-Reply-To: <20220627151200.4693-3-a-bhatia1@ti.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 27/06/2022 18:12, Aradhya Bhatia wrote: > Add support for the DSS IP on TI's new AM625 SoC in the tidss driver. > > Signed-off-by: Aradhya Bhatia > Reviewed-by: Rahul T R > --- > drivers/gpu/drm/tidss/tidss_dispc.c | 56 ++++++++++++++++++++++++++++- > drivers/gpu/drm/tidss/tidss_dispc.h | 2 ++ > drivers/gpu/drm/tidss/tidss_drv.c | 1 + > 3 files changed, 58 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tidss/tidss_dispc.c b/drivers/gpu/drm/tidss/tidss_dispc.c > index dae47853b728..f084f0688a54 100644 > --- a/drivers/gpu/drm/tidss/tidss_dispc.c > +++ b/drivers/gpu/drm/tidss/tidss_dispc.c > @@ -272,6 +272,55 @@ const struct dispc_features dispc_j721e_feats = { > .vid_order = { 1, 3, 0, 2 }, > }; > > +const struct dispc_features dispc_am625_feats = { > + .max_pclk_khz = { > + [DISPC_VP_DPI] = 165000, > + [DISPC_VP_OLDI] = 165000, > + }, > + > + .scaling = { > + .in_width_max_5tap_rgb = 1280, > + .in_width_max_3tap_rgb = 2560, > + .in_width_max_5tap_yuv = 2560, > + .in_width_max_3tap_yuv = 4096, > + .upscale_limit = 16, > + .downscale_limit_5tap = 4, > + .downscale_limit_3tap = 2, > + /* > + * The max supported pixel inc value is 255. The value > + * of pixel inc is calculated like this: 1+(xinc-1)*bpp. > + * The maximum bpp of all formats supported by the HW > + * is 8. So the maximum supported xinc value is 32, > + * because 1+(32-1)*8 < 255 < 1+(33-1)*4. > + */ > + .xinc_max = 32, > + }, > + > + .subrev = DISPC_AM625, > + > + .common = "common", > + .common_regs = tidss_am65x_common_regs, > + > + .num_vps = 2, > + .vp_name = { "vp1", "vp2" }, > + .ovr_name = { "ovr1", "ovr2" }, > + .vpclk_name = { "vp1", "vp2" }, > + .vp_bus_type = { DISPC_VP_OLDI, DISPC_VP_DPI }, This looks correct, but with the two OLDI TXes, I think there will be some interesting issues. The tidss_kms.c associates a DSS VP and a DT port, but that's no longer true if you add the ports for both OLDI TXes, as they both use the same VP. I think fixing that won't affect this patch, though, and merging this patch will, afaik, enable similar DSS functionality as we have for AM65x. So, I think these two patches could be merged, or we could wait a bit until the OLDI situation becomes more clear. Up to you. In any case, for both patches: Reviewed-by: Tomi Valkeinen Tomi