From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55628C433EF for ; Tue, 15 Feb 2022 01:40:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233072AbiBOBky (ORCPT ); Mon, 14 Feb 2022 20:40:54 -0500 Received: from mxb-00190b01.gslb.pphosted.com ([23.128.96.19]:54532 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233069AbiBOBkx (ORCPT ); Mon, 14 Feb 2022 20:40:53 -0500 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 15FEA1405CB for ; Mon, 14 Feb 2022 17:40:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644889244; x=1676425244; h=message-id:date:mime-version:cc:subject:to:references: from:in-reply-to:content-transfer-encoding; bh=KYWNub4KIGvtKYUBq0gCFrcp5xgJGm+OQNdJMARo9G8=; b=XSvi/c4fFlhBzrrBBDvS8nfT4Tz2HMh6A8cxJAYh2W862nqvV9XJQXA2 zeh5OCRzgxZrFTBI3pmiSqlFxtU+NJ4cE1mvG9OlR69quvTu1P7es+4KU 2OjJkP/BGesxVuI6hySpfbt64VtsrnGCfyAzMfltF9fNFto4ZCccz5XIE BsEsdcQ2S1L+G8L8+mQYYLRBFYPHjakRkaeDzrWWrfKFtbh6vvsPFInjz TFiB3Jexu4EGv+7WGKxGqQKPhQT5xJqFsX9Cfc+KEaBBtaw6pRaSwLufr nKCa13DUepnvUhPqF/3cPIdkcGyfabPz6eL9oU+5USDto80vEwFZBGNOd Q==; X-IronPort-AV: E=McAfee;i="6200,9189,10258"; a="274799501" X-IronPort-AV: E=Sophos;i="5.88,369,1635231600"; d="scan'208";a="274799501" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 17:40:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,369,1635231600"; d="scan'208";a="680788159" Received: from allen-box.sh.intel.com (HELO [10.239.159.118]) ([10.239.159.118]) by fmsmga001.fm.intel.com with ESMTP; 14 Feb 2022 17:40:39 -0800 Message-ID: <43855d9f-f60a-0bb0-088d-cf0b12defb79@linux.intel.com> Date: Tue, 15 Feb 2022 09:39:21 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Cc: baolu.lu@linux.intel.com, Joerg Roedel , Christoph Hellwig , Ben Skeggs , Kevin Tian , Ashok Raj , Will Deacon , Robin Murphy , Alex Williamson , Eric Auger , Liu Yi L , Jacob jun Pan , David Airlie , Daniel Vetter , Thierry Reding , Jonathan Hunter , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 09/10] iommu: Use dev_iommu_ops() helper Content-Language: en-US To: Jason Gunthorpe References: <20220214015538.2828933-1-baolu.lu@linux.intel.com> <20220214015538.2828933-10-baolu.lu@linux.intel.com> <20220214132608.GA4160@nvidia.com> From: Lu Baolu In-Reply-To: <20220214132608.GA4160@nvidia.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2/14/22 9:26 PM, Jason Gunthorpe wrote: > On Mon, Feb 14, 2022 at 09:55:37AM +0800, Lu Baolu wrote: >> This converts all the feasible instances of dev->bus->iommu_ops to >> dev_iommu_ops() in order to make the operation of obtaining iommu_ops >> from a device consistent. The dev_iommu_ops() warns on NULL ops, so >> we don't need to keep the confusing ops check. >> >> Suggested-by: Robin Murphy >> Signed-off-by: Lu Baolu >> --- >> drivers/iommu/iommu.c | 30 ++++++++++++++---------------- >> 1 file changed, 14 insertions(+), 16 deletions(-) > I thought you were going to squish this into the prior patch? I will merge this two patches in the next version. I made them separated in this series just for ease of review. Best regards, baolu