From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 997D4C00140 for ; Tue, 2 Aug 2022 17:32:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230498AbiHBRca (ORCPT ); Tue, 2 Aug 2022 13:32:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229461AbiHBRc0 (ORCPT ); Tue, 2 Aug 2022 13:32:26 -0400 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BC7613D46; Tue, 2 Aug 2022 10:32:25 -0700 (PDT) Received: by mail-pj1-f50.google.com with SMTP id f11-20020a17090a4a8b00b001f2f7e32d03so1998446pjh.0; Tue, 02 Aug 2022 10:32:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=hQdFNNSZIS0UXH5mX4zMb5LlYpQDpBhKMVn8uxRhbMo=; b=6kjGl/TBSODgQj+Rd64zpVtC2CCXPfHM2Hy82MbnIcjjzUQL7Zh+xb9jdVJdP8QEnx p7fVqG+BIqKLGPSAb7LS+kq6phlAWOqf5JYfn85bz/5Ybx85QeTjoJGbpvbBmJGQK9S1 nueE/NQjfLZmi7ecbV2MzjoD+9ymvkqYOl+MTMlIsHtZNOT4R4dwP/bGfZJ/oAsnAa2D ocqPr5NCFYxBhB4jzFoB4E6kMmAXW9WE0PqHd8l25V4zgxpxekMZJJc3dJWb/n3KG5hP ogh9HXfq+E1bvUK5t0q8SxZpOD1CrC/xxrVwJ58lA/W1UBCZC1IzxBgHVn4/863d6Tey j/MQ== X-Gm-Message-State: ACgBeo1ThqwifQj0o0ene+kz/eYnBbf3FDIagNZyowYcWyHPpk0jxQAW L4ZJLCz7xiD1VesrJeds4Cw= X-Google-Smtp-Source: AA6agR6cj4zMaUIGkgIgEbmD7+/rnsnZp6/rUNcmSKtSZG4r5I2Vtli545RhBV3QP349G6CDTl6bVg== X-Received: by 2002:a17:90b:4f8d:b0:1f5:835:1b19 with SMTP id qe13-20020a17090b4f8d00b001f508351b19mr538171pjb.63.1659461544415; Tue, 02 Aug 2022 10:32:24 -0700 (PDT) Received: from ?IPV6:2620:15c:211:201:5297:9162:3271:e5df? ([2620:15c:211:201:5297:9162:3271:e5df]) by smtp.gmail.com with ESMTPSA id j11-20020a170902da8b00b0016bfafffa0esm12099648plx.227.2022.08.02.10.32.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 Aug 2022 10:32:23 -0700 (PDT) Message-ID: <438a9c4c-e601-ec22-0d05-5cec697d06a1@acm.org> Date: Tue, 2 Aug 2022 10:32:20 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH v5] ufs: core: print UFSHCD capabilities in controller's sysfs node Content-Language: en-US To: Daniil Lunev Cc: Adrian Hunter , Greg Kroah-Hartman , Alim Akhtar , Avri Altman , Bean Huo , "James E.J. Bottomley" , Keoseong Park , "Martin K. Petersen" , Mauro Carvalho Chehab , Sohaib Mohamed , linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org References: <20220802103643.v5.1.Ibf9efc9be50783eeee55befa2270b7d38552354c@changeid> From: Bart Van Assche In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/1/22 21:12, Daniil Lunev wrote: >> Calling this the effective capabilities of the controller-device pair >> sounds good to me. But please do not refer to hba->caps. I'd like to >> rework hba->caps such that it only includes controller capabilities and >> no information related to the WriteBooster. Additionally, several UFS >> device capabilities that may be exported in the future are not >> represented in hba->caps. > > So can you clarify where specifically do you want me to mention that? > Should I name the directory "effective_capabilities" or the commit > message? I'm fine with the name "capabilities" since "effective_capabilities" is a bit long. How about adding the above explanation in the source code close to the definition of the capabilities group since it is more likely that it will be noticed there by software developers compared to Documentation/ABI/? Thanks, Bart.