From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754041AbdBGMBa (ORCPT ); Tue, 7 Feb 2017 07:01:30 -0500 Received: from thoth.sbs.de ([192.35.17.2]:53743 "EHLO thoth.sbs.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753284AbdBGMB3 (ORCPT ); Tue, 7 Feb 2017 07:01:29 -0500 Subject: Re: [PATCH] serial: 8250_pci: Fix EXAR feature control register constants To: Andy Shevchenko , Sudip Mukherjee References: <59a3d502-970c-3844-d602-12f889928dd7@siemens.com> Cc: Greg Kroah-Hartman , Linux Kernel Mailing List From: Jan Kiszka Message-ID: <438e72ec-59e8-5fce-129d-8a8f381f1c5e@siemens.com> Date: Tue, 7 Feb 2017 13:01:21 +0100 User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017-02-07 12:55, Andy Shevchenko wrote: > +Cc Sudip > > On Fri, Feb 3, 2017 at 3:22 PM, Jan Kiszka wrote: >> According to the XR17V352 manual, bit 4 is IrDA control and bit 5 for >> 485. Fortunately, no driver used them so far. >> >> Signed-off-by: Jan Kiszka >> --- >> include/uapi/linux/serial_reg.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/uapi/linux/serial_reg.h b/include/uapi/linux/serial_reg.h >> index b4c0484..b1f60cb 100644 >> --- a/include/uapi/linux/serial_reg.h >> +++ b/include/uapi/linux/serial_reg.h >> @@ -366,8 +366,8 @@ >> #define UART_EXAR_DVID 0x8d /* Device identification */ >> >> #define UART_EXAR_FCTR 0x08 /* Feature Control Register */ >> -#define UART_FCTR_EXAR_IRDA 0x08 /* IrDa data encode select */ >> -#define UART_FCTR_EXAR_485 0x10 /* Auto 485 half duplex dir ctl */ >> +#define UART_FCTR_EXAR_IRDA 0x10 /* IrDa data encode select */ >> +#define UART_FCTR_EXAR_485 0x20 /* Auto 485 half duplex dir ctl */ >> #define UART_FCTR_EXAR_TRGA 0x00 /* FIFO trigger table A */ >> #define UART_FCTR_EXAR_TRGB 0x60 /* FIFO trigger table B */ >> #define UART_FCTR_EXAR_TRGC 0x80 /* FIFO trigger table C */ > > > BTW, I recalled that Greg preferred to remove these regs from uapi. Once I'm done with moving the fastcom exar code over to 8250_exar.c (currently compiling...), I'll also write a patch to move these defines in the same file. Jan -- Siemens AG, Corporate Technology, CT RDA ITP SES-DE Corporate Competence Center Embedded Linux