From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754158AbbLJXHY (ORCPT ); Thu, 10 Dec 2015 18:07:24 -0500 Received: from mail-lf0-f49.google.com ([209.85.215.49]:34508 "EHLO mail-lf0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754024AbbLJXHT (ORCPT ); Thu, 10 Dec 2015 18:07:19 -0500 From: Sergei Shtylyov To: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, myungjoo.ham@samsung.com, cw00.choi@samsung.com, devicetree@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH] extcon-usb-gpio: add enable pin support Date: Fri, 11 Dec 2015 02:07:05 +0300 Message-ID: <4393960.B6dD3UkQy3@wasted.cogentembedded.com> Organization: Cogent Embedded Inc. User-Agent: KMail/4.14.10 (Linux/4.2.6-201.fc22.x86_64; KDE/4.14.14; x86_64; ; ) MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sometimes there's a real OTG chip behind the USB ID signal mapped to a GPIO pin: in my case it's Maxim Integrated MAX3355E which integrates Vbus charge pump and comparators and passes thru the ID signal from an OTG connector. This chip also has the SHDN# pin which should be driven high for the normal operation and low to save power; it is connected to a GPIO pin as well on, hence we'll have to teach the driver to parse the new optional device tree property, "enable-gpio"... Signed-off-by: Sergei Shtylyov --- The patch is against the 'extcon-next' branch of the 'extcon.git' repo. Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt | 3 +++ drivers/extcon/extcon-usb-gpio.c | 5 +++++ 2 files changed, 8 insertions(+) Index: extcon/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt =================================================================== --- extcon.orig/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt +++ extcon/Documentation/devicetree/bindings/extcon/extcon-usb-gpio.txt @@ -7,6 +7,9 @@ Required properties: - compatible: Should be "linux,extcon-usb-gpio" - id-gpio: gpio for USB ID pin. See gpio binding. +Optional properties: +- enable-gpio: gpio for the enable pin. See gpio binding. + Example: Examples of extcon-usb-gpio node in dra7-evm.dts as listed below: extcon_usb1 { compatible = "linux,extcon-usb-gpio"; Index: extcon/drivers/extcon/extcon-usb-gpio.c =================================================================== --- extcon.orig/drivers/extcon/extcon-usb-gpio.c +++ extcon/drivers/extcon/extcon-usb-gpio.c @@ -33,6 +33,7 @@ struct usb_extcon_info { struct device *dev; struct extcon_dev *edev; + struct gpio_desc *enable_gpiod; struct gpio_desc *id_gpiod; int id_irq; @@ -99,6 +100,8 @@ static int usb_extcon_probe(struct platf return -ENOMEM; info->dev = dev; + info->enable_gpiod = devm_gpiod_get_optional(&pdev->dev, "enable", + GPIOD_OUT_HIGH); info->id_gpiod = devm_gpiod_get(&pdev->dev, "id", GPIOD_IN); if (IS_ERR(info->id_gpiod)) { dev_err(dev, "failed to get ID GPIO\n"); @@ -155,6 +158,8 @@ static int usb_extcon_remove(struct plat cancel_delayed_work_sync(&info->wq_detcable); + gpiod_set_value_cansleep(info->enable_gpiod, 0); + return 0; }