From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 906C478F4E for ; Mon, 30 Jun 2025 18:31:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751308283; cv=none; b=ImQ32Y+BeE8boGB5dsvcRQ/j2XwdTa5q3T5SQAQGoaSlZoydUB6q4GtIj0l3+ea6aaTkRgLxNBDiWmKGve2W7JESe4PNlCcymv3W+sg6Q0xWzp/RAwXe/RzmZkpG4JYuS5sYnZKvs1gLJbICXTDx7z9j88jFPbqhUOxFOgkKdwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751308283; c=relaxed/simple; bh=FLtyhUbuA2aQOuNKgKE+ET2SDkrsNcWeb+kVrzNOdsE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=RMvFpH2uklXLNjNm7DIjZ7pVRLctJ3boYXHdvbGk87GUoq8iVB4r+1bKMDlpx05w5xFzK4RddTS0BFkg9LDb1kmxo4f1iFyoMOSG5auslPq9JouJ8dkoOIAB9Tx9bRR8yU1TUmP40NekMzCk9hDMPZTadnqkhZTn6JdJbb/qiC4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=o2x6xhRI; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="o2x6xhRI" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55UG32Y0028446 for ; Mon, 30 Jun 2025 18:31:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= gzGsMAPEQiSZ6GBpzbnmC6RxIkkEvbmXR+O46b196/I=; b=o2x6xhRIr9wXcPLq qOEp9gzGF1n0nfI0DpQB0m1wx1HRns6vbL1qQ9Giq45ujOZ3SOuJERKB+32CryCI oRP5FTEGtsqGIpT/qeiXoV1XQl0CNRFWf36h2TpwG2IaSmVB9CWr7+s/YDpPSAq6 uR29rfcpJXiXbEqpVYrFhO6vAaQjF3SJ/GD/Uw3a1F7bZiw10eqdC84AAFv6MHst b7hMpjHBb51/RfEsn4MDsrRM7L4o60c4QzT0SBHegYD8llp8yG/PNcbsIJ8lQYD4 2tvZpZxiXm6NMIIB3yNXO4We6EMP7qZaTDDy3NZHqcPqhZQ/3qSBSg9bL7pRzJRE 9JfNlQ== Received: from mail-pf1-f200.google.com (mail-pf1-f200.google.com [209.85.210.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 47j7bvnueu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 30 Jun 2025 18:31:20 +0000 (GMT) Received: by mail-pf1-f200.google.com with SMTP id d2e1a72fcca58-748b4d5c045so2136717b3a.1 for ; Mon, 30 Jun 2025 11:31:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751308280; x=1751913080; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gzGsMAPEQiSZ6GBpzbnmC6RxIkkEvbmXR+O46b196/I=; b=P7oC+ggnxbYZBXHF9J8dm4CWT/8LQXqpOlzPEv1dbO+niSmX4Z+S3c5j9AdJNzikyN IrIha8Fy4JF1Fd9DwfhUP+McxWlAYZZz/t/02MfMqIql7YGR2srPUfPt1VsHA1ocbaq2 8a/guWeo+/9BnaPj9sx/nyTNHukQxxO5ee/EopLKCkbRluU+Lh4BNAg5K0VnLbMa5HQL hGOBJKosts53+gEp6cdwhzeQk4mzqIlvuIP4kSC49CWZwdA8hRUbj0xH5yTGOQFwSpv3 aUskjLknVGWMWCKgrgI/bbnwRGtGtd6Cjb6xyemMy24e8TavKX3F44zxlOJ8dRxMRRCz omdw== X-Forwarded-Encrypted: i=1; AJvYcCXy6hI6Efvvx9EFMFb0JXrDK1pn75vWljORlEHF5PyRHi2Jx2nIWhJii1mzdq26W+xfXgxV3JywM5vZJe4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz7+9Iz+5xecG9jTIXyiHdcSez9JwthjpEZ9l9daCEY4ycrnr+b sHtPviyIeJoQV5DaXFFWmfQKQSGgqEMQFDFS971lrwakeMQwy9xuMMOcAETWZJy2mRDRO0iFNX9 gvKw9K3Vdq6VSfEnqjHq3gB7M64RNOAKzN/FX2gIrda9J/7Wp9CTFIE9wDFwDGVT9580= X-Gm-Gg: ASbGncuHiKqxakGLy1wGeOeuhsDxz5pkndy+sb2Ld3VbuHp9CSONkX5/f5GexOkq2rS uQI4nej4VC7asIm5ayDEetjFT138YpdA6jJeBZ8WZNiuST99ZwSXz8Uw3R1ObsCwOCM2BWQFfF6 9i1fAuo5VZtFa1gUSgLhHeC2WGbHvRH+H3sa6zwp7q1Inhq3dyPinrPIj/7ljCwJOedUDg825Uv gCnrsxNIn/eE0VD/fYaeRyJ8kQ3Xbo1LrxDGdTI+wULroPe1u7sc0weX+RAN5b/Z2IMXdxFrxvo sC9Cc+KReo1HmOzJ7piHpqupP3OfxOINNlOg7wVV5WLfb7/x3RfXr6KEUgS0bQdKJurBwwdj X-Received: by 2002:a05:6a00:b4b:b0:73d:fa54:afb9 with SMTP id d2e1a72fcca58-74af6eab8cbmr20654057b3a.7.1751308279644; Mon, 30 Jun 2025 11:31:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGxSWLjq9AlGyMrnNBvFpeMkF/I30ekWwyE03Ri1IMvjryC0GFnAJl7hAfryAjdbrXswhyw2A== X-Received: by 2002:a05:6a00:b4b:b0:73d:fa54:afb9 with SMTP id d2e1a72fcca58-74af6eab8cbmr20654021b3a.7.1751308279188; Mon, 30 Jun 2025 11:31:19 -0700 (PDT) Received: from [10.226.59.182] (i-global254.qualcomm.com. [199.106.103.254]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74af56e8789sm9539234b3a.144.2025.06.30.11.31.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jun 2025 11:31:18 -0700 (PDT) Message-ID: <4396deb6-049a-4649-afbc-fd20986b118a@oss.qualcomm.com> Date: Mon, 30 Jun 2025 12:31:16 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] irqchip/qcom-irq-combiner: Rename driver struct to end in _driver To: Konrad Dybcio , =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= , Agustin Vega-Frias , Marc Zyngier , Thomas Gleixner Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, Markus Schneider-Pargmann References: <20250630172333.73614-2-u.kleine-koenig@baylibre.com> <563db91f-3080-4a45-ba0d-04f415ed90d9@oss.qualcomm.com> Content-Language: en-US From: Jeff Hugo In-Reply-To: <563db91f-3080-4a45-ba0d-04f415ed90d9@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: rULelIsvgZOO1w0V8YxHIZRqD4NEYYGy X-Authority-Analysis: v=2.4 cv=RJCzH5i+ c=1 sm=1 tr=0 ts=6862d7f8 cx=c_pps a=mDZGXZTwRPZaeRUbqKGCBw==:117 a=JYp8KDb2vCoCEuGobkYCKw==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=IpJZQVW2AAAA:8 a=p1q8K86rv7LwV1BeAAYA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=zc0IvFSfCIW2DFIPzwfm:22 a=IawgGOuG5U0WyFbmm1f5:22 X-Proofpoint-ORIG-GUID: rULelIsvgZOO1w0V8YxHIZRqD4NEYYGy X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjMwMDE1MSBTYWx0ZWRfXzubsdKYjv8+W ypp9YnfO6US71SnPAamaNLAX3/sUCDG7Z97553YgSIyTUdm71NmnQ99JKWQp5Y5JNHtoe+iyiXP w5xpJ0RH3a43FVCdlezjTGwCn28u4rL8NTAwGhEEuYXkFUk/6na23sjhK9F6a03cHfa0pdHdTcZ rSdyawqA0zZ/+6MZn2KZYgZf1qelTVGof7z3T/DdDHJecmeX6BNTgrK2Enb9flrwlvU1xicvi2R OhG82KTrl9+BbuQvFCc8BHYR8MtxI9t0WD5A3QRFaN+lrliMJWO//036EpOulHJGhjduxd6LNOZ mQjaRA3ALSJAiDhoYNMpPRQvA9gSKGpDqKfF6kAg1PbCv2lECI2sWmj24df6ephznX8Ynk0QrsF vByhImdpsFy+innSzMTcIGZY406QjKHgoqbbT0CARZLvS6z3glxLi1A/OFaH77QJDvcY9Cfo X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.1.7,FMLib:17.12.80.40 definitions=2025-06-30_04,2025-06-27_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 priorityscore=1501 mlxlogscore=999 adultscore=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506300151 On 6/30/2025 11:25 AM, Konrad Dybcio wrote: > > > On 30-Jun-25 19:23, Uwe Kleine-König wrote: >> The modpost section mismatch checks are more lax for objects that have a >> name that ends in "_probe". This is not justified here though, so rename >> the driver struct according to the usual naming choice. >> >> Note that this change indeed results in modpost identifying a section >> mismatch in this driver. This is not a false positive and should be >> fixed by either converting the driver to use platform_driver_probe() or >> by dropping __init from the .probe() callback. This problem was >> introduced in commit f20cc9b00c7b ("irqchip/qcom: Add IRQ combiner >> driver"). >> >> Signed-off-by: Uwe Kleine-König >> --- >> Hello, >> >> I don't know if platform_driver_probe() works here, it might happen that >> the driver is probed before the matching device appears. As I don't have >> a machine with such a device I won't create a patch fixing the issue, >> but if you have questions don't hesitate to ask. >> >> Please consider this patch as a bug report and better only apply it when >> the issue is addressed to not result in build regressions. > > +Jeff is probably the last person on Earth that officially has one We are talking about QDF2400 here? -Jeff