mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Oleg Nesterov <oleg@tv-sign.ru>
To: Oren Laadan <orenl@cs.columbia.edu>
Cc: akpm@osdl.org, roland@redhat.com, Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH ? 2/2] setpgid: should work for sub-threads
Date: Mon, 12 Dec 2005 16:18:54 +0300	[thread overview]
Message-ID: <439D78BE.5A06EAE3@tv-sign.ru> (raw)
In-Reply-To: <Pine.LNX.4.63.0512111605430.31447@takamine.ncl.cs.columbia.edu>

Oren Laadan wrote:
> 
> -void __set_special_pids(pid_t session, pid_t pgrp)
> +void __set_special_pids(struct task_struct *tsk, pid_t session, pid_t pgrp)
>   {
> -       struct task_struct *curr = current;

Do we need to add the new paramater? I think we can just do:

-       struct task_struct *curr = current;
+       struct task_struct *curr = current->group_leader;

and that's all. This function is called from daemonize() also,
but the kernel thread is a thread group leader always.

Oleg.

      reply	other threads:[~2005-12-12 12:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200512110523.jBB5NVEr002551@shell0.pdx.osdl.net>
2005-12-11 17:22 ` [PATCH ? 1/2] setpgid: should not accept ptraced childs Oleg Nesterov
2005-12-11 17:22 ` [PATCH ? 2/2] setpgid: should work for sub-threads Oleg Nesterov
2005-12-11 21:14   ` Oren Laadan
2005-12-12 13:18     ` Oleg Nesterov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=439D78BE.5A06EAE3@tv-sign.ru \
    --to=oleg@tv-sign.ru \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=orenl@cs.columbia.edu \
    --cc=roland@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®