mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yihang Li <liyihang9@huawei.com>
To: Bart Van Assche <bvanassche@acm.org>,
	<James.Bottomley@HansenPartnership.com>,
	<martin.petersen@oracle.com>
Cc: <linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linuxarm@huawei.com>, <prime.zeng@huawei.com>,
	<liyihang9@huawei.com>
Subject: Re: [PATCH v2] scsi: sd: retry command SYNC CACHE if format in progress
Date: Tue, 13 Aug 2024 09:14:08 +0800	[thread overview]
Message-ID: <439a83c1-4a61-0ef3-b77e-917c6ae2d653@huawei.com> (raw)
In-Reply-To: <be2a8462-38fb-4e74-905d-12bc9f678082@acm.org>



On 2024/8/13 5:24, Bart Van Assche wrote:
> On 8/9/24 6:59 PM, Yihang Li wrote:
>> If formatting a suspended disk (such as formatting with different DIF
>> type), the disk will be resuming first, and then the format command will
>> submit to the disk through SG_IO ioctl.
>>
>> When the disk is processing the format command, the system does not submit
>> other commands to the disk. Therefore, the system attempts to suspend the
>> disk again and sends the SYNC CACHE command. However, the SYNC CACHE
>> command will fail because the disk is in the formatting process, which
>> will cause the runtime_status of the disk to error and it is difficult
>> for user to recover it. Error info like:
>>
>> [  669.925325] sd 6:0:6:0: [sdg] Synchronizing SCSI cache
>> [  670.202371] sd 6:0:6:0: [sdg] Synchronize Cache(10) failed: Result: hostbyte=0x00 driverbyte=DRIVER_OK
>> [  670.216300] sd 6:0:6:0: [sdg] Sense Key : 0x2 [current]
>> [  670.221860] sd 6:0:6:0: [sdg] ASC=0x4 ASCQ=0x4
>>
>> To solve the issue, retry the command until format command is finished.
>>
>> Signed-off-by: Yihang Li <liyihang9@huawei.com>
> 
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> 
> If you want this patch to land in older kernels a "Cc: stable" tag will
> have to be added.
> 
ok, I will add this tag in patch v3.

Thanks,

Yihang.

      reply	other threads:[~2024-08-13  1:14 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-10  1:59 Yihang Li
2024-08-12 21:24 ` Bart Van Assche
2024-08-13  1:14   ` Yihang Li [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=439a83c1-4a61-0ef3-b77e-917c6ae2d653@huawei.com \
    --to=liyihang9@huawei.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=bvanassche@acm.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=martin.petersen@oracle.com \
    --cc=prime.zeng@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®