mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Mika Penttilä" <mika.penttila@kolumbus.fi>
To: vgoyal@in.ibm.com
Cc: linux kernel mailing list <linux-kernel@vger.kernel.org>,
	Fastboot mailing list <fastboot@lists.osdl.org>,
	Andi Kleen <ak@muc.de>, Morton Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] x86_64 write apic id fix
Date: Thu, 29 Dec 2005 17:57:11 +0200	[thread overview]
Message-ID: <43B40757.7040706@kolumbus.fi> (raw)
In-Reply-To: <20051229082709.GB1626@in.ibm.com>

Vivek Goyal wrote:

>o Apic id is in most significant 8 bits of APIC_ID register. Current code
>  is trying to write apic id to least significant 8 bits. This patch fixes
>  it.
>
>o This fix enables booting uni kdump capture kernel on a cpu with non-zero
>  apic id.
>
>Signed-off-by: Vivek Goyal <vgoyal@in.ibm.com>
>---
>
>  
>
What difference does it make in the first place? In 
APIC_init_uniprocessor() you write back the apic id read before from 
processor, not from mp table (because you wouldn't be in 
APIC_init_uniprocessor() otherwise).

--Mika


  parent reply	other threads:[~2005-12-29 15:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-12-29  8:27 Vivek Goyal
2005-12-29 12:16 ` Andi Kleen
2005-12-29 15:57 ` Mika Penttilä [this message]
2005-12-30 11:44   ` Vivek Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43B40757.7040706@kolumbus.fi \
    --to=mika.penttila@kolumbus.fi \
    --cc=ak@muc.de \
    --cc=akpm@osdl.org \
    --cc=fastboot@lists.osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome