From: Chuck Lever <chuck.lever@oracle.com>
To: Bruce Fields <bfields@fieldses.org>
Cc: Alex Dewar <alex.dewar90@gmail.com>,
Frank van der Linden <fllinden@amazon.com>,
Linux NFS Mailing List <linux-nfs@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c
Date: Thu, 13 Aug 2020 15:01:34 -0400 [thread overview]
Message-ID: <43C14B32-77C7-44E2-9051-0E80AF606CE0@oracle.com> (raw)
In-Reply-To: <20200812203631.GA13358@dev-dsk-fllinden-2c-c1893d73.us-west-2.amazon.com>
> On Aug 12, 2020, at 4:36 PM, Frank van der Linden <fllinden@amazon.com> wrote:
>
> On Wed, Aug 12, 2020 at 03:12:51PM +0100, Alex Dewar wrote:
>>
>> In nfsd4_encode_listxattrs(), the variable p is assigned to at one point
>> but this value is never used before p is reassigned. Fix this.
>>
>> Addresses-Coverity: ("Unused value")
>> Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
>> ---
>> fs/nfsd/nfs4xdr.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c
>> index 259d5ad0e3f47..1a0341fd80f9a 100644
>> --- a/fs/nfsd/nfs4xdr.c
>> +++ b/fs/nfsd/nfs4xdr.c
>> @@ -4859,7 +4859,7 @@ nfsd4_encode_listxattrs(struct nfsd4_compoundres *resp, __be32 nfserr,
>> goto out;
>> }
>>
>> - p = xdr_encode_opaque(p, sp, slen);
>> + xdr_encode_opaque(p, sp, slen);
>>
>> xdrleft -= xdrlen;
>> count++;
>> --
>> 2.28.0
>>
>
> Yep, I guess my linting missed that, thanks for the fix.
Bruce, these two don't appear to be urgent, so I'm deferring them
to you for v5.10.
--
Chuck Lever
next prev parent reply other threads:[~2020-08-13 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-12 14:12 Alex Dewar
2020-08-12 14:12 ` [PATCH 2/2] nfsd: Fix typo in comment Alex Dewar
2020-08-12 20:37 ` Frank van der Linden
2020-08-12 20:36 ` [PATCH 1/2] nfsd: Remove unnecessary assignment in nfs4xdr.c Frank van der Linden
2020-08-13 19:01 ` Chuck Lever [this message]
2020-08-20 23:37 ` Alex Dewar
2020-08-26 20:09 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43C14B32-77C7-44E2-9051-0E80AF606CE0@oracle.com \
--to=chuck.lever@oracle.com \
--cc=alex.dewar90@gmail.com \
--cc=bfields@fieldses.org \
--cc=fllinden@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®