> It fixes the symptom, yes. Greg complained it's papering over the > problem and not a real fix, which is fair enough, but ... > > yes, it did seem to be a newly introduced problem in -mm1 or -mm2. To my > mind, if we don't have a proper fix, we ought to drop the patch that > caused the problem in the first place? Andy .. can you finger which > patch that was, I forget ... The fix I proposed (also attached to this email) fixes a bug introduced in the pci domain patches in greg's tree, specifically this patch: gregkh-pci-x86-pci-domain-support-struct-pci_sysdata.patch I believe that my fix is complete in the context of those changes, in that it returns the original semantics. As greg points out this exposes a couple of places where we do have proper domain and node information where it is not supplied. I have a patch or two waiting to be tested which tries to fill in some of the gaps exposed, but the boxes I was testing on have dropped off the network and am waiting for that to be fixed before sending them in. That said I think that if the pci domain patches are accepted then this minimal fix should be applied with them. -apw