Adrian Bunk wrote: >On Mon, Jan 23, 2006 at 06:06:28PM -0500, Mike Krufky wrote: > > >>Adrian Bunk wrote: >> >>>On Mon, Jan 23, 2006 at 06:24:44PM -0200, mchehab@infradead.org wrote: >>> >>>>@@ -70,6 +71,16 @@ config VIDEO_CX88_DVB_MT352 >>>> This adds DVB-T support for cards based on the >>>> Connexant 2388x chip and the MT352 demodulator. >>>> >>>>+config VIDEO_CX88_VP3054 >>>>+ tristate "VP-3054 Secondary I2C Bus Support" >>>>+ default m >>>> >>>This option should be a bool since "m" doesn't make much sense (it's >>>anyways interpreted the same as "y"). >>> >>You have a point - it is a boolean choice yes/no, about whether or not >>to compile support for this module, ... but it is in fact a module, and >>when M is chosen, cx88-vp3054-i2c.ko will build as a module. When Y is >>chosen, it will be built in-kernel. >> >> >I don't see this in your patches. > >All your patches do is to define -DHAVE_VP3054_I2C=1 depending on >CONFIG_VIDEO_CX88_VP3054. > Oops! I made a mistake, but not the one you thought. The attached patch fixes it. Mauro, I just applied this to CVS, please apply on v4l-dvb.git [PATCH] V4L/DVB: allow tristate build for cx88-vp3054-i2c - allow tristate build for cx88-vp3054-i2c Signed-off-by: Michael Krufky