From: "Jan Beulich" <jbeulich@novell.com>
To: <sam@ravnborg.org>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] consolidate command line escaping
Date: Tue, 31 Jan 2006 09:03:55 +0100 [thread overview]
Message-ID: <43DF19EC020000780000F8BE@emea1-mh.id2.novell.com> (raw)
>> -cmd = @$(if $($(quiet)cmd_$(1)),\
>> - echo ' $(call escsq,$($(quiet)cmd_$(1)))' &&) $(cmd_$(1))
>> +cmd = @$(echo-cmd) $(cmd_$(1))
>Here you replace
> echo 'xxx' && cmd
>with
> echo 'xxx'; cmd
>
>Since we assume echo will always succeed I see no difference in
>behaviour, but I recall the '&&' was there for some specific reason.
>Just wondering why it is so - I see no problems with it.
Since I didn't see a difference in behavior, and it permitted more re-use of existing constructs, I thought it'd be
reasonable to be replaced; I didn't know of anything that would require the &&.
Jan
next reply other threads:[~2006-01-31 8:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-31 8:03 Jan Beulich [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-01-30 9:04 Jan Beulich
2006-01-30 21:49 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43DF19EC020000780000F8BE@emea1-mh.id2.novell.com \
--to=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®