mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Glen Turner <glen.turner@aarnet.edu.au>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Kumar Gala <galak@kernel.crashing.org>,
	rmk+kernel@arm.linux.org.uk, linux-kernel@vger.kernel.org
Subject: Re: 8250 serial console fixes -- issue
Date: Fri, 03 Feb 2006 12:28:46 +1030	[thread overview]
Message-ID: <43E2B8D6.1070707@aarnet.edu.au> (raw)
In-Reply-To: <1138844838.5557.17.camel@localhost.localdomain>


Hi Alan,

The serial console driver has a host of issues

  - end of line should be CR LF, not LF CR

  - 'r' option for CTS/RTS flow control assumes CTS is
    asserted when DSR is not asserted. This is wrong as
    lots of modems float control lines when off.  No
    control signals are defined is DSR is unasserted.

  - [SECURITY] 'r' should require DCD to be asserted
    before outputing characters. Otherwise we talk to
    Hayes modem command mode.  This allows a non-root
    user to re-program the modem and is a major security
    issue is people configure calling line identification
    or encryption to restrict use of the serial console.

  - 'r' option has insanely slow CTS timeout. So if a
    terminal server is inactive the kernel can take
    30 minutes to boot as each character write to the
    serial console requires a CTS timeout.

All of these have been reported to me multiple times
(I'm maintainer of the Remote-Serial-Console-HOWTO).

I occassionally clean up and repost a patch I wrote years
ago which never gets integrated (although it ships in the
patchset of a number of kernels from supercomputer vendors).
I'm happy to clean it up again if there's a hope of
integration.

See
   <http://www.aarnet.edu.au/~gdt/patch/console/serial-console.patch>
for the most recent attempt.

Thanks so much,
Glen

-- 
  Glen Turner         Tel: (08) 8303 3936 or +61 8 8303 3936
  Australia's Academic & Research Network  www.aarnet.edu.au

  parent reply	other threads:[~2006-02-03  2:00 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-02-02  1:21 Kumar Gala
2006-02-02  1:47 ` Alan Cox
2006-02-02  5:54   ` Kumar Gala
2006-02-02  8:05     ` Kumar Gala
2006-02-02 17:10       ` Kumar Gala
2006-02-03  1:58   ` Glen Turner [this message]
2006-02-03  9:40     ` Russell King
2006-02-03 14:27       ` Glen Turner
2006-02-03 16:02         ` Russell King
2006-02-03 17:08           ` Glen Turner
2006-02-03 22:23             ` Russell King
2006-02-04 11:15               ` Russell King
2006-02-04 16:18               ` Krzysztof Halasa
2006-02-04 23:16                 ` Russell King
2006-02-04 23:54                   ` Krzysztof Halasa
2006-02-05  0:00                     ` Russell King
2006-02-05 12:57                       ` Krzysztof Halasa
2006-02-03 17:46           ` Krzysztof Halasa
2006-02-03 22:13             ` Russell King
2006-02-04 16:08               ` Krzysztof Halasa
2006-02-04 23:20                 ` Russell King
2006-02-05  3:12                   ` Glen Turner
2006-02-05 21:26                     ` Krzysztof Halasa
2006-02-06  9:47                     ` Russell King
2006-02-07  3:27                       ` Glen Turner
2006-02-03 15:05       ` Kumar Gala
2006-02-06 20:26       ` Pavel Machek
2006-02-06 20:55         ` Russell King
2006-02-07  4:00           ` Glen Turner
2006-02-07  9:18           ` Pavel Machek
2006-02-07 17:43             ` Russell King
2006-02-07 22:23               ` Krzysztof Halasa
2006-02-08  0:59               ` Junio C Hamano
2006-02-08  1:19                 ` Lee Revell
2006-02-03 10:00 linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43E2B8D6.1070707@aarnet.edu.au \
    --to=glen.turner@aarnet.edu.au \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=galak@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome