From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: linux1394-devel@lists.sourceforge.net
Cc: Andrew Morton <akpm@osdl.org>, Miles Lane <miles.lane@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.16-rc2-mm1 -- BUG: warning at drivers/ieee1394/ohci1394.c:235/get_phy_reg()
Date: Sat, 11 Feb 2006 01:31:02 +0100 [thread overview]
Message-ID: <43ED3046.6020407@s5r6.in-berlin.de> (raw)
In-Reply-To: <20060210122131.4b98cfb4.akpm@osdl.org>
Andrew Morton wrote:
> Miles Lane <miles.lane@gmail.com> wrote:
>>BUG: warning at drivers/ieee1394/ohci1394.c:235/get_phy_reg()
>
> That's a -mm-only warning telling you that get_phy_reg() is doing a
> one-millisecond-or-more busywait while local interrupts are disabled.
Same with set_phy_reg, ohci_soft_reset, ohci_hw_csr_reg. At least the
callers of ohci_hw_csr_reg (in particular, csr_highlevel.host_reset,
furthermore csr_highlevel.add_host) could fairly easily be converted to
a workqueue job or perhaps moved to the nodemgr thread. I have not
checked the other offending functions yet.
--
Stefan Richter
-=====-=-==- --=- -=-==
http://arcgraph.de/sr/
next prev parent reply other threads:[~2006-02-11 0:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-02-10 20:07 Miles Lane
2006-02-10 20:21 ` Andrew Morton
2006-02-11 0:31 ` Stefan Richter [this message]
2006-02-11 2:30 ` Lee Revell
2006-02-11 8:39 ` Stefan Richter
2006-02-11 2:28 ` Lee Revell
2006-02-11 4:37 ` Andrew Morton
2006-02-11 8:50 ` Stefan Richter
2006-02-11 9:03 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ED3046.6020407@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=miles.lane@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®