From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A16C33E51E7 for ; Thu, 23 Apr 2026 09:31:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776936701; cv=none; b=AWiARKvzrFg/csqS8l3w/LUrZX+D9k9nCWu5Q0vQtULEm3U7MMsB5aiVGpw7p7HXzVDGYIqoJofvuZfjPLce/B62JcbUdN1jI/g5baliTmm41QlJ3VHPkSIo4JiLn7HcHUi6ddq2idjNJJVyzexgjwYSt8jTbFwlVsqGrVRL06s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1776936701; c=relaxed/simple; bh=OyeJjQc7m5w3nWMDA9c1cIClhsmP67PAU8W5OI9hm30=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Qs8R3+smdrcyrRlraXl5FO3NRPCbIVxvSz+YAUxxDa6e6nQPf/+kqqWjZbB1kY3tOkovSsNV0+CitcoW9UanD3mGIV/vZpryTfrl3z1G8jPb+ztwjYYbvcsnTiv2F8tnqOS3XUynYZzmVpVPJJ/1DbSe1xKWaKQC5FA7C1uXVTU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MI5jUi6F; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YSTMyuBT; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MI5jUi6F"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YSTMyuBT" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 63N8uBaM3294965 for ; Thu, 23 Apr 2026 09:31:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= sZ/xeSGjBxCBJLxIsRC02trYohcTKqRfx2FsyvqufKc=; b=MI5jUi6FTwLB+v8c EOnmSw+1dUtpR2hX+yuxELbmgCKYWmCB7aTndj8+DakigmxspezAhAN3Cd0t5t6O v9tLsrqCg3lYqv3nqsGR6ZROvj4aDqg/3/A39OxcVHoFYeUw+luTXT2yRowczKns eJzsIyu+uDSX09F/mlUCcC3W9wtWUEZHcFWoRvnN6F0XhTrszUVBklbZpkn2tlAi uXFfynLv4zqYWjdVmTXuOXoVGhGvw0ppO5VtdjpK0u2cEayfdD3UMPwUvnlk6y4p QsgiJ1KfQZMxi1FIxcu8y6XzDq1pQWNB2sGdiAZ/x2CUU9kxpbsmNbFvYFKamUUn UEtlLA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4dq282u38a-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 23 Apr 2026 09:31:39 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-50e5c781193so9026441cf.0 for ; Thu, 23 Apr 2026 02:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1776936699; x=1777541499; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=sZ/xeSGjBxCBJLxIsRC02trYohcTKqRfx2FsyvqufKc=; b=YSTMyuBTqAjQ9nZtvaNz3CKChAJjmYwDZ0cMMTFHvfmFVFMX25RFi8LpUkHO97FYRU PpGEUXiPRNs7xg/j8MDVfJc5IvZ9eECE/tFnX+vXYNDig2PD/mmSF9x/rSQU0vosWaHI mr7jSrmSrk1PvdmfJWvSdOyw/u5RiaZ/ZF4cv0LE4U7ax1VJ2Q6dMSS7NjgLY60eDTnL jpWO1C2ROVSRL/cS+g4kEHq08NSvi88F1jeqHoEjTob5IINnLeiYELQT8IcdZLFZ/FZE qoXYsf21JsImA8pGKv1DLzi/inmtnx9Ubg3YRJ8lSkNk0LIvf+rNiFQ5ByUdFNIJsy8d 5xvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776936699; x=1777541499; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=sZ/xeSGjBxCBJLxIsRC02trYohcTKqRfx2FsyvqufKc=; b=hAUMexh6H8R19p/txD7mrddZH7jEPrGnQdqbA4LwVHtYRFHK4cwQuXurMKubBOCnF7 emAI1Om3lr4cD2Q7/RouGDtYI1Bst+D9o/gd9acLtLIYe2rofndDm5b4g7N6PTioWS8X JoiNSBB89zvi85QthjkcbMvTptSNWY7tgibude4WZCrsrs93rRkSYYslUT6xP/CO7gKw suN5s9LBn23Maa7O2gvYT3g4maAFDyBkhToYwMxqAji7fiSDFGJET5GJg5fTSnJGKafu la6Ou6I4NpNVa+3hDHjVICVRtg2LduslnZZhAJ+GcpWcL6ASMZaevTbvoVtlx8OOvo9p Glmg== X-Forwarded-Encrypted: i=1; AFNElJ9tuy0TpxrExJr8JToV/SHi0TZ9oMVSJ+hHTKtD6oLInGWFN1nDMzCXZEBR2z+9woJl9fl7W4Rqx70Ir4o=@vger.kernel.org X-Gm-Message-State: AOJu0YwNvW8p1yFszLwgTTTMPy/y7k6bWMk0C4hUepFwSVSRM4vRXclj znnLXzzdj1dKK+EyYe4qCa7OkkB18vFNdOAmN79bCdL25q2PKupe9TzIBc8+PdyievLNp2qVxEG N3nNtxAnfGczIzUamqNtMRbUUz3TFWSA4kVCZXLMsgLEzIU+UqdNagtpIgNn56w3DIzc= X-Gm-Gg: AeBDieveODZa4M3MbenP7qM6rkSY/BXcmNPQkAutNgLSpmlgbYEuMnvpErUgsf+ZPAp WZjtwN11PxNssdTbGSFEqrVy55K+HkXHe44YjVZiBmxS1JAJwraaKzYB+i7jAFdLvt3pr5lV8NJ HM003p6ycnjFe2nI7v9NYUsvY62HGqDpO7zc4yjV5q32AKuesxUICvgYwEFjlaf5LFPhjR5G5Zr BYie1NK0Av+Sm+vbSPGw5jD+eYrDrvIVxMqr+Hk4ulUd4wqLJoeB11zYnstW2CSnKlIIWJoEiPB x5ocN1Bp37PhHMF3hVP2BY1HVz/M87hi1NOGQt2N4dBoElsSxEmCwqwz2LkgWUf3208XaQngq9Y swacpzNHGBOgliyN4+VXMxQKQVYgFJ6fSDKd7NuMCmbEz53fj8+gZ/ar77StI0Z9gm8TcvTs1n9 CcIhjLyPRVWlY9uQ== X-Received: by 2002:ac8:5741:0:b0:50b:5286:f757 with SMTP id d75a77b69052e-50e36c140c7mr245205231cf.4.1776936698906; Thu, 23 Apr 2026 02:31:38 -0700 (PDT) X-Received: by 2002:ac8:5741:0:b0:50b:5286:f757 with SMTP id d75a77b69052e-50e36c140c7mr245204871cf.4.1776936698416; Thu, 23 Apr 2026 02:31:38 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-672c4d508e7sm3710498a12.20.2026.04.23.02.31.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Apr 2026 02:31:36 -0700 (PDT) Message-ID: <43a6ac95-8f6a-460d-bbf3-f8b1d082b8d5@oss.qualcomm.com> Date: Thu, 23 Apr 2026 11:31:34 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/5] phy: qcom: edp: Add SC7280/SC8180X swing/pre-emphasis tables To: Dmitry Baryshkov Cc: Yongxing Mou , Vinod Koul , Neil Armstrong , Stephen Boyd , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260422-edp_phy-v4-0-c38bef2d027b@oss.qualcomm.com> <20260422-edp_phy-v4-3-c38bef2d027b@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDIzMDA5MiBTYWx0ZWRfX8KB1Y5AoYdRQ fbRosp+ymbXw19m5D0rRvctkkVTQgYvhR+vbCqQmPmgR9BgEn5CCbxhFdrZaLUCh+oc/vwcorkH eM22dn306vIJXv0ANWW9hvYE4KyWpLVlIuvCkrH4guynYTiafFFC5ArM1Li/XMilQVKMAhTZDeY zBHnUa9fRcMYUR3rDInK7D7t6VRhX4/GHgvvWVV+UwDJzmqmEIPO7FQnt5ldxQ8PadL72jUVtNS nZdw+AWIVfJtFKDOx7Myv1e35bvZcjmQJv0jHGy5mU7Ic4wT7iM2RLhqNEjy5SLy8/xIuUFEDSA 0Gds91ijmLDpEu1cnsL8yUPOpjCcDmaeZxZH8E9iMhWZvNg1uQY8FzVAY5V6Df5BCV+bPbFM/dh 0ZAcU/1H5IBecS/sbZQl58e1IvmBBh8e0TofjTiFVkBhe8PQL61tbeTTAvr5TSWKdVnQbZ29mlT P8eqo/D1htzGEmpp1MQ== X-Authority-Analysis: v=2.4 cv=Zond7d7G c=1 sm=1 tr=0 ts=69e9e6fb cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=eoimf2acIAo5FJnRuUoq:22 a=EUspDBNiAAAA:8 a=9M6qboyCHJ9uvjCUQIkA:9 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 X-Proofpoint-GUID: LRh2p6Fu4nVhA-goLkackgPdJ7myegH4 X-Proofpoint-ORIG-GUID: LRh2p6Fu4nVhA-goLkackgPdJ7myegH4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-23_02,2026-04-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 malwarescore=0 suspectscore=0 clxscore=1015 impostorscore=0 spamscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2604200000 definitions=main-2604230092 On 4/22/26 6:33 PM, Dmitry Baryshkov wrote: > On Wed, Apr 22, 2026 at 12:42:56PM +0200, Konrad Dybcio wrote: >> On 4/22/26 8:01 AM, Yongxing Mou wrote: >>> SC7280 and SC8180X previously shared the same cfg because they did not use >>> swing/pre-emphasis tables. Add the corresponding tables for these >>> platforms. Since they have different PHY sub-versions, their eDP/DP mode >>> tables also differ, so move SC8180X to its own cfg instead of reusing the >>> SC7280 one. >>> >>> Signed-off-by: Yongxing Mou >>> --- >> >> >> >>> +static const struct qcom_edp_swing_pre_emph_cfg edp_phy_swing_pre_emph_cfg_v2 = { >>> + .swing_hbr_rbr = &edp_swing_hbr_rbr, >> >> For eDP / low-Vdiff: >> >> I believe the RBR swing settings for 8180 should >> instead be: >> >> 0x07 0x0f 0x17 0x1f (matches) > > 0x07, 0x0f, 0x16, 0x1f Yes, you're right Konrad