From: Daniel Bristot de Oliveira <bristot@redhat.com>
To: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Juri Lelli <juri.lelli@arm.com>,
Tommaso Cucinotta <tommaso.cucinotta@sssup.it>,
Luca Abeni <luca.abeni@santannapisa.it>,
Steven Rostedt <rostedt@goodmis.org>,
Mike Galbraith <efault@gmx.de>,
Romulo Silva de Oliveira <romulo.deoliveira@ufsc.br>
Subject: Re: [PATCH V3 2/3] sched/deadline: Throttle a constrained deadline task activated after the deadline
Date: Tue, 28 Feb 2017 19:19:45 +0100 [thread overview]
Message-ID: <43aa3b8c-5f5a-50f9-0d3d-aac86c5fcd3f@redhat.com> (raw)
In-Reply-To: <5b6fa3cd9da84b8883afc169f44df247b551a4df.1488271007.git.bristot@redhat.com>
On 02/28/2017 11:07 AM, Daniel Bristot de Oliveira wrote:
> + if (!pi_se->dl_throttled && dl_is_constrained(pi_se))
> + dl_check_constrained_dl(pi_se);
> +
me--, it should be &p->dl, not pi_se. This is not causing problems in
the test case because pi_se = &p->dl, but this would be a problem if we
were activating the task in a PI case: it would check the pi-waiter, not
the task being awakened (p).
In the dl_check_constrained_dl(), the patch is already avoiding
throttling if the task is "dl_boosted." So it is ready to avoid
throttling the task in the PI control.
Cooking a v4, sorry for the noise.
-- Daniel
next prev parent reply other threads:[~2017-02-28 18:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-28 10:07 [PATCH V3 0/3] sched/deadline: Fixes for constrained deadline tasks Daniel Bristot de Oliveira
2017-02-28 10:07 ` [PATCH V3 1/3] sched/deadline: Replenishment timer should fire in the next period Daniel Bristot de Oliveira
2017-03-07 6:21 ` Wanpeng Li
2017-02-28 10:07 ` [PATCH V3 2/3] sched/deadline: Throttle a constrained deadline task activated after the deadline Daniel Bristot de Oliveira
2017-02-28 16:04 ` Steven Rostedt
2017-02-28 18:19 ` Daniel Bristot de Oliveira [this message]
2017-02-28 10:07 ` [PATCH V3 3/3] sched/deadline: Use deadline instead of period when calculating overflow Daniel Bristot de Oliveira
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43aa3b8c-5f5a-50f9-0d3d-aac86c5fcd3f@redhat.com \
--to=bristot@redhat.com \
--cc=efault@gmx.de \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.abeni@santannapisa.it \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=romulo.deoliveira@ufsc.br \
--cc=rostedt@goodmis.org \
--cc=tommaso.cucinotta@sssup.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®