From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935144AbcI3AGV (ORCPT ); Thu, 29 Sep 2016 20:06:21 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:33699 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934896AbcI3AGO (ORCPT ); Thu, 29 Sep 2016 20:06:14 -0400 Reply-To: minyard@acm.org Subject: Re: [PATCH -next] ipmi/bt-bmc: remove redundant return value check of platform_get_resource() References: <1474718574-14445-1-git-send-email-weiyj.lk@gmail.com> To: Wei Yongjun , Corey Minyard Cc: Wei Yongjun , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org From: Corey Minyard Message-ID: <43ab214b-79ea-0422-1d1b-ab9e38093b6e@gmail.com> Date: Thu, 29 Sep 2016 19:06:11 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1474718574-14445-1-git-send-email-weiyj.lk@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks, applied. -corey On 09/24/2016 07:02 AM, Wei Yongjun wrote: > From: Wei Yongjun > > Remove unneeded error handling on the result of a call > to platform_get_resource() when the value is passed to > devm_ioremap_resource(). > > Signed-off-by: Wei Yongjun > --- > drivers/char/ipmi/bt-bmc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c > index de64bf1..b49e613 100644 > --- a/drivers/char/ipmi/bt-bmc.c > +++ b/drivers/char/ipmi/bt-bmc.c > @@ -432,11 +432,6 @@ static int bt_bmc_probe(struct platform_device *pdev) > dev_set_drvdata(&pdev->dev, bt_bmc); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(dev, "Unable to find resources\n"); > - return -ENXIO; > - } > - > bt_bmc->base = devm_ioremap_resource(&pdev->dev, res); > if (IS_ERR(bt_bmc->base)) > return PTR_ERR(bt_bmc->base); >