From: Ravi Bangoria <ravi.bangoria@amd.com>
To: Tianyou Li <tianyou.li@intel.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, "Ian Rogers" <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
"Kan Liang" <kan.liang@linux.intel.com>, <wangyang.guo@intel.com>,
<pan.deng@intel.com>, <zhiguo.zhou@intel.com>,
<jiebin.sun@intel.com>, <thomas.falcon@intel.com>,
<dapeng1.mi@intel.com>, <linux-perf-users@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] perf tools c2c: Add annotation support to perf c2c report
Date: Fri, 10 Oct 2025 11:26:14 +0530 [thread overview]
Message-ID: <43ac631c-3404-4e15-a02e-d1976ead4956@amd.com> (raw)
In-Reply-To: <20251009042839.1643396-1-tianyou.li@intel.com>
On 09-Oct-25 9:58 AM, Tianyou Li wrote:
> Perf c2c report currently specified the code address and source:line
> information in the cacheline browser, while it is lack of annotation
> support like perf report to directly show the disassembly code for
> the particular symbol shared that same cacheline. This patches add
> a key 'a' binding to the cacheline browser which reuse the annotation
> browser to show the disassembly view for easier analysis of cacheline
> contentions.
>
> Signed-off-by: Tianyou Li <tianyou.li@intel.com>
> Reviewed-by: Dapeng Mi <dapeng1.mi@linux.intel.com>
> Reviewed-by: Thomas Falcon <thomas.falcon@intel.com>
> Reviewed-by: Jiebin Sun <jiebin.sun@intel.com>
> Reviewed-by: Pan Deng <pan.deng@intel.com>
> Reviewed-by: Zhiguo Zhou <zhiguo.zhou@intel.com>
> Reviewed-by: Wangyang Guo <wangyang.guo@intel.com>
Works fine on AMD.
Tested-by: Ravi Bangoria <ravi.bangoria@amd.com>
next prev parent reply other threads:[~2025-10-10 5:56 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 7:51 [PATCH] " Tianyou Li
2025-08-19 8:00 ` [PATCH v2] " Tianyou Li
2025-09-03 13:50 ` Arnaldo Carvalho de Melo
2025-09-07 14:53 ` Li, Tianyou
2025-09-07 15:25 ` [PATCH v3] " Tianyou Li
2025-09-11 21:39 ` Namhyung Kim
2025-09-12 15:20 ` Li, Tianyou
2025-09-17 6:34 ` Namhyung Kim
2025-09-24 7:33 ` Li, Tianyou
2025-09-28 9:02 ` [PATCH v4] " Tianyou Li
2025-09-28 8:16 ` Li, Tianyou
2025-09-29 8:07 ` Namhyung Kim
2025-09-30 11:41 ` Li, Tianyou
2025-09-30 12:39 ` [PATCH v5] " Tianyou Li
2025-10-03 5:05 ` Namhyung Kim
2025-10-03 11:44 ` Li, Tianyou
2025-10-07 8:23 ` Namhyung Kim
2025-10-09 3:47 ` Li, Tianyou
2025-10-09 4:28 ` [PATCH v6] " Tianyou Li
2025-10-10 5:56 ` Ravi Bangoria [this message]
2025-10-10 7:49 ` Li, Tianyou
2025-10-10 8:33 ` [PATCH v6 1/3] " Tianyou Li
2025-10-10 8:33 ` [PATCH v6 2/3] perf tools annotate: Fix a crash/hang when switch disassemble and source view Tianyou Li
2025-10-10 8:33 ` [PATCH v6 3/3] perf tools c2c: Highlight the contention line in the annotate browser Tianyou Li
2025-10-10 8:35 ` [PATCH v6 1/3] perf tools c2c: Add annotation support to perf c2c report Tianyou Li
2025-10-10 8:35 ` [PATCH v6 2/3] perf tools annotate: Fix a crash/hang when switch disassemble and source view Tianyou Li
2025-10-10 8:35 ` [PATCH v6 3/3] perf tools c2c: Highlight the contention line in the annotate browser Tianyou Li
2025-10-10 13:08 ` Namhyung Kim
2025-10-11 8:16 ` [PATCH v7 1/2] perf tools c2c: Add annotation support to perf c2c report Tianyou Li
2025-10-13 8:52 ` Ravi Bangoria
2025-10-13 13:43 ` Li, Tianyou
2025-10-13 14:48 ` [PATCH v8 " Tianyou Li
2025-10-20 2:12 ` Namhyung Kim
2025-10-13 14:48 ` [PATCH v8 2/2] perf tools c2c: Highlight the contention line in the annotate browser Tianyou Li
2025-10-11 8:16 ` [PATCH v7 " Tianyou Li
2025-10-06 10:54 ` [PATCH v5] perf tools c2c: Add annotation support to perf c2c report Ravi Bangoria
2025-10-09 5:34 ` Li, Tianyou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43ac631c-3404-4e15-a02e-d1976ead4956@amd.com \
--to=ravi.bangoria@amd.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=dapeng1.mi@intel.com \
--cc=irogers@google.com \
--cc=jiebin.sun@intel.com \
--cc=jolsa@kernel.org \
--cc=kan.liang@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=pan.deng@intel.com \
--cc=peterz@infradead.org \
--cc=thomas.falcon@intel.com \
--cc=tianyou.li@intel.com \
--cc=wangyang.guo@intel.com \
--cc=zhiguo.zhou@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®