From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3FA10C19F2B for ; Thu, 4 Aug 2022 09:51:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239394AbiHDJvs (ORCPT ); Thu, 4 Aug 2022 05:51:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37054 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239392AbiHDJvn (ORCPT ); Thu, 4 Aug 2022 05:51:43 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4497A26AE5 for ; Thu, 4 Aug 2022 02:51:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659606699; x=1691142699; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=1mAFulNWoLFTDJufnr4AN2fWHLLvDVf708xkkVeQJ1E=; b=M+/3U3Ovfr9OCwTzG146hQeYzhjcBldufqZndJW83LTxYvNOyrQ5mkgV eMcABYYeo4EyebC1WrKkiBF0SBrjS4CiEGzMBRe27jJGLReCLa2ZVEJh7 gMpj69cIbByFFq7t7dkHPUvCtzJ4ZvZZqdRzVrC+X2cts3LXrA6gJ+R90 KQU9kiHi4YCUSQa5EXmHpGZTEzwSs/VT6mLoej16XrMLtLu2ezxDomEMX XhU2DoFVpQQ2w20RlqHzAi7KLFS8QyP7olL5jmTk5hy4VvtW9VcZix7g5 wzRp1edxGMeRGVpSU21ZjdCIBYjCro6HjIQZDfmqQtNtTCSmz2uxnWCOF A==; X-IronPort-AV: E=McAfee;i="6400,9594,10428"; a="272939370" X-IronPort-AV: E=Sophos;i="5.93,215,1654585200"; d="scan'208";a="272939370" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2022 02:51:38 -0700 X-IronPort-AV: E=Sophos;i="5.93,215,1654585200"; d="scan'208";a="745405452" Received: from mpcastil-mobl2.amr.corp.intel.com (HELO [10.249.40.52]) ([10.249.40.52]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Aug 2022 02:51:34 -0700 Message-ID: <43ada0d7-f094-7f63-3717-30c64834edd6@linux.intel.com> Date: Thu, 4 Aug 2022 11:47:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Firefox/91.0 Thunderbird/91.11.0 Subject: Re: [PATCH resend] ASoC: SOF: ipc3-topology: Fix clang -Wformat warning Content-Language: en-US To: Nathan Chancellor , Justin Stitt Cc: Daniel Baluta , alsa-devel@alsa-project.org, llvm@lists.linux.dev, Kai Vehmanen , Bard Liao , Takashi Iwai , Nick Desaulniers , Liam Girdwood , Mark Brown , Ranjani Sridharan , Tom Rix , Peter Ujfalusi , linux-kernel@vger.kernel.org, sound-open-firmware@alsa-project.org References: <20220803204442.2996580-1-justinstitt@google.com> From: Pierre-Louis Bossart In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/3/22 15:47, Nathan Chancellor wrote: > On Wed, Aug 03, 2022 at 01:44:42PM -0700, Justin Stitt wrote: >> When building with Clang we encounter these warnings: >> | sound/soc/sof/ipc3-topology.c:2343:4: error: format specifies type >> | 'unsigned char' but the argument has type 'int' [-Werror,-Wformat] >> | SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); >> | ^~~~~~~~~~~~~~~^~~~~~~~~~~~~~~^~~~~~~~~~~~~ >> >> Use correct format specifier `%d` since args are of type int. >> >> Link: https://github.com/ClangBuiltLinux/linux/issues/378 >> Reported-by: Nathan Chancellor >> Suggested-by: Nathan Chancellor >> Signed-off-by: Justin Stitt > > Thanks for resending! > > Reviewed-by: Nathan Chancellor Acked-by: Pierre-Louis Bossart > >> --- >> Note: resending with the subject corrected, this patch fixes a build >> warning that will break the Clang build when CONFIG_WERROR=y. >> >> Original patch: https://lore.kernel.org/all/20220721211218.4039288-1-justinstitt@google.com/ >> Reported by Nathan here: https://lore.kernel.org/all/YtmrCJjQrSbv8Aj1@dev-arch.thelio-3990X/ >> >> sound/soc/sof/ipc3-topology.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/sound/soc/sof/ipc3-topology.c b/sound/soc/sof/ipc3-topology.c >> index b2cc046b9f60..65923e7a5976 100644 >> --- a/sound/soc/sof/ipc3-topology.c >> +++ b/sound/soc/sof/ipc3-topology.c >> @@ -2338,7 +2338,7 @@ static int sof_ipc3_parse_manifest(struct snd_soc_component *scomp, int index, >> } >> >> dev_info(scomp->dev, >> - "Topology: ABI %d:%d:%d Kernel ABI %hhu:%hhu:%hhu\n", >> + "Topology: ABI %d:%d:%d Kernel ABI %d:%d:%d\n", >> man->priv.data[0], man->priv.data[1], man->priv.data[2], >> SOF_ABI_MAJOR, SOF_ABI_MINOR, SOF_ABI_PATCH); >> >> -- >> 2.37.1.359.gd136c6c3e2-goog >>