From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755123AbdLTMCA (ORCPT ); Wed, 20 Dec 2017 07:02:00 -0500 Received: from mout.web.de ([217.72.192.78]:56852 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754153AbdLTMB6 (ORCPT ); Wed, 20 Dec 2017 07:01:58 -0500 Subject: [PATCH 1/2] pinctrl: adi2: Delete an error message for a failed memory allocation in two functions From: SF Markus Elfring To: linux-gpio@vger.kernel.org, Linus Walleij , Sonic Zhang Cc: LKML , kernel-janitors@vger.kernel.org References: <3d620bed-db19-aacd-0ea5-4c64aee104d1@users.sourceforge.net> Message-ID: <43b12b78-51a4-d590-9f61-e1ec61e291bc@users.sourceforge.net> Date: Wed, 20 Dec 2017 13:01:52 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <3d620bed-db19-aacd-0ea5-4c64aee104d1@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:SilfvnYcDvjYWm1IBFSX32gp4EtDK7B+S1CvnzzA5HgLEwYoKL6 ZBgwsmNtOIlPjL+cTRKlpwSO8084UXK0ZZ7OvPpA2LClOSIvWh/Yb7HCWCvyTieFMmRqiST fQbdi8uwg4sgPuTFtHAKLJFTGn2Gp5IsfTampnXsJRzAiSSFa1u4FeebEaNEHmOxPsYOZe0 7jCcluTWpZwsk9/5vyP7A== X-UI-Out-Filterresults: notjunk:1;V01:K0:nDvEHvVjb3Y=:vvhXtNOHu6ulIfk+hxQTcN 6G8+AsE/6bz8QJvpM6q+VRlKPGsZhFDiRsAW8O5WUZW/ij7bRLlNQsg6Xqg73ux5Oiblz/BKK feI59JaVRKzsYzu2YwRE2+qNZ7XnET81npqyrvBofag+RbmZGp/of2ORR6q4Pw9UBH2nLeUNS 3H5vesYs1v1/H6hyA+rV7DF3CkbWMnMxT9OurjXpi1GtHyvqSKz5oIjcx4bM6+66UUF32/xMJ R+B54GyHk6pXlDHC4XQw19Zt8qD5bs/6vB8IzMlIh/UTCrQiWX5IMNhOIvEsry17RggJDDThF 2Ve/R5zmEATwMeq5lqU1B+Am0qegufNY+5jUiCgLYVh234/J7nfONg6D6o3izZ8Cbc803KQj1 4dlwakQfXRFx02F9IQmGsHdRsVVyzyubZTBdjGjWU9wQVF8RJCrI1c3D9jO/UiaBog/0c26Ct cbC4lLGIPHjMOB4MSe3pZHdGBe930czQ0W9hLPQw4/rXySXLTmEadX8UZZsWTyXmB9d7zPxHf ThGoUjTEdsG+S6FDp3H6puG0qdxYySc5+HWgyKGNuF4JHPj2IxQXycDerabpZzkoCm942i6Rj roEmKfcHxWFNCkf+W7Bb89n73bloeC61RfmIQepL2iVwBGpoFfSFDI5NrJPNrKohbfkVkiHQH mqfwg6GTJuMQS66lpzW7y9L/ZrbB1GnnHlH6Kg5c4UgNBT/Dc0zIwcFC0Gl6kz18OneQUyFdt TPht7JUYcU29+bS2NKh7UOdGrSulPzE5zDjBeoNesikm9LL3zUHr2RV3KTg3CFr2raLE5YM8d f2vn6pb84YYArkpFZ1gZipsusHwVPJrRo4EQSbpRjZo+MxtPuc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Wed, 20 Dec 2017 12:32:10 +0100 Omit an extra message for a memory allocation failure in these functions. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/pinctrl/pinctrl-adi2.c | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/pinctrl-adi2.c b/drivers/pinctrl/pinctrl-adi2.c index 56aa181084ac..aefaf5855089 100644 --- a/drivers/pinctrl/pinctrl-adi2.c +++ b/drivers/pinctrl/pinctrl-adi2.c @@ -830,10 +830,8 @@ static int adi_gpio_pint_probe(struct platform_device *pdev) struct gpio_pint *pint; pint = devm_kzalloc(dev, sizeof(struct gpio_pint), GFP_KERNEL); - if (!pint) { - dev_err(dev, "Memory alloc failed\n"); + if (!pint) return -ENOMEM; - } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); pint->base = devm_ioremap_resource(dev, res); @@ -946,10 +944,8 @@ static int adi_gpio_probe(struct platform_device *pdev) return -EINVAL; port = devm_kzalloc(dev, sizeof(struct gpio_port), GFP_KERNEL); - if (!port) { - dev_err(dev, "Memory alloc failed\n"); + if (!port) return -ENOMEM; - } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); port->base = devm_ioremap_resource(dev, res); -- 2.15.1