From: Jens Axboe <axboe@kernel.dk>
To: Milan Broz <gmazyland@gmail.com>, linux-block@vger.kernel.org
Cc: gjoyce@linux.vnet.ibm.com, jonathan.derrick@linux.dev,
linux-kernel@vger.kernel.org, Ondrej Kozina <okozina@redhat.com>
Subject: Re: [PATCH] block: Fix regression in sed-opal for a saved key.
Date: Wed, 4 Oct 2023 14:28:51 -0600 [thread overview]
Message-ID: <43b1a228-9a60-40ef-936b-c8a062d7eb21@kernel.dk> (raw)
In-Reply-To: <20231003100209.380037-1-gmazyland@gmail.com>
On 10/3/23 4:02 AM, Milan Broz wrote:
> The commit 3bfeb61256643281ac4be5b8a57e9d9da3db4335
> introduced the use of keyring for sed-opal.
>
> Unfortunately, there is also a possibility to save
> the Opal key used in opal_lock_unlock().
>
> This patch switches the order of operation, so the cached
> key is used instead of failure for opal_get_key.
>
> The problem was found by the cryptsetup Opal test recently
> added to the cryptsetup tree.
Greg, please review this.
--
Jens Axboe
next prev parent reply other threads:[~2023-10-04 20:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-03 10:02 Milan Broz
2023-10-04 14:07 ` Milan Broz
2023-10-04 20:28 ` Jens Axboe [this message]
2023-10-04 20:54 ` Greg Joyce
2023-10-05 6:58 ` Milan Broz
2023-10-05 17:58 ` Greg Joyce
2023-10-11 8:30 ` Milan Broz
2023-10-13 14:17 ` Jens Axboe
2023-10-13 14:38 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-10-13 9:39 ` Ondrej Kozina
2023-10-13 14:17 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43b1a228-9a60-40ef-936b-c8a062d7eb21@kernel.dk \
--to=axboe@kernel.dk \
--cc=gjoyce@linux.vnet.ibm.com \
--cc=gmazyland@gmail.com \
--cc=jonathan.derrick@linux.dev \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=okozina@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®