From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f181.google.com (mail-pl1-f181.google.com [209.85.214.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70D9F15C14F for ; Sat, 28 Feb 2026 05:03:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772255024; cv=none; b=un8oOABebHlMbNHxJnMBQFVYyzw3AEuYYNLeCJqflQCT+DvPRwxXaLCLeAw2+454YmET3beqFSONdfH0cp/O/EwJTfCGKFJuBZE+fcRXg5u3f5auzcYO/1wNOS9LOi5XcFTwjbz5iOcqkGFYxo2QRAZtkmC31HhQTCKeKqj4NTg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772255024; c=relaxed/simple; bh=WZGn9t6Nnd4BlPrgobIshCbzAK0yZTeNkprJ1mTTlpw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PCt0Qk0KAV8rZO/AEDUWROHRMT/NJR0dV3TJgpD7RMHNAj0nWZjCS1yEyW5JHxC5Pk26Vsw1WWtwREYUItWZBqWaaCp2Yuk30GauGbKfEn40aEhW4Igtmsvjb01sZZj66IiUowngSjEwt5j/ws7aBAh+uh9+6NCqqMSskN6O0m0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=llsJnbYs; arc=none smtp.client-ip=209.85.214.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="llsJnbYs" Received: by mail-pl1-f181.google.com with SMTP id d9443c01a7336-2aaecf9c325so18369165ad.1 for ; Fri, 27 Feb 2026 21:03:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772255023; x=1772859823; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=riNYAikMZikDJOkTEd8N59a4JFCUVwaQB1blSZtd5Jg=; b=llsJnbYsDHHedFX7D8AiR6538cl+h1l8xED/JIJcNU2jxwpIdwAy+AW16GTvMVBUqn qniz8ZWSnNOpGa1xO5Swg/n+vcUF3ljrh36GBnd3X25mMx71ExCJi4pKy9JtQeeUwnUz 2iXd2s2Ox0HY47d+4F2dJqNN7DuOktizhfpF7Yl05QjSd3gIiSVdqb0wRFJfFfypM1Zz 7CK9HdurM9ZLi64Tu26mIPeJ9d4h0W9Am/CophmDIOB5gW9UCa4rI+xcYpkxI8usyjVR thhvN3P2xQ3aIH47bLb/1W8FFR289BCJAcVOAlayT2ARFGaiPvrV7W0OAp8q3hcGjGWY hRHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772255023; x=1772859823; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=riNYAikMZikDJOkTEd8N59a4JFCUVwaQB1blSZtd5Jg=; b=bFZtZlhOn3SY1t3F6SuO5zKDDdzQ8D2FlGHSRzbTwHQ6VBhtV0RWcIoIZQSZGk7n+l opcv8GLLsiWlpPiP1qTp5lMXVpGd8SXDEBdvu3GG37d6EdnsBRlhqd4BxHp3NF6dV8Jw xaVV40Za0FLOztQkgqcZkoIeCT07RXuRP9cd6TkFAESVVV3rfXdV/HQsuDLC3NyzIfUk cefk25ltYllZIQZPJsD0CD0SlAcaIUWAIx7p84cQEfUtKA7BldsZy64XvdJF67PMZW+Q nG6ftPc+CDac7tsQh+54Wm833yKxoRD2+NieeYXXaeDQUfa3XR7W4uq1895m4mlFulid X5gA== X-Forwarded-Encrypted: i=1; AJvYcCUq6OMSqkEyBf5llMquYfdmtNxe3jV7p8YYQAmtYM4ktbnSPCGCeQB6fhFfZ6YVOE+NU9PnK6ZbYxFW6io=@vger.kernel.org X-Gm-Message-State: AOJu0Yx4B/E3wy1dfUXPxsTegocWyaxpqihELZi0/TjNBHulLou1e/Oj i5O2602cp+uidqmkFeRo3eaECgAdYgz9I4qGyf7uzusuGPomWFguNRmL X-Gm-Gg: ATEYQzzugzh2T2CrINRQil8STYgfp8F49GL02UniNG9Yr3MM4EnmCN2QUNK5o01Kw4o bccHZ6A9WbvBhmzxvaKGcntU6T9EVxB+AZia1FaOGnW75R2QcPu2cuG7oLHsdNWtgfTrN7Vbcvq KL4R0txRSgarShkp9Y/apSdLn3SxlSXe03ScsFw7awLpu2RtBzSTrxOdDaDzVRLanuMBBCOmlVD qyAH52bY2btCuSmBAy07Yz9YbT7+ZOU5jdZOfJSD2AukqU3ypzVP+cJBU1dQVQ2VJVwXfaEJxoP 4SrxjSNylEnNB/Jp+8sZkdHZKmOo03536xUmBTeOXbVF5/kad7fmdGCbJ+gzYshJMQbQEUkRcdb JXS5/F8S1NAE9lqkIB7JZSsiYOMUyT/e5/lSNpLH9Mb1Ufrpq+9GPl6U8YlOTtvfcL3VKW0BazB 8Duk5pYHPbWSsemIJmmXnqfzWQFyH6KVFxUhu9ZOq126Vg50cJd22jhAkE8VilDj/MhFrWp6cPE Wwneg== X-Received: by 2002:a17:903:1a03:b0:2aa:e3d1:1430 with SMTP id d9443c01a7336-2ae2bbd72fbmr53761865ad.23.1772255022668; Fri, 27 Feb 2026 21:03:42 -0800 (PST) Received: from ?IPV6:2001:ee0:4f0f:b1d0:aab1:76d6:d5d9:2ab0? ([2001:ee0:4f0f:b1d0:aab1:76d6:d5d9:2ab0]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2ae3d1b2c51sm4794775ad.19.2026.02.27.21.03.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Feb 2026 21:03:42 -0800 (PST) Message-ID: <43b3b8dc-bc99-497a-a845-a9697c126d3f@gmail.com> Date: Sat, 28 Feb 2026 12:03:31 +0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] virtio-net: xsk: Support wakeup on RX side To: Jason Xing Cc: netdev@vger.kernel.org, "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , =?UTF-8?Q?Eugenio_P=C3=A9rez?= , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , virtualization@lists.linux.dev, linux-kernel@vger.kernel.org References: <20260227150949.13089-1-minhquangbui99@gmail.com> Content-Language: en-US From: Bui Quang Minh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Jason, On 2/28/26 10:49, Jason Xing wrote: > Hi Bui, > > On Fri, Feb 27, 2026 at 11:20 PM Bui Quang Minh > wrote: >> When XDP_USE_NEED_WAKEUP is used and the fill ring is empty so no buffer >> is allocated on RX side, allow RX NAPI to be descheduled. This avoids >> wasting CPU cycles on polling. Users will be notified and they need to >> make a wakeup call after refilling the ring. >> >> Signed-off-by: Bui Quang Minh >> --- >> drivers/net/virtio_net.c | 38 ++++++++++++++++++++++++++++++-------- >> 1 file changed, 30 insertions(+), 8 deletions(-) >> >> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c >> index db88dcaefb20..494acc904b2c 100644 >> --- a/drivers/net/virtio_net.c >> +++ b/drivers/net/virtio_net.c >> @@ -1454,8 +1454,19 @@ static int virtnet_add_recvbuf_xsk(struct virtnet_info *vi, struct receive_queue >> xsk_buffs = rq->xsk_buffs; >> >> num = xsk_buff_alloc_batch(pool, xsk_buffs, rq->vq->num_free); >> - if (!num) >> + if (!num) { >> + if (xsk_uses_need_wakeup(pool)) { >> + xsk_set_rx_need_wakeup(pool); >> + /* Return 0 instead of -ENOMEM so that NAPI is >> + * descheduled. >> + */ >> + return 0; >> + } >> + >> return -ENOMEM; >> + } else { >> + xsk_clear_rx_need_wakeup(pool); >> + } >> >> len = xsk_pool_get_rx_frame_size(pool) + vi->hdr_len; >> >> @@ -1588,20 +1599,21 @@ static bool virtnet_xsk_xmit(struct send_queue *sq, struct xsk_buff_pool *pool, >> return sent; >> } >> >> -static void xsk_wakeup(struct send_queue *sq) >> +static void xsk_wakeup(struct napi_struct *napi, struct virtqueue *vq) >> { >> - if (napi_if_scheduled_mark_missed(&sq->napi)) >> + if (napi_if_scheduled_mark_missed(napi)) >> return; >> >> local_bh_disable(); >> - virtqueue_napi_schedule(&sq->napi, sq->vq); >> + virtqueue_napi_schedule(napi, vq); >> local_bh_enable(); >> } >> >> static int virtnet_xsk_wakeup(struct net_device *dev, u32 qid, u32 flag) >> { >> struct virtnet_info *vi = netdev_priv(dev); >> - struct send_queue *sq; >> + struct napi_struct *napi; >> + struct virtqueue *vq; >> >> if (!netif_running(dev)) >> return -ENETDOWN; >> @@ -1609,9 +1621,19 @@ static int virtnet_xsk_wakeup(struct net_device *dev, u32 qid, u32 flag) >> if (qid >= vi->curr_queue_pairs) >> return -EINVAL; >> >> - sq = &vi->sq[qid]; >> + if (flag == XDP_WAKEUP_TX) { > Better use &? Sorry, I don't get your point. Can you elaborate more? Thanks, Quang Minh.