From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C325C4321A for ; Sun, 28 Apr 2019 16:07:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3B39E2067D for ; Sun, 28 Apr 2019 16:07:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726949AbfD1QHF (ORCPT ); Sun, 28 Apr 2019 12:07:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56906 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726674AbfD1QHF (ORCPT ); Sun, 28 Apr 2019 12:07:05 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CBB633091782; Sun, 28 Apr 2019 16:07:04 +0000 (UTC) Received: from llong.remote.csb (ovpn-120-22.rdu2.redhat.com [10.10.120.22]) by smtp.corp.redhat.com (Postfix) with ESMTP id 424CD5D9CA; Sun, 28 Apr 2019 16:07:03 +0000 (UTC) Subject: Re: [PATCH-tip v6 01/20] locking/rwsem: Prevent decrement of reader count before increment To: Peter Zijlstra , Ingo Molnar , Will Deacon , Thomas Gleixner , Borislav Petkov , "H. Peter Anvin" Cc: linux-kernel@vger.kernel.org, x86@kernel.org, Davidlohr Bueso , Linus Torvalds , Tim Chen , huang ying , stable@vger.kernel.org References: <20190428155755.14267-1-longman@redhat.com> <20190428155755.14267-2-longman@redhat.com> From: Waiman Long Organization: Red Hat Message-ID: <43b4250d-d9b5-a4b6-ee1b-d256ecddd105@redhat.com> Date: Sun, 28 Apr 2019 12:07:02 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190428155755.14267-2-longman@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Sun, 28 Apr 2019 16:07:05 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4/28/19 11:57 AM, Waiman Long wrote: > During my rwsem testing, it was found that after a down_read(), the > reader count may occasionally become 0 or even negative. Consequently, > a writer may steal the lock at that time and execute with the reader > in parallel thus breaking the mutual exclusion guarantee of the write > lock. In other words, both readers and writer can become rwsem owners > simultaneously. I would like to have this particular patch merged in the next merge window, if possible, so that I can backport it downstream. Thanks, Longman