From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9501BC43463 for ; Fri, 18 Sep 2020 17:43:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5F11A22208 for ; Fri, 18 Sep 2020 17:43:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600451033; bh=bmrz+5cSN1jQUkPE/uJ3j/F7IxA5I9S0PGdC3Yy94n8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=H5pxqp89AZnozB4pcfUpDX/iyYyLC7LHgEbx2qEoyLuVP7fzfRebXx56tlD73q1nt 8Xz4se9V0oj0Y1xjjaojVaxVjp3EucWziXOo0nM1CnszBB+9lEeWYQl857B3i7QYBC tBN4xRPW3nWLGzCE5iqUpsrxcyh0skCGBhD57j+E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726253AbgIRRnw (ORCPT ); Fri, 18 Sep 2020 13:43:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:46078 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725955AbgIRRnv (ORCPT ); Fri, 18 Sep 2020 13:43:51 -0400 Received: from lt-jalone-7480.mtl.com (c-24-6-56-119.hsd1.ca.comcast.net [24.6.56.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id EAF2021707; Fri, 18 Sep 2020 17:43:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1600451031; bh=bmrz+5cSN1jQUkPE/uJ3j/F7IxA5I9S0PGdC3Yy94n8=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=sFAWCIGgv4gKZH5aIEyNTRds2vifCG1UDOCdP71ag5gDgSHoNzNEVzmp959LxkCTd 2VKVPEcUrbt2olxvm6qFdoCXEe0OjSs/bpqIBbzTf3F1q6QD4yg/pq5gRKvOli9Mzz q/rvAFit09mAlHKnWMtL3EoT/oTEKtvnCQX2koHA= Message-ID: <43ba897632383543e6d7e82f141ad14a265b46f7.camel@kernel.org> Subject: Re: [PATCH net-next] liquidio: Fix -Wmissing-prototypes warnings for liquidio From: Saeed Mahameed To: Wang Hai , dchickles@marvell.com, sburla@marvell.com, fmanlunas@marvell.com, davem@davemloft.net, kuba@kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 18 Sep 2020 10:43:50 -0700 In-Reply-To: <20200918130210.16902-1-wanghai38@huawei.com> References: <20200918130210.16902-1-wanghai38@huawei.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 2020-09-18 at 21:02 +0800, Wang Hai wrote: > If the header file containing a function's prototype isn't included > by > the sourcefile containing the associated function, the build system > complains of missing prototypes. > > Fixes the following W=1 kernel build warning(s): > > drivers/net/ethernet/cavium/liquidio/cn68xx_device.c:124:5: warning: > no previous prototype for ‘lio_setup_cn68xx_octeon_device’ [- > Wmissing-prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:159:1: warning: > no previous prototype for ‘octeon_pci_read_core_mem’ [-Wmissing- > prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:168:1: warning: > no previous prototype for ‘octeon_pci_write_core_mem’ [-Wmissing- > prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:176:5: warning: > no previous prototype for ‘octeon_read_device_mem64’ [-Wmissing- > prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:185:5: warning: > no previous prototype for ‘octeon_read_device_mem32’ [-Wmissing- > prototypes] > drivers/net/ethernet/cavium/liquidio/octeon_mem_ops.c:194:6: warning: > no previous prototype for ‘octeon_write_device_mem32’ [-Wmissing- > prototypes] > > Signed-off-by: Wang Hai > Reviewed-by: Saeed Mahameed