From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f51.google.com (mail-lf1-f51.google.com [209.85.167.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DA62835972 for ; Tue, 14 Jan 2025 13:53:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736862809; cv=none; b=c58b1wJy1pwIr5fueNpp3kDqCxFLjKn+Kkma4OsNGxYoWW11Co/N9POqOgKiOHTUdmtw9g1TotxmCwDrnSSac0VWYjH3oQOyI6MP0HmYAMXp8y5GdB9bRRXJV60biJMcdjxiuMamUdAg4nWF6kIkqgcWSCadg3V1U6wpLl+0pEs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736862809; c=relaxed/simple; bh=hJkX5+o+uJNtJT90xi4kgUIBJmunFB2qz5pb5sKqQRw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iHDw+lLNvOo6Xqak935KuNEoQIuK2WdqzbONK78ri4nHWx8WI7ULrHBtDTIN++3EfFQ9AoWNxFbD73blXj5Fla7g7iWE4A7a7X52e+c0vzwU4boQHiyFf4whXOZByCfx8jVJtBQqXmHGa49ApR/PBx1KwuiSld7dPQ5cli4UVe4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=remarkable.no; spf=pass smtp.mailfrom=remarkable.no; dkim=pass (2048-bit key) header.d=remarkable.no header.i=@remarkable.no header.b=VVdqWxN7; arc=none smtp.client-ip=209.85.167.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=remarkable.no Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=remarkable.no Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=remarkable.no header.i=@remarkable.no header.b="VVdqWxN7" Received: by mail-lf1-f51.google.com with SMTP id 2adb3069b0e04-5401ab97206so5463735e87.3 for ; Tue, 14 Jan 2025 05:53:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=remarkable.no; s=google; t=1736862806; x=1737467606; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=hJkX5+o+uJNtJT90xi4kgUIBJmunFB2qz5pb5sKqQRw=; b=VVdqWxN7Vfzjw6FtzWsF4xevt1EdWtHXTEBSVLHsSq8XRaQlgAng2e4TuSCPlE6Cip rpTQKmhgmUAQBRS89ty52/x5fKWI1TVpb8U5Vc0gSpx/tE1ONep4eHWmDCpGkBWVmEoE qVfgcjRh5fw61UrLS3UakTJO8yj05+Wdzy8Vzwodqcn15hZVxsOPShcLgvqpkUGqNufQ PlOF0WQVDkwaJ4Vmco/zM+EQgUyHgeRQ6igj5pQ7CqgbSU0U/+nsJbspLAA4R4LzIbQ+ M+NqlL7DClkTUG4gzx+mM4/WcrPLD1w7j8q/3WQwTMkHwVqLI+kjwsW3fzSQAp18h3NU HImg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736862806; x=1737467606; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=hJkX5+o+uJNtJT90xi4kgUIBJmunFB2qz5pb5sKqQRw=; b=VUBBiufuVA7ZWRmUAjoIls8Z294XpvVYqmwOAN+X8db4q15+7b5gqOMEivihsrUI2g O54QhgfbxqtsTnbi2fv5IyhTqWadteDLgiD2WWGa0GLQsgn/95/wQ2uSO6Ipyd8+3gIy yONtgUkeyuU0agcYfS9a490GKahkh5gyN3sxukKPK/8P3g+1Mv8JCeYZ6nllzL4r5zSd ZlYpEAf3LczA3UrkeqiAMkrXH5pV4v3WA1vPcgfNs4lXQEhbiGUcY81J/V77Q1UiZdxU aETIz401ia/ukZSNNrV2Az+AHY6eLkBug5J6eAqPi0/+IKcTH0PRikQofh1H9vxXAWJ0 IU1w== X-Forwarded-Encrypted: i=1; AJvYcCU/U20STQLRhEH24HbE2pdCe5bhHsO0jPFFDydLQyo+FGbQJVhHjbERnrAnO41ai/w5q8Pka29fVn1gjno=@vger.kernel.org X-Gm-Message-State: AOJu0YwLnLOXN/BdUYCL97lKbLTC+jx9WhsMjcpLzgjimGvqgmJ2wW29 GiZvnAP8ikhmIjH0iXl3KtmxKbbUQcZEhU2aNaJdiWBF+h2/sCPP7E+/k4pFXQ== X-Gm-Gg: ASbGncuRGXu9C6cYhz8/kR4S9sOzFoL+q2al92/g6ecUD/d5rLLFve5dsZ5TUpeCKAJ gGgWS+drAPy007xUUZ9aLovlcDc9MnoCi8dkLF48o7/fuvK1MokPiDVIJVCr8EuxxMd0i8BgwbF +ESS5ff684GEXsphQlYCn0Awk1dZkeLDLYKoMUNOb7R4mntRLEwrRtc6YWp3pSc+tQ2x31zBcrw IoJlOHtGhLxVloB0U570iat07Xp4hVpluhrkUJce//kqgHqZOXSEnBg3wdxbGv8wY4QsVYht8p0 81MVxMS0EBT3/aalKzJjZXr5PfwRGaA= X-Google-Smtp-Source: AGHT+IH1UnEjelCgHrf8XrW9PCaVmULOAto7W+p38OG4x2aB45dMf3YdxSc5kdK3NURqwyo4D6jMqA== X-Received: by 2002:a05:6512:3049:b0:542:2137:3a2c with SMTP id 2adb3069b0e04-542845469e1mr8691546e87.24.1736862805901; Tue, 14 Jan 2025 05:53:25 -0800 (PST) Received: from ?IPV6:2001:4643:2b9c:0:742e:f778:f9f1:b089? ([2001:4643:2b9c:0:742e:f778:f9f1:b089]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5428beaaa95sm1686191e87.174.2025.01.14.05.53.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 14 Jan 2025 05:53:25 -0800 (PST) Message-ID: <43beb3f3-071d-4f58-b356-6dc6b9de947a@remarkable.no> Date: Tue, 14 Jan 2025 14:53:24 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/2] Bluetooth: btnxpuart: Add support for set BD address To: Neeraj Sanjay Kale , marcel@holtmann.org, luiz.dentz@gmail.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, amitkumar.karwar@nxp.com, sherry.sun@nxp.com, ziniu.wang_1@nxp.com, kristian.krohn@remarkable.no, manjeet.gupta@nxp.com References: <20250114133548.2362038-1-neeraj.sanjaykale@nxp.com> <20250114133548.2362038-2-neeraj.sanjaykale@nxp.com> Content-Language: en-US From: Johan Korsnes In-Reply-To: <20250114133548.2362038-2-neeraj.sanjaykale@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 1/14/25 2:35 PM, Neeraj Sanjay Kale wrote: > This adds support for setting BD address during hci registration. NXP > FW does not allow vendor commands unless it receives a reset command > after FW download and initialization done. > As a workaround, the .set_bdaddr callback function will first send the > HCI reset command, followed by the actual vendor command to set BD > address. > Hi Neeraj, If NXP firmware does not allow vendor commands prior to this reset, would it not be better to perform this reset during probe/init? Kind regards, Johan