From: K Prateek Nayak <kprateek.nayak@amd.com>
To: "Aiden Hecker" <heckeraiden@gmail.com>,
"Huang Rui" <ray.huang@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Perry Yuan" <perry.yuan@amd.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Viresh Kumar" <viresh.kumar@linaro.org>,
"Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Vishal Badole" <Vishal.Badole@amd.com>
Cc: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>, <linux-pm@vger.kernel.org>,
<platform-driver-x86@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] platform/x86/amd/hfi: Rank SMT siblings below primary cores for ITMT packing
Date: Fri, 13 Nov 2026 12:48:49 +0530 [thread overview]
Message-ID: <43c99fe6-f1b7-4992-b4b7-82a96c9415e1@amd.com> (raw)
In-Reply-To: <20261113022934.13397-3-heckeraiden@gmail.com>
Hello Aiden,
On 11/13/2026 7:59 AM, Aiden Hecker wrote:
> Tested-by: Aiden Hecker <heckeraiden@gmail.com>
We assume you've tested the changes you are signing off on :-)
> Signed-off-by: Aiden Hecker <heckeraiden@gmail.com>
[..snip..]
> + /*
> + * Rank secondary SMT siblings slightly below primary threads so
> + * SD_ASYM_PACKING fills idle physical cores first while still keeping
> + * classic Zen 5 SMT siblings ordered ahead of dense Zen 5c cores.
> + */
> + prio = hfi_cpuinfo->ipcc_scores[0];
> + if (cpu_feature_enabled(X86_FEATURE_AMD_HTR_CORES)) {
> + sib_mask = topology_sibling_cpumask(cpu);
> + if (!cpumask_empty(sib_mask) && cpumask_first(sib_mask) != cpu)
> + prio = (prio * 7) / 8;
> + }
> +
> + sched_set_itmt_core_prio(prio, cpu);
If asym capacity is enabled, we should not use the IPCC information.
The scheduler is smart enough to go find an idle core if it exists
that fits the task capacity.
>
> return 0;
> }
--
Thanks and Regards,
Prateek
prev parent reply other threads:[~2026-11-13 7:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 2:29 [PATCH v2 0/2] cpufreq: amd-pstate, platform/x86/amd/hfi: Enable hybrid capacity scaling & SMT ITMT ordering on Zen 5 / Zen 5c Aiden Hecker
2026-11-13 2:29 ` [PATCH v2 1/2] cpufreq: amd-pstate: Enable hybrid CPU capacity scaling on heterogeneous Zen CPUs Aiden Hecker
2026-11-13 7:15 ` K Prateek Nayak
2026-11-14 16:25 ` Badole, Vishal
2026-11-13 2:29 ` [PATCH v2 2/2] platform/x86/amd/hfi: Rank SMT siblings below primary cores for ITMT packing Aiden Hecker
2026-11-13 7:18 ` K Prateek Nayak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43c99fe6-f1b7-4992-b4b7-82a96c9415e1@amd.com \
--to=kprateek.nayak@amd.com \
--cc=Vishal.Badole@amd.com \
--cc=hansg@kernel.org \
--cc=heckeraiden@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=mingo@redhat.com \
--cc=perry.yuan@amd.com \
--cc=peterz@infradead.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ray.huang@amd.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®