mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
To: Jeff Johnson <jeff.johnson@oss.qualcomm.com>,
	Jeff Johnson <jjohnson@kernel.org>,
	linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
	linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: Re: [PATCH] wifi: ath10k: Drop unused qmi_elem_info arrays
Date: Fri, 30 Oct 2026 07:43:00 +0100	[thread overview]
Message-ID: <43ce3985-b1ff-4661-a670-dc10fe32c99d@oss.qualcomm.com> (raw)
In-Reply-To: <65a1e88d-6b9e-4aa8-9ee9-7b0b7892b59e@oss.qualcomm.com>

On 29/10/2026 20:54, Jeff Johnson wrote:
> On 10/29/2026 4:11 AM, Krzysztof Kozlowski wrote:
>> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>>
>> 'wlfw_pin_connect_result_ind_msg_v01_ei' and
>> 'wlfw_initiate_cal_download_ind_msg_v01_ei' are not used anywhere.
>> Dropping them allows to remove bunch of other code referenced purely by
>> these ararys.
> 
> s/ararys/arrays/
> 
> this removes a lot of stuff, by review agent says there is more that can be
> removed...
> 
>   qmi_wlfw_v01.c
>   - static const … wlfw_mem_seg_s_v01_ei[] — line 188
>   - static const … wlfw_mem_seg_resp_s_v01_ei[] — line 229
> 
>   qmi_wlfw_v01.h (removable once the two .c arrays above are gone)
>   - struct wlfw_mem_seg_s_v01 — line 161
>   - struct wlfw_mem_seg_resp_s_v01 — line 168

I got LKP reports for these too.

> 
>   qmi_wlfw_v01.h — now-orphaned size constants (0 refs)
>   - #define QMI_WLFW_MAX_NUM_MEM_SEG_V01 — line 64
>   - #define QMI_WLFW_FUNCTION_NAME_LEN_V01 — line 67
>   - #define QMI_WLFW_MAX_ATHDIAG_DATA_SIZE_V01 — line 70
>   - #define QMI_WLFW_MAC_ADDR_SIZE_V01 — line 76


Ack

Best regards,
Krzysztof

  reply	other threads:[~2026-10-30  6:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 11:11 Krzysztof Kozlowski
2026-10-29 19:54 ` Jeff Johnson
2026-10-30  6:43   ` Krzysztof Kozlowski [this message]
2026-10-30  6:47 ` kernel test robot
2026-10-30  7:19 Krzysztof Kozlowski
2026-10-30  7:34 ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43ce3985-b1ff-4661-a670-dc10fe32c99d@oss.qualcomm.com \
    --to=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=jeff.johnson@oss.qualcomm.com \
    --cc=jjohnson@kernel.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®