From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03246C46470 for ; Tue, 7 Aug 2018 11:49:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B4A282178F for ; Tue, 7 Aug 2018 11:49:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4A282178F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388787AbeHGODm (ORCPT ); Tue, 7 Aug 2018 10:03:42 -0400 Received: from mga14.intel.com ([192.55.52.115]:28753 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727048AbeHGODm (ORCPT ); Tue, 7 Aug 2018 10:03:42 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 07 Aug 2018 04:49:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.51,455,1526367600"; d="scan'208";a="81354782" Received: from smile.fi.intel.com (HELO smile) ([10.237.72.86]) by orsmga002.jf.intel.com with ESMTP; 07 Aug 2018 04:49:31 -0700 Message-ID: <43d45add4c8059d44a0b228e4beffb03c094a512.camel@linux.intel.com> Subject: Re: [PATCH v3 2/4] ACPI / scan: Create platform device for fwnodes with multiple i2c devices From: Andy Shevchenko To: Hans de Goede , "Rafael J . Wysocki" , Len Brown , Mika Westerberg , Darren Hart , Wolfram Sang Cc: Srinivas Pandruvada , linux-acpi@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, Heikki Krogerus , John Garry , linux-i2c@vger.kernel.org Date: Tue, 07 Aug 2018 14:49:30 +0300 In-Reply-To: <13770931-2322-96a3-1667-83c96b25bcfb@redhat.com> References: <20180807080539.17811-1-hdegoede@redhat.com> <20180807080539.17811-3-hdegoede@redhat.com> <00e16cb09c171b536449b61124473291f2b30d0b.camel@linux.intel.com> <13770931-2322-96a3-1667-83c96b25bcfb@redhat.com> Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.1-2 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2018-08-07 at 13:29 +0200, Hans de Goede wrote: > Hi, > > On 07-08-18 13:19, Andy Shevchenko wrote: > > On Tue, 2018-08-07 at 10:05 +0200, Hans de Goede wrote: > > > + /* > > > + * These devices have multiple I2cSerialBus resources and an > > > i2c-client > > > + * must be instantiated for each, each with its own > > > i2c_device_id. > > > + * Normally we only instantiate an i2c-client for the first > > > resource, > > > + * using the ACPI HID as id. These special cases are handled by > > > the > > > + * drivers/platform/x86/i2c-multi-instantiate.c driver, which > > > knows > > > + * which i2c_device_id to use for each resource. > > > + */ > > > + static const struct acpi_device_id i2c_multi_instantiate_ids[] = > > > { > > > + {"BSG1160", 0}, > > > + {"", 0}, > > > + }; > > > > Style nits: > > - can we move it outside of function? > > Sure, but there are 2 existing users of an array of acpi_device_id-s > combined with an acpi_match_device_ids() call and both have the array > inside the function, so for consistency it seems better to keep it > where it is. Hmm... OK. > > - is this existing style in the file and / or files in this folder > > for > > IDs? (I mean unnecessary 0:s and empty string? > > It seems that all variants one can come up with are already used > inside > this single file. Ah, that's sad. > I agree that less is more, so I will change this to: > > static const struct acpi_device_id > i2c_multi_instantiate_ids[] = { > {"BSG1160", }, > {} > }; In case if it mimics already existing style, looks quite good to me (otherwise perhaps comma inside {} can also be removed). > > For v4. Does it make sense to test v3 on your opinion? Or better to wait for v4? -- Andy Shevchenko Intel Finland Oy