From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9EB6B167D80 for ; Thu, 24 Oct 2024 10:52:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729767160; cv=none; b=aVfmkfSrtiFnAVz+PJZaxs0O1X5RrgNq2shqNCQzpE6T6HhbgWY2kFsB9cfXQpaGynLy5sxuXg5QLKDgQ2oPLNOUJHfJFhgI/i4lOxL0sz7c5hDZ2Qs53Gz7fF1XgSaWo+I5+ZuQXLaTtcMeiPM1RjHog/NjYF19yGhuu14uWTk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729767160; c=relaxed/simple; bh=4ekxkQmmhvir+5TyqyoCfKPaWhWRbylq+LC4f4N042s=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=rKxl9vQ9CmNGCIjIgmJ4Q/tImF7/nZ2xp6A6Slr8mri8yPvUer0RpyZRG+bG1NG/GBbm5kcTs207ipuKDKwp/elj5a5JDZ2UB18Bwp6KabUQP55paMf31rbXmj9UbP3PI4J19Ytnn9UA+7IT1WNQD7VEC4nNq5wbP0NgaXt4Gqc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=oENLzDxV; arc=none smtp.client-ip=209.85.208.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oENLzDxV" Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2fb518014b9so5706891fa.3 for ; Thu, 24 Oct 2024 03:52:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1729767157; x=1730371957; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HOyAXE0GUW7cmndQ8mO+yG/0idrUbxgKGObOYyEO0PY=; b=oENLzDxVnsPkZqjdU6t81Ht/73nwSyVfScyb1kO/nY6gcbXDxW0Fw8fc1HHkP3/6Og VMuSUvKuIm3tQ1D9bffii+h6RCdsXIeB/nq3g3k3h05B+3UWW++8T/Z1M2fQIes6oeY+ UsIa2VlfCHpz3Plrxq5quKtaLz2HClwl66g47pafWIW5QVu/FI9Uj6a524DwxS+sVgde S24Obk4qmvwCCpFEIojOvrMQrH6euPOv2Irqhrldo+GSZTY7RXGil46kTSotCeqw63Sw 2aAMkLUSgpTh1aVQiWCqvhUVKwo7WtyYtwD+/LVTCJ/vAb1yFBdodZi3S88ZNPwa61n4 mD7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729767157; x=1730371957; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HOyAXE0GUW7cmndQ8mO+yG/0idrUbxgKGObOYyEO0PY=; b=lFpgnWJ2Umh5Z7WwgLy9tBlORIqn0JAXluufQQbGQXNcbzLu/kgcjUh6SQeRIK5fQ4 DlbmICMC/Nk4IeFCEy5h87hdInlsED0JQTQe8HrnkDURPh5dVHDxIOkLyIJx06EV8+fT rL4Dbk+mhEBHmt0TpceOmVrndmA4kbSe309TvcW7lFaAArxwIwqD5bEFBYfkei76mSPx x0hfx9sWF7A7N6pIB71dDSIOcrmthEk+b9DskTP3082tvibvLRzwmd19SNvyMdE/2ody bwCu0WwgL923h6+IHBll5WKCv2TGaYh1dilCK0DR1iRiqZPObgI/nBFfMUq4IPU9h+/Y Z68A== X-Forwarded-Encrypted: i=1; AJvYcCVFCr2gOwx9if/1+f2usqxEBRN1xCpwGnBksjxqxomTLf5bqojpuUbZwQgC11/8XMXrgoFtQ0WZbjBNJ4c=@vger.kernel.org X-Gm-Message-State: AOJu0YxF5ZwhS4+2GIQa0fdv1JsskDAJPFifIVv7suY6KQrKpTpNUbVN pYOujc7W87ttfjbrECMbqQnn0wRPQYtPwNYUe6+RnK4G1BlWTX1TYIiF/rYtjO+cvgro9SjM5eW 4wFU= X-Google-Smtp-Source: AGHT+IENzz8Bqoyagoc4Wih98itZjoGtQwFFRLvNgNZBkineUHMgpQUAnSo8qRW6/WuGNnl0WyLEdg== X-Received: by 2002:a2e:4e01:0:b0:2fb:6169:c42d with SMTP id 38308e7fff4ca-2fca8279527mr7472501fa.41.1729767156541; Thu, 24 Oct 2024 03:52:36 -0700 (PDT) Received: from [192.168.0.40] ([176.61.106.227]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cb66a654b9sm5603174a12.34.2024.10.24.03.52.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 24 Oct 2024 03:52:36 -0700 (PDT) Message-ID: <43dbbe57-9045-4f85-84ba-1bd5a9951fdf@linaro.org> Date: Thu, 24 Oct 2024 11:52:35 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCHv2 2/2] media: venus: sync with threaded IRQ during inst destruction To: Sergey Senozhatsky Cc: Stanimir Varbanov , Vikash Garodia , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org References: <20241024061809.400260-1-senozhatsky@chromium.org> <20241024061809.400260-3-senozhatsky@chromium.org> <4b96f1f8-e084-4599-abe9-05039bfac569@linaro.org> <20241024093916.GM1279924@google.com> <20241024100857.GN1279924@google.com> Content-Language: en-US From: Bryan O'Donoghue In-Reply-To: <20241024100857.GN1279924@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 24/10/2024 11:08, Sergey Senozhatsky wrote: > On (24/10/24 10:43), Bryan O'Donoghue wrote: >>>> It also occurs to me that most of the close() operation code is shared >>>> between venc_close() and vdec_close() a welcome patch for V3 would be to >>>> functionally decompose the common code to a shared location. >>> >>> Any preferences where that "shared location" should be? >> >> Probably core.c is the only place we can jam stuff to be shared > > Ack. > > So, we need to > - export a couple of symbols > - include vdec header in core > > Does something like this look OK to you? y lgtm --- bod