From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: "Bob Copeland" <me@bobcopeland.com>
Cc: linville@tuxdriver.com, mickflemm@gmail.com, jirislaby@gmail.com,
linux-wireless@vger.kernel.org, ath5k-devel@venema.h4ckr.net,
linux-kernel@vger.kernel.org, michael+ath5k@stapelberg.de
Subject: Re: [ath5k-devel] [PATCH] ath5k: fix detection of jumbo frames
Date: Sun, 2 Nov 2008 13:00:27 -0800 [thread overview]
Message-ID: <43e72e890811021300o6bef49b0i515d0f72974cef00@mail.gmail.com> (raw)
In-Reply-To: <1225652938-6244-1-git-send-email-me@bobcopeland.com>
On Sun, Nov 2, 2008 at 11:08 AM, Bob Copeland <me@bobcopeland.com> wrote:
Nice find.
> Then, because the hw rate value of such frames is zero
BTW I believe frames should not go out at hw rate value 0, I did some
test a while back on this rate and its not exactly reliable, you will
get very funky behavior on it. Are you seeing that rate being used on
legacy-hal? Last I asked about it too its not something people know
about as being desired effect. I could be wrong but it'd be
interesting to see where this is used correctly.
>, and, since
> 63266a653589e1a237527479f10212ea77ce7844 "ath5k: rates cleanup", we do not fall back to the basic rate, such packets would trigger
> the following WARN_ON:
So its slow because using rate 0 takes a while? If indeed you don't
see a valid use for this rate I'd say to completely disallow it and
use BUG_ON() on it.
Luis
next prev parent reply other threads:[~2008-11-02 21:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-02 19:08 Bob Copeland
2008-11-02 21:00 ` Luis R. Rodriguez [this message]
2008-11-02 21:52 ` [ath5k-devel] " Bob Copeland
2008-11-02 22:33 ` Luis R. Rodriguez
2008-11-03 2:44 ` Bob Copeland
2008-11-03 13:35 ` Pavel Roskin
2008-11-03 14:26 ` [ath5k-devel] " Bob Copeland
2008-11-03 14:40 ` Pavel Roskin
2008-11-04 3:14 ` [PATCH] ath5k: correct handling of rx status fields Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e890811021300o6bef49b0i515d0f72974cef00@mail.gmail.com \
--to=lrodriguez@atheros.com \
--cc=ath5k-devel@venema.h4ckr.net \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=me@bobcopeland.com \
--cc=michael+ath5k@stapelberg.de \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®