mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: David Woodhouse <dwmw2@infradead.org>,
	Johannes Berg <johannes@sipsolutions.net>,
	linux-kernel@vger.kernel.org,
	linux-wireless <linux-wireless@vger.kernel.org>,
	Vipin Mehta <Vipin.Mehta@atheros.com>
Subject: Re: Firmware versioning best practices II
Date: Mon, 22 Feb 2010 11:14:15 -0800	[thread overview]
Message-ID: <43e72e891002221114w24304ab0x5aea7dfc81b4d9d6@mail.gmail.com> (raw)
In-Reply-To: <1266747222.18491.5.camel@violet>

On Sun, Feb 21, 2010 at 2:13 AM, Marcel Holtmann <marcel@holtmann.org> wrote:
> Hi David,
>
>> > > > That doesn't make much sense anyway. If the firmware filename is
>> > > > foo-$APIVER-$CODEVER every code change would need a corresponding
>> > > driver
>> > > > change. If it is just foo-$APIVER then the $CODEVER can be embedded
>> > > in
>> > > > the firmware file and printed so you know which code you're using,
>> > > but
>> > > > if it doesn't influence the API I don't see why it should be part of
>> > > the
>> > > > filename?
>> > >
>> > > The idea is that just like with shared libraries, you have a symlink
>> > > from the 'soname' foo-3.fw to the actual file foo-3-1.4.1.fw.
>> >
>> > Ah ok. I indeed do that manually with iwlwifi firmware :)
>> >
>> > > For shared libraries, it's easy to create those symlinks automatically
>> > > using ldconfig. For firmware that doesn't really work though -- since
>> > > the soname isn't encoded in the file like it is in ELF libraries.
>> >
>> > Right. Though I guess we could come up with a unified firmware wrapper
>> > format that the firmware loader can unwrap.
>>
>> I suppose we could, but this seems like overkill to me.
>
> I have to agree. This looks like total overkill to me.
>
> Just use the $APIVER in the firmware filename.

OK -- so what goes into linux-firmware is just the latest

foo-$(API)

> And if someone wants to
> keep track of more details then they can manually symlink them.

Well do we want the older foo-$(API)-$(VAR) files in linux-firmware
too for those companies/developers wishing to do this?

What about deprecating APIs of the firmware based on kernel releases.
I see it reasonable to deprecate a firmware API completely for a
future kernel release provided you maintain all features and
functionality in par. Does that sound reasonable?

> Unless we have full control over the source code of every firmware used
> in the kernel, why bother. It is up to the companies providing them
> anyway to make sure everything works as expected and the community can't
> fix it.

Well that's exactly it -- we do have access to the code for ar9170 for
example, so these details will become more relevant in the future.

 Luis

  reply	other threads:[~2010-02-22 19:14 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-20  2:23 Luis R. Rodriguez
2010-02-20 10:35 ` David Woodhouse
2010-02-20 11:00   ` Johannes Berg
2010-02-20 11:09     ` David Woodhouse
2010-02-20 11:10       ` Johannes Berg
2010-02-20 11:32         ` David Woodhouse
2010-02-21 10:13           ` Marcel Holtmann
2010-02-22 19:14             ` Luis R. Rodriguez [this message]
2010-02-22 19:27               ` Marcel Holtmann
2010-02-22 21:03                 ` Luis R. Rodriguez
2010-02-23  7:06                   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43e72e891002221114w24304ab0x5aea7dfc81b4d9d6@mail.gmail.com \
    --to=mcgrof@gmail.com \
    --cc=Vipin.Mehta@atheros.com \
    --cc=dwmw2@infradead.org \
    --cc=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®