From: Dietmar Eggemann <dietmar.eggemann@arm.com>
To: Ingo Molnar <mingo@kernel.org>
Cc: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Patrick Bellasi <patrick.bellasi@arm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Arnaldo Carvalho de Melo <acme@infradead.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Jiri Olsa <jolsa@redhat.com>
Subject: Re: [PATCH v3] sched/core: Fix uclamp ABI bug, clean up and robustify sched_read_attr() ABI logic and code
Date: Wed, 4 Sep 2019 12:55:33 +0200 [thread overview]
Message-ID: <43e9f6ae-7ebc-d3d8-eecf-860cdef7fdec@arm.com> (raw)
In-Reply-To: <20190904103925.GA60962@gmail.com>
On 04/09/2019 12:39, Ingo Molnar wrote:
>
> * Dietmar Eggemann <dietmar.eggemann@arm.com> wrote:
>
>>> -v3 attached. Build and minimally boot tested.
>>>
>>> Thanks,
>>>
>>> Ingo
>>>
>>
>> This patch fixes the issue (almost).
>>
>> LTP's sched_getattr01 passes again. But IMHO the prio 'chrt -p $$'
>> should be 0 instead of -65536.
>
> Yeah, I forgot to zero-initialize the structure ...
>
> Does the attached -v4 work any better for you?
Yeah, looks better now.
# chrt -p $$
[ 258.245786] sched_attr_copy_to_user(): copied 48 bytes. (ksize: 56,
usize: 48)
pid 1635's current scheduling policy: SCHED_OTHER
pid 1635's current scheduling priority: 0
w/o the extra printk:
Tested-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
next prev parent reply other threads:[~2019-09-04 10:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-03 17:16 [PATCH 1/2] sched: sched_getattr should return E2BIG, not EFBIG Thadeu Lima de Souza Cascardo
2019-09-03 17:16 ` [PATCH 2/2] sched: allow sched_getattr with old size Thadeu Lima de Souza Cascardo
2019-09-04 7:55 ` [PATCH] sched/core: Fix uclamp ABI bug, clean up and robustify sched_read_attr() ABI logic and code Ingo Molnar
2019-09-04 8:49 ` [PATCH v2] " Ingo Molnar
2019-09-04 8:55 ` [PATCH v3] " Ingo Molnar
2019-09-04 9:31 ` Dietmar Eggemann
2019-09-04 10:39 ` Ingo Molnar
2019-09-04 10:55 ` Dietmar Eggemann [this message]
2019-09-04 13:19 ` Thadeu Lima de Souza Cascardo
2019-09-04 17:53 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e9f6ae-7ebc-d3d8-eecf-860cdef7fdec@arm.com \
--to=dietmar.eggemann@arm.com \
--cc=acme@infradead.org \
--cc=cascardo@canonical.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=patrick.bellasi@arm.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome