mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Dan Carpenter <dan.carpenter@linaro.org>,
	"Everest K.C." <everestkc@everestkc.com.np>
Cc: marcel@holtmann.org, luiz.dentz@gmail.com,
	kernel-janitors@vger.kernel.org, linux-bluetooth@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH V2][next] Bluetooth: btintel_pcie: Remove structually deadcode
Date: Tue, 15 Oct 2024 10:01:22 -0600	[thread overview]
Message-ID: <43eff9c9-9a23-46ac-9015-dbee35562848@linuxfoundation.org> (raw)
In-Reply-To: <8a4a8915-d59a-407d-9f93-f047370cca62@stanley.mountain>

On 10/15/24 03:48, Dan Carpenter wrote:
> The subject has a typo.  s/structually/structurally/
> 
>> The intel bluetooth module was successfully built after the change
>> without any errors.
>>
> 
> Delete this sentence.  It should just be assumed that changes don't break the
> build.  You can put that code isn't tested under the --- cut off line, if you
> want to put a warning message.  But we don't need this in the permanent git log.
> 
> 
>> This issue was reported by Coverity Scan.
>> https://scan7.scan.coverity.com/#/project-view/51525/11354?selectedIssue=1600709

Restating what I said in your other coverity patch, include
the coverity warning. This link requires login and no use
for people who don't have coverity account.

In the future don't include link that require login in the
commit logs.

>>
>> Fixes: 5ea625845b0f ("Bluetooth: btintel_pcie: Add handshake between driver and firmware")
>> Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
>> ---
>    ^^^
> Cut off line.
> 
> regards,
> dan carpenter
> 

thanks,
-- Shuah

  reply	other threads:[~2024-10-15 16:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-15  4:58 Everest K.C.
2024-10-15  9:48 ` Dan Carpenter
2024-10-15 16:01   ` Shuah Khan [this message]
2024-10-15 16:08     ` Everest K.C.
2024-10-15 16:10       ` Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43eff9c9-9a23-46ac-9015-dbee35562848@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=dan.carpenter@linaro.org \
    --cc=everestkc@everestkc.com.np \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    --cc=marcel@holtmann.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®