From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00364e01.pphosted.com (mx0a-00364e01.pphosted.com [148.163.135.74]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 269A4494823 for ; Thu, 6 Aug 2026 19:51:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=148.163.135.74 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786045915; cv=none; b=XHpuZqfm/vz9AaFIWrXVlnY94HFVhEsj7HWwryY/aGnQa5NU+wskWBRMWaX5V6JIltnfPpjC6r3jPNqV8hMHDqSDkw5fHkSmb5SzkLUm4Qc9VMN0fcECooqzAJWF5CrkDMJKjiby3wLLSZRaBs4ephQxjl+l14G7NMHanQpOEz8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1786045915; c=relaxed/simple; bh=lTTpjODhYHba5wOLeu29fKL9Vo+uC5X6ugh4lCvBx3s=; h=Message-ID:Date:MIME-Version:Subject:From:To:Cc:References: In-Reply-To:Content-Type; b=KNP7i/lyWINUBEIDSkpuS29DWEVYN9t9bPSuq7cwF2NyXDyihe5fnIepTyPTqEcEqs33eV8IgJCi3SsHm2+aGE0HuHoHwML9lVvSBwKAEdf6epuUxdXjxdKD8VQd0u54VjHUDEXWghqtyUo7hkcTMHSIOwD4zgu83rQ+kdlTl2I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu; spf=pass smtp.mailfrom=columbia.edu; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b=YxHt4sU1; arc=none smtp.client-ip=148.163.135.74 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=columbia.edu Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=columbia.edu Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=columbia.edu header.i=@columbia.edu header.b="YxHt4sU1" Received: from pps.filterd (m0167068.ppops.net [127.0.0.1]) by mx0a-00364e01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 676IYRA2352999 for ; Thu, 6 Aug 2026 15:51:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=columbia.edu; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pps01; bh=Zkma NtQ8BSIkFCQ/5kE6NoXn5l5qzjWnoHIHZn2DAkI=; b=YxHt4sU1bLe939IWOhZb iVMmeBgmLwWs7T31I0opvtRBd0Nipn73SR99bDHGSlepuLOnV0Qgyt4RI5h5RRrV NA6iRkzhwa0faVOYd94hoCW+jnQtUot0zZqwgoU5fmQeZjZyXNDK0VMBcBUOCTH7 fwoUbvzoe1Ai/S1oI4Xj246I/6m3WDt95ZjM7EdrFgnsKcV8n5D1snn8JJOCmaHK 4fYcWO1QlqRfRcd0F4Pk+5P6bqZHXNEr4IiwDayCqCMUMoDyb0jppMuqUuny+xVb rXFOEkWflxcTfPBs60DV1RZFaeUdravsdMUMrVZE6Vg+8fGhl8wrqP+iFWRkszAA yA== Received: from mail-qt1-f197.google.com (mail-qt1-f197.google.com [209.85.160.197]) by mx0a-00364e01.pphosted.com (PPS) with ESMTPS id 4fvvqrtcf2-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 06 Aug 2026 15:51:41 -0400 (EDT) Received: by mail-qt1-f197.google.com with SMTP id d75a77b69052e-51c21c01cf3so42308621cf.2 for ; Thu, 06 Aug 2026 12:51:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1786045900; x=1786650700; h=content-transfer-encoding:content-type:in-reply-to:content-language :references:cc:to:from:subject:user-agent:mime-version:date :message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=ZkmaNtQ8BSIkFCQ/5kE6NoXn5l5qzjWnoHIHZn2DAkI=; b=MUXSJi4JgXaOefa+MpUdcC8TVsUFCRpfvcSEfD/oPms3BE3btPCM2+kJpbvAKpbnf0 FFVk1OVQCnFbiX1vT41OGArVypZVbUuK3bKW1TkllCQDkQIqKBfHIAp9bLjIp4JMB0ul iHc9S8U1TkCLShJRmQlL+Q3NcNqtS6T1c5Di8h/MR5EDJzbB2RGAGxwulVMKjeiJ/3pa vFrAnKfgZ8xqq9xx90YzdyL4/n1RgyYxmYrLAElvFC22tmsoOWKfE2s5eLWk0HUITVpd 1VuItgGIlg83EhyMhki0WIOILrky/oup+9knb7k80Ou71K2m33ANm3oBxVDXDh1uioSZ 0ZXQ== X-Forwarded-Encrypted: i=1; AHgh+RrNvmzH+LG/CJkTawyIdp0adQvp5Zx7/rQ7tB60r8M2yPhuAZ9BgVdNdJqzgEe1cd9BwuQ7YXPfbiR4QOA=@vger.kernel.org X-Gm-Message-State: AOJu0YxCm0J1ECMnSQkzweJqmIFEd3fivfuJZgigac3ETbyrOLBs174f c31oP4H9LebYKDwfxHAEd4/LG9DEvqsQEXEX81gb3hDU6Sbdepw/nFnrjtDR2XsoyYAPt9RcTRV W8g75eNs6kXFPM4K3BnVExn4o+3Uc/oFFrNUVSnjIVhO06X2ld3cWXT9ZEqFpsw== X-Gm-Gg: AR+sD12t+FQwanQ+kL9TR+FyLnNXYVyjM+ZV9HmstXybCthvM9+kLHgaxPAXnTvSVIt zuN+Q8V3mBX/eQ/MQADBL9BuiLPCVqO1jVhDEGYPOD7OdjCAMNOOZ8KgUqNFOMAKHxDHv0ngsYZ HIgNcbPN9hqU54QHisv3+zclHqBwlZ05cJ2FMvQEE7WCtwhEMDr5F5Gz3G9Eo7QVlg5GKCGY4Ox vLj0aXIbFinp9VBW2lXrpiCHPwpCJ06HCYfVG2t7RU9tbbEoDq+D+DeapWWAcArbeqMfm1SKYFG Bk1lAF7IOzQ8KPimS9Buu5DRGDmwP4JXmPqMXqUvyTxe31nnDrKhvDcVMY4LTGrsm0YTktcwfpQ z0P8az/CURL4IpnYSB3FWDj1fgicqiaP7L4rPkth2oNOamHxpwrpeSxUpMTsOCrNm X-Received: by 2002:a05:622a:261a:b0:516:d83c:edb6 with SMTP id d75a77b69052e-52d0b06e247mr51577061cf.12.1786045900654; Thu, 06 Aug 2026 12:51:40 -0700 (PDT) X-Received: by 2002:a05:622a:261a:b0:516:d83c:edb6 with SMTP id d75a77b69052e-52d0b06e247mr51576641cf.12.1786045900174; Thu, 06 Aug 2026 12:51:40 -0700 (PDT) Received: from ?IPV6:2a00:a040:199:782e:b593:3821:1a47:8a5e? ([2a00:a040:199:782e:b593:3821:1a47:8a5e]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-47ff79b529fsm9689344f8f.12.2026.08.06.12.51.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Aug 2026 12:51:39 -0700 (PDT) Message-ID: <43fbe30d-54da-4bcd-ad2e-5391b327b642@columbia.edu> Date: Thu, 6 Aug 2026 22:51:36 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 05/10] ceph: convert ceph_submit_write() to folios From: Tal Zussman To: Ilya Dryomov , Alex Markuze , Viacheslav Dubeyko , "Matthew Wilcox (Oracle)" , Jan Kara , Andrew Morton , David Hildenbrand , Lorenzo Stoakes , "Liam R. Howlett" , Vlastimil Babka , Mike Rapoport , Suren Baghdasaryan , Michal Hocko , Zi Yan Cc: ceph-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org References: <20260804-remove-wait-on-page-writeback-v2-0-81f0ab065284@columbia.edu> <20260804-remove-wait-on-page-writeback-v2-5-81f0ab065284@columbia.edu> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=Mv9iLWae c=1 sm=1 tr=0 ts=6a74e5cd cx=c_pps a=EVbN6Ke/fEF3bsl7X48z0g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=x7bEGLp0ZPQA:10 a=VkNPw1HP01LnGYTKEx00:22 a=Da8U98TiO7q1upZEImrf:22 a=usPcmh10W0ubT8QP8_c3:22 a=b_efBAy1TN-SQDnTdmkA:9 a=QEXdDO2ut3YA:10 a=a_PwQJl-kcHnX1M80qC6:22 X-Proofpoint-GUID: gERwoMbgUusFrbu-q1_tJtsZ-V4Yr8k_ X-Proofpoint-Spam-Info: AW1haW4tMjYwODA2MDE1NSBTYWx0ZWRfXwjgBJLoHkAT7 wkjeqEpzRl+z4O71kotF2CeHUlI0JcBLOqJKEpAsCiXQkavioVdb2F4PWFGJjFeEKIlzEr4OFUD clYCFqu2/hsjkWwPxN63qzFCA/Iw2u2/JYxxSk06NbV4kKJSaBo7 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA2MDE1NSBTYWx0ZWRfXx7l4dFuNs9+H rSDCTQBTzgnXsbWY31fWL7CHae4cwoWysniP4kTmCDeoMGb2V+XvbpyTktT+vyHBOaqbor8d66f AAdiDcUyJjUE2oZ3bhp/nq00TFFtAMIg0LVZ9M8UH2yFgirmdwM4i0/RXMjq33XdDgqlT428h9j ip8h+YFQ2DZr722cWGIhXm0jJdDJLnn6CwCBtcM5dVudIJUGlJ/lblCtC8rBsO8+T9aChezzQk5 9PpKyCjTtEh7yoQmv/jeSik3rsezT6jWU9pLVxHCRZ8oEncKymXY/lGYWxNcfaMcBwPSaOcOmxo 6i8wM1ayQT35Xx0Yh/zfBZ2QHn99hz7d2eloyHPnTvTMz3dEbFIePEhLLlrEmTHvZWLlCefublR fwxsVFG//bCeUlwuxYo4fUlXu17HRWDTOK45WD04GbArXduOk1sVww5QgKYLYSg+6RYdThrV1jq jO7upMBV/DkAfaAbgww== X-Proofpoint-ORIG-GUID: gERwoMbgUusFrbu-q1_tJtsZ-V4Yr8k_ X-Proofpoint-Virus-Version: vendor=nai engine=6900 definitions=11867 signatures=596817 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 priorityscore=1501 bulkscore=10 lowpriorityscore=10 malwarescore=0 phishscore=0 spamscore=0 impostorscore=10 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608060155 On 8/6/26 2:58 PM, Tal Zussman wrote: > On 8/4/26 2:52 PM, Tal Zussman wrote: >> @@ -1436,14 +1445,14 @@ int ceph_submit_write(struct address_space *mapping, >> struct ceph_client *cl = fsc->client; >> struct ceph_vino vino = ceph_vino(inode); >> struct ceph_osd_request *req = NULL; >> - struct page *page = NULL; >> + struct folio *folio = NULL; >> bool caching = ceph_is_cache_enabled(inode); >> u64 offset; >> u64 len; >> unsigned i; >> >> new_request: >> - offset = ceph_fscrypt_page_offset(ceph_wbc->pages[0]); >> + offset = ceph_fscrypt_folio_offset(page_folio(ceph_wbc->pages[0])); >> len = ceph_wbc->wsize; >> >> req = ceph_osdc_new_request(&fsc->client->osdc, >> @@ -1467,29 +1476,28 @@ int ceph_submit_write(struct address_space *mapping, >> BUG_ON(IS_ERR(req)); >> } >> >> - page = ceph_wbc->pages[ceph_wbc->locked_pages - 1]; >> - BUG_ON(len < ceph_fscrypt_page_offset(page) + thp_size(page) - offset); >> + folio = page_folio(ceph_wbc->pages[ceph_wbc->locked_pages - 1]); >> + BUG_ON(len < ceph_fscrypt_folio_offset(folio) + folio_size(folio) - offset); >> >> if (!ceph_inc_osd_stopping_blocker(fsc->mdsc)) { >> for (i = 0; i < folio_batch_count(&ceph_wbc->fbatch); i++) { >> - struct folio *folio = ceph_wbc->fbatch.folios[i]; >> + folio = ceph_wbc->fbatch.folios[i]; >> >> if (!folio) >> continue; > > This, ... > >> >> - page = &folio->page; >> - redirty_page_for_writepage(wbc, page); >> - unlock_page(page); >> + folio_redirty_for_writepage(wbc, folio); >> + folio_unlock(folio); >> } >> Actually, Sashiko points out a deeper issue with this loop: "Could this unconditional folio_unlock() crash the kernel? Looking at ceph_process_folio_batch(), folios that fail folio_trylock() or are already under writeback are left in the fbatch array without being locked by the current thread. Then ceph_shift_unused_folios_left() shifts these unprocessed, unlocked folios to the start of the batch. If ceph_submit_write() subsequently fails the ceph_inc_osd_stopping_blocker() check, it iterates over all remaining folios in ceph_wbc->fbatch and calls folio_unlock() on folios we don't hold the lock for." ...along with 5 other pre-existing issues. Seems like the folio_batch loop here should just be deleted? But that seems like it should be a separate patch with a Fixes tag... >> for (i = 0; i < ceph_wbc->locked_pages; i++) { >> - page = ceph_fscrypt_pagecache_page(ceph_wbc->pages[i]); >> + folio = ceph_fscrypt_pagecache_folio(page_folio(ceph_wbc->pages[i])); >> >> - if (!page) >> + if (!folio) >> continue; >> > > ... and this check are unnecessary. ceph_fscrypt_pagecache_page() can't > take or return NULL, and ceph_shift_unused_folios_left() compacts NULLs > out of ceph_wbc->fbatch. Will remove both in v3. > >> - redirty_page_for_writepage(wbc, page); >> - unlock_page(page); >> + folio_redirty_for_writepage(wbc, folio); >> + folio_unlock(folio); >> } >>