From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4E087364E8B for ; Thu, 19 Mar 2026 11:31:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773919876; cv=none; b=EhM80VBdrVZVg8e47LxD4u6Eavreov9db3oI4es9Ts5rpEaLY3uXy23F9W5CBX2IwuS/dOYwzdQwE76auOHQ80pcTn/lZ8e0CCOtA9l6lq2PlWyMiOEDbGqNCItnRchDmA5UYTIUbKDLdzWHSdQzrFfC+CYEmfeZztyXF8RFbTM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773919876; c=relaxed/simple; bh=6RmqrALrlNdyMFuS3WsguhkEzeFwcu2Mk++JT4DMms8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=BVIjlMAyquD14/sCkRf6elwLjvOj36MWN6Ob8kqdljvHDoEi/BKpst1iz7bCwfxSpRNIcH10g/g95hVr8APW1CttU3a79rxzoOyP/iGd4jq0a1TCgkun0jz8m30TUvIUR6PTG/8Mbp12tEy614LciqMNvEA120OdXcunhi19SJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=SOzpidnc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=WrH/+63Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="SOzpidnc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="WrH/+63Z" Received: from pps.filterd (m0279866.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 62J740Y8770533 for ; Thu, 19 Mar 2026 11:31:10 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 76/2vQui6iJk68wTK2OiKtt/O+mDim4lf/Wjqyl17RM=; b=SOzpidncdvHuVXdK wrKBNUaGDfEClTtyfV0EZhr9bNuxwmsMgZHmf+NCMBL30XjwX8xtbDzHkEsuhYza aMReyL97c1ZvN8jR7cRorB9YXnSWUdqBfHWStvSxMcLLcMIGblTeGOh50+QK7iM8 k2vatlB4jo9h8RUQrybqBNCJYrXBmyvdCvlBCtCPKLkrgPhuomF/lja3vZyImFyF Kabfd5vzRiOp1xfv1HEYVTDF4idj8vx6AtxfyNImsMjEI02Zl7tOylwHWHKOI/qE Ksr6eAEvvJfEC31pPIpvPSweLM7S96vYXohyrPqxN2BGVBlp30iEJKomf8pcNPKH TbaLlA== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d00egay5r-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 19 Mar 2026 11:31:10 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-50947db2e97so6612351cf.3 for ; Thu, 19 Mar 2026 04:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1773919869; x=1774524669; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=76/2vQui6iJk68wTK2OiKtt/O+mDim4lf/Wjqyl17RM=; b=WrH/+63Z2EV4gyWh9pvHwzpxLTKFGUKEqRqR9mxAvZqLOI+w4NwC+6U5nMl0pqgmP4 tXPPqQL3kY9LNvcWBMGkZ5H81sOziyVGz+5/WeakTpIf15qyDJ0qvAGANj0bmgQ3vLBA g+RVeLVGWj25sLzNNx1YZvrr3JR27jrp7i2DESzskO0vmPNtl3GoNlBLOdUDs/KsYTaj 3PL7FotBD2Uia9CDiFb3A9/tarUjGX5R8ILCPnussfdG2fn1fjdMzcZeJRpoEYdcWoiF 2bTotvsXpG2R3TWtf0MXG+w2yQqh21REhwGkijLrnPQsKnf5iKYYKMWJ75l9z81EXgBc uHLQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773919869; x=1774524669; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=76/2vQui6iJk68wTK2OiKtt/O+mDim4lf/Wjqyl17RM=; b=TmAvKUVEYMLijCYJ84kCDqhscxbKv/j1yj6+Mxr4NNRUvibHnFUb/KyoiELvNE74l4 Bg4GGHgJhuJJ78s/h/mb3q7SXdfTAOXRkKygSkwqLJ5vik1/8qrNIkaIfAI3Klxo6JrK ad65icQtAjA4P0ecKHVsHNMKIIovpYrJrq7uIbqYlxY8htZdpC/4kSukUAt6Rd1b33sG lmmfBz7coSuvmBM5cinJVhbDsuqxfWkdErJgjOH77yUNPvdNDoGtj8uihA6S475ng7ko uXfPTCN+qjvCF3y/m1qNjgCgwPiO0w/QxK4mtKv56vyRwK64rJk0uhiCVxZm/vtW5fEQ cL1g== X-Forwarded-Encrypted: i=1; AJvYcCWTY+ypL4PbBnJR+/tVdSusjiIs+S4USi1Ee/KxK5VBH36a2HPPG7nrPFlrIbxA5RHPhf2tFNB+M7vgjik=@vger.kernel.org X-Gm-Message-State: AOJu0YxuXXQBxOL8VGX917hwc2LBLhQsK3HP9+Bcbl/zrFkN7Zg7jKVJ ufJxuB/21NRaE3LSYENOiUonayBPh/TlnIFw5fkcwg8BtqEW28b6Bd0slTge+TKgkrqI4mWyPIo ZB2ZpmGvDfmE/2ToBW0D2qgNP5WH8v9/cBZPH6L3P754rXvTTmAnWZsi9qvvqnVucC6I= X-Gm-Gg: ATEYQzzZiUYid5QzZwo9l/TsSLH750tuOgCZ4HMRx5MCJTo274aytT0YQ+bJ8jECMt2 W92+iyk8/uqs2xQVmW/sM+nS3xHEYNgsFNucrQ88RcIFUmIDLanUxMzyvXgKMTKQjXADOq9bjfa 9gGJjUoDsq9hAYBOY1igVVIZ8JY9aNrbHbd3QcHynew5XDUZJVN8VvqAOk6yznTpzPnDB+zND1b 8P/90ABGBPJCAO34aCYsdHDRdwSu6nASxrkTil277np5h6UQmKj8yROIivQkc0qm34MHjk77A4C l/ybCyKzZB4lg3luJOHJGDBxl7ZVuQnN73YGo09GURG+CBeRShkURB3sDXhVFkwlHxEoFwpDqBR TDn8TnFxDHpaluhq59jKlWMMRpi6AnMu1ri19WHQRe3rz/HQMr6CY0rdstaqRjD55AY4JKkppX3 Ole0o= X-Received: by 2002:a05:622a:a87:b0:50b:2972:4bec with SMTP id d75a77b69052e-50b29724f8bmr12837431cf.3.1773919868996; Thu, 19 Mar 2026 04:31:08 -0700 (PDT) X-Received: by 2002:a05:622a:a87:b0:50b:2972:4bec with SMTP id d75a77b69052e-50b29724f8bmr12837151cf.3.1773919868433; Thu, 19 Mar 2026 04:31:08 -0700 (PDT) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b97f170e5d4sm428774566b.55.2026.03.19.04.31.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Mar 2026 04:31:07 -0700 (PDT) Message-ID: <43ff670b-08fc-434e-8a84-1b781c216fdd@oss.qualcomm.com> Date: Thu, 19 Mar 2026 12:31:05 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 4/6] arm64: dts: qcom: Add UFS node To: Marcus Glocker , Maxim Storetvedt Cc: Wesley Cheng , Daniel Gomez , Konrad Dybcio , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Marijn Suijten , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Abel Vesa , Johan Hovold References: Content-Language: en-US From: Konrad Dybcio In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=MMNtWcZl c=1 sm=1 tr=0 ts=69bbde7e cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=Yq5XynenixoA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=YMgV9FUhrdKAYTUUvYB2:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=KKAkSRfTAAAA:8 a=lM6lPP4PU3o6MF_I6DMA:9 a=pJSYWZii-99avefD:21 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: t5eSN31virAbrdUEstR5p-GNvl75QtjP X-Proofpoint-GUID: t5eSN31virAbrdUEstR5p-GNvl75QtjP X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMzE5MDA5MSBTYWx0ZWRfX3rZ1viUM9HxU Jsw8LJETfP6m69s/SNkr1PALr1hAbWrQqnzlbmBHbocTd2JIOB0qEaygQ7gxj2/QXwluFhMT4oi w9MuXgGtHaYx9Z6JaBjZrDv1+yfamMnQtjGRMehwGGSUtZPaxg6ETL1J+e+BkDs2vUcw9yIrpOg FvL72AYzKWtXyg1QiZV/W23boHbS4n+MccRHKNGhY7J0yFFxNjQGpzqfpBsnuLQpdZgPrU7x9Zv ceTlF1VP5XvdV21tMMgZ3Pp95j3OvOjhH1bVQjhm2+3emh4Kzmnitl7M7lEzCg//f4NjB4vl7MT dEoyI0WRrK8KpQmx0h+AivUHbnu2yjBcwU9altZ5T1WuHspQf/IGieGSh5QbC0oIxuATo5crUjI cSKyELISsJHioBRprHsN5F0FL2UCWG8BCCAxW9nzNn1Wnn4qnNLN/f3A+YKKZbhX0oNhk+m8Bcc V8Nw6gzWf3oMdvTtMfA== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-03-19_01,2026-03-19_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 impostorscore=0 lowpriorityscore=0 malwarescore=0 adultscore=0 phishscore=0 priorityscore=1501 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2603190091 On 3/8/26 9:35 PM, Marcus Glocker wrote: > On Sat, Mar 07, 2026 at 05:01:14PM +0100, Maxim Storetvedt wrote: > >> >> On 1/3/25 00:17, Marcus Glocker wrote: >>> On Thu, Jan 02, 2025 at 01:38:10PM GMT, Wesley Cheng wrote: >>> >>>> >>>> On 11/9/2024 3:31 PM, Daniel Gomez wrote: >>>>> On Fri Aug 30, 2024 at 7:25 PM CEST, Marcus Glocker wrote: >>>>>> On Fri, Aug 30, 2024 at 02:05:48AM +0200, Konrad Dybcio wrote: >>>>>> >>>>>>> On 17.08.2024 10:38 PM, Marcus Glocker wrote: >>>>>>>> Add the UFS Host Controller node. This was basically copied from the >>>>>>>> arch/arm64/boot/dts/qcom/sc7180.dtsi file. >>>>>>>> >>>>>>>> Signed-off-by: Marcus Glocker >>>>>>>> Acked-by: Krzysztof Kozlowski >>>>>>>> --- >>>>>>>> arch/arm64/boot/dts/qcom/x1e80100.dtsi | 72 ++++++++++++++++++++++++++ >>>>>>>> 1 file changed, 72 insertions(+) >>>>>>>> >>>>>>>> diff --git a/arch/arm64/boot/dts/qcom/x1e80100.dtsi >>>>>>>> b/arch/arm64/boot/dts/qcom/x1e80100.dtsi >>>>>>>> index 7bca5fcd7d52..9f01b3ff3737 100644 >>>>>>>> --- a/arch/arm64/boot/dts/qcom/x1e80100.dtsi >>>>>>>> +++ b/arch/arm64/boot/dts/qcom/x1e80100.dtsi >>>>>>>> @@ -2878,6 +2878,78 @@ mmss_noc: interconnect@1780000 { >>>>>>>> #interconnect-cells = <2>; >>>>>>>> }; >>>>>>>> >>>>>>>> + ufs_mem_hc: ufs@1d84000 { >>>>>>>> + compatible = "qcom,x1e80100-ufshc", "qcom,ufshc", >>>>>>>> + "jedec,ufs-2.0"; >>>>>>>> + reg = <0 0x01d84000 0 0x3000>; >>>>>>>> + interrupts = ; >>>>>>>> + phys = <&ufs_mem_phy>; >>>>>>>> + phy-names = "ufsphy"; >>>>>>>> + lanes-per-direction = <1>; >>>>>>>> + #reset-cells = <1>; >>>>>>>> + resets = <&gcc GCC_UFS_PHY_BCR>; >>>>>>>> + reset-names = "rst"; >>>>>>>> + >>>>>>>> + power-domains = <&gcc GCC_UFS_PHY_GDSC>; >>>>>>>> + >>>>>>>> + iommus = <&apps_smmu 0xa0 0x0>; >>>>>>> Looks like this should be 0x1a0 maybe >>>>>>>> + >>>>>>>> + clock-names = "core_clk", >>>>>>>> + "bus_aggr_clk", >>>>>>>> + "iface_clk", >>>>>>>> + "core_clk_unipro", >>>>>>>> + "ref_clk", >>>>>>>> + "tx_lane0_sync_clk", >>>>>>>> + "rx_lane0_sync_clk"; >>>>>>>> + clocks = <&gcc GCC_UFS_PHY_AXI_CLK>, >>>>>>>> + <&gcc GCC_AGGRE_UFS_PHY_AXI_CLK>, >>>>>>>> + <&gcc GCC_UFS_PHY_AHB_CLK>, >>>>>>>> + <&gcc GCC_UFS_PHY_UNIPRO_CORE_CLK>, >>>>>>>> + <&rpmhcc RPMH_CXO_CLK>, >>>>>>>> + <&gcc GCC_UFS_PHY_TX_SYMBOL_0_CLK>, >>>>>>>> + <&gcc GCC_UFS_PHY_RX_SYMBOL_0_CLK>; >>>>>>> You also want >>>>>>> >>>>>>> <&gcc GCC_UFS_PHY_RX_SYMBOL_1_CLK> >>>>>>> >>>>>>>> + freq-table-hz = <50000000 200000000>, >>>>>>> 25000000 300000000 >>>>>>> >>>>>>>> + <0 0>, >>>>>>>> + <0 0>, >>>>>>>> + <37500000 150000000>, >>>>>>> 75000000 300000000 >>>>>>> >>>>>>>> + <0 0>, >>>>>>>> + <0 0>, >>>>>>>> + <0 0>; >>>>>>>> + >>>>>>>> + interconnects = <&aggre1_noc MASTER_UFS_MEM QCOM_ICC_TAG_ALWAYS >>>>>>>> + &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>, >>>>>>>> + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ALWAYS >>>>>>>> + &config_noc SLAVE_UFS_MEM_CFG QCOM_ICC_TAG_ALWAYS>; >>>>>>>> + interconnect-names = "ufs-ddr", "cpu-ufs"; >>>>>>>> + >>>>>>>> + qcom,ice = <&ice>; >>>>>>>> + >>>>>>>> + status = "disabled"; >>>>>>>> + }; >>>>>>>> + >>>>>>>> + ufs_mem_phy: phy@1d87000 { >>>>>>>> + compatible = "qcom,x1e80100-qmp-ufs-phy"; >>>>>>>> + reg = <0 0x01d87000 0 0x1000>; >>>>>>> most definitely should be 0x01d80000 with a size of 0x2000 >>>>>>> >>>>>>>> + clocks = <&rpmhcc RPMH_CXO_CLK>, >>>>>>>> + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>, >>>>>>>> + <&tcsr TCSR_UFS_PHY_CLKREF_EN>; >>>>>>>> + clock-names = "ref", >>>>>>>> + "ref_aux", >>>>>>>> + "qref"; >>>>>>>> + power-domains = <&gcc GCC_UFS_PHY_GDSC>; >>>>>>>> + resets = <&ufs_mem_hc 0>; >>>>>>>> + reset-names = "ufsphy"; >>>>>>>> + #phy-cells = <0>; >>>>>>>> + status = "disabled"; >>>>>>>> + }; >>>>>>>> + >>>>>>>> + ice: crypto@1d90000 { >>>>>>>> + compatible = "qcom,x1e80100-inline-crypto-engine", >>>>>>>> + "qcom,inline-crypto-engine"; >>>>>>>> + reg = <0 0x01d90000 0 0x8000>; >>>>>>> 0x1d88000 >>>>>>> >>>>>>> >>>>>>> All this combined means you probably wrote your init sequence into some >>>>>>> free(?) register space and the one left over from the bootloader was >>>>>>> good enough :P >>>>>>> >>>>>>> Konrad >>>>>> I have not done anything special in our sub-system to boot this DTB. >>>>>> Changing the values as suggested by you also doesn't make any difference >>>>>> to me. >>>>>> >>>>>> Anyway, I think I'll give up at this point, since this process is >>>>>> getting too time consuming for me. We'll go ahead with out downstream >>>>>> patches, which works for us so far. >>>> >>>> >>>> Hi Marcus, >>>> >>>> >>>> Do you mind if I take over this series??? I started working on getting at least the UFS and USB portions of the DT file to work on my Samsung Galaxy book4 with your patches, along with some required modifications.?? If you're OK, I'll keep you as the author for the main DT file, and submit my changes on top. >>>> >>>> >>>> Thanks >>>> >>>> Wesley Cheng >>> >>> Hi Wesley, >>> >>> Perfectly fine for me. I'm glad if there is progress. >>> >>> Thanks and Regards, >>> Marcus >>> >> >> Hi Marcus, Wesley, >> >> We've continued to iterate on this device over at its thread on >> Launchpad, and been able to get a fairly usable system up and running on >> Linux for both the 14" and 16" SKUs. I'd be happy to update the series >> with the changes. >> >> Cheers, >> -Max > > Hi Max, > > Good to read! Sure, I would welcome to see your changes. If you also > could send me your full DTS to my e-mail address, I could also test it > with OpenBSD. JFYI https://lore.kernel.org/linux-arm-msm/20260211132926.3716716-4-pradeep.pragallapati@oss.qualcomm.com/ Konrad