From: Philipp Zabel <p.zabel@pengutronix.de>
To: Michal Wilczynski <m.wilczynski@samsung.com>,
robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
drew@pdp7.com, guoren@kernel.org, wefu@redhat.com,
m.szyprowski@samsung.com
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1 0/2] TH1520 SoC: Add Reset Controller Support
Date: Mon, 07 Apr 2025 12:27:24 +0200 [thread overview]
Message-ID: <4400a2a695099e4d806d12ddda41c2533bf844c8.camel@pengutronix.de> (raw)
In-Reply-To: <4205b786-fb65-468c-a3d8-bce807dd829a@samsung.com>
On Mi, 2025-03-05 at 09:23 +0100, Michal Wilczynski wrote:
>
> On 3/3/25 16:25, Michal Wilczynski wrote:
> > This patch series adds reset controller support for the T-Head TH1520 SoC,
> > which is used in boards like the LicheePi 4A. While part of a broader effort to
> > enable the Imagination BXM-4-64 GPU upstream, these patches focus on providing
> > a dedicated reset controller driver and the corresponding Device Tree
> > nodes/bindings.
> >
> > Bigger series cover letter:
> > https://lore.kernel.org/all/20250219140239.1378758-1-m.wilczynski@samsung.com/
>
>
> This series should be versioned as v6, to maintain continuity with the
> bigger patchset it is a subseries of. Please find below a changelog for
> the reset sub-series:
>
> v6:
> - split the reset part into sub-series, add the Reviewed-by from
> Philipp
FTR, I'll apply this as v6. I've checked differences to v5 semi-
manually - the changes are not listed in the changelog, but they are
what I suggested:
----------8<----------
$ b4 am -T 20250219140239.1378758-1-m.wilczynski@samsung.com
$ b4 am -T 20250303152511.494405-1-m.wilczynski@samsung.com
$ b4 diff -m v5_20250219_m_wilczynski_enable_drm_imagination_bxm_4_64_support_for_licheepi_4a.mbx \
20250303_m_wilczynski_th1520_soc_add_reset_controller_support.mbx
1: 0394b6a226519 < -: ------------- dt-bindings: clock: thead: Add TH1520 VO clock controller
2: bd073ef5d8100 < -: ------------- clk: thead: Add clock support for VO subsystem in T-Head TH1520 SoC
3: bbfd6b84574eb < -: ------------- dt-bindings: firmware: thead,th1520: Add support for firmware node
4: 9fa4a7c315420 < -: ------------- firmware: thead: Add AON firmware protocol driver
5: 5775fe10945af < -: ------------- dt-bindings: power: Add TH1520 SoC power domains
6: 501c3260c8060 < -: ------------- pmdomain: thead: Add power-domain driver for TH1520
7: 67191981e2bd2 < -: ------------- riscv: Enable PM_GENERIC_DOMAINS for T-Head SoCs
8: e866e1039b1f1 < -: ------------- clk: thead: Add support for custom ops in CCU_GATE_CLK_OPS macro
9: 73b7c8a74dfc6 < -: ------------- dt-bindings: clock: thead: Add GPU clkgen reset property
10: 116940381d1a3 < -: ------------- clk: thead: Add GPU clock gate control with CLKGEN reset support
11: 6ed636028a35c = 1: cc4aca290ed6a dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller
12: 49eee8a9fa0b1 ! 2: 34edd507ac54b reset: thead: Add TH1520 reset controller driver
@@ Commit message
implements support for GPU reset control, with infrastructure in place
to extend support for NPU and Watchdog Timer resets in future updates.
+ Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Michal Wilczynski <m.wilczynski@samsung.com>
## MAINTAINERS ##
@@ drivers/reset/reset-th1520.c (new)
+ struct th1520_reset_priv *priv = to_th1520_reset(rcdev);
+ const struct th1520_reset_map *reset;
+
-+ if (id >= ARRAY_SIZE(th1520_resets))
-+ return -EINVAL;
-+
+ reset = &th1520_resets[id];
+
+ return regmap_update_bits(priv->map, reset->reg, reset->bit, 0);
@@ drivers/reset/reset-th1520.c (new)
+ struct th1520_reset_priv *priv = to_th1520_reset(rcdev);
+ const struct th1520_reset_map *reset;
+
-+ if (id >= ARRAY_SIZE(th1520_resets))
-+ return -EINVAL;
-+
+ reset = &th1520_resets[id];
+
+ return regmap_update_bits(priv->map, reset->reg, reset->bit,
@@ drivers/reset/reset-th1520.c (new)
+ return ret;
+
+ priv->rcdev.owner = THIS_MODULE;
-+ priv->rcdev.nr_resets = 2;
++ priv->rcdev.nr_resets = ARRAY_SIZE(th1520_resets);
+ priv->rcdev.ops = &th1520_reset_ops;
+ priv->rcdev.of_node = dev->of_node;
+
13: 5b3a5c4e99c6e < -: ------------- drm/imagination: Add reset controller support for GPU initialization
14: 8175d1ae71f27 < -: ------------- dt-bindings: gpu: Add 'resets' property for GPU initialization
15: 37258df02d9f5 < -: ------------- dt-bindings: gpu: Add support for T-HEAD TH1520 GPU
16: 0da2bcc589f4e < -: ------------- drm/imagination: Add support for IMG BXM-4-64 GPU
17: 4a130662031ab < -: ------------- drm/imagination: Enable PowerVR driver for RISC-V
18: 96435f063bc3f < -: ------------- riscv: dts: thead: Add device tree VO clock controller
19: d8734c51119f5 < -: ------------- riscv: dts: thead: Introduce power domain nodes with aon firmware
20: bbd2819cbd342 < -: ------------- riscv: dts: thead: Introduce reset controller node
21: b22cf01230932 < -: ------------- riscv: dts: thead: Add GPU node to TH1520 device tree
---------->8----------
regards
Philipp
next prev parent reply other threads:[~2025-04-07 10:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250303152520eucas1p250f2e6d8eaf1172d8813b04ceb88679c@eucas1p2.samsung.com>
2025-03-03 15:25 ` Michal Wilczynski
[not found] ` <CGME20250303152521eucas1p26c54c5b15c024d749cf004b66345d2e0@eucas1p2.samsung.com>
2025-03-03 15:25 ` [PATCH v1 1/2] dt-bindings: reset: Add T-HEAD TH1520 SoC Reset Controller Michal Wilczynski
2025-03-03 17:40 ` Krzysztof Kozlowski
[not found] ` <CGME20250303152521eucas1p20128508eb79e20c1e124155beaf8fb4d@eucas1p2.samsung.com>
2025-03-03 15:25 ` [PATCH v1 2/2] reset: thead: Add TH1520 reset controller driver Michal Wilczynski
2025-03-05 8:23 ` [PATCH v1 0/2] TH1520 SoC: Add Reset Controller Support Michal Wilczynski
2025-04-07 10:27 ` Philipp Zabel [this message]
2025-04-07 10:30 ` Philipp Zabel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4400a2a695099e4d806d12ddda41c2533bf844c8.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=drew@pdp7.com \
--cc=guoren@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=m.wilczynski@samsung.com \
--cc=robh@kernel.org \
--cc=wefu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®