From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9A4722E11AB for ; Thu, 9 Oct 2025 12:45:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760013954; cv=none; b=Cg7/ET0Wu6H0U6jHRzIPnzWf5Pj7/srPUDCiTygNTtnwzvfUUHI8mkrLAvxLuCvgeAEkLnn8t5Yy4nJhpBD2qaAh8gsdrsC7hJOcywywJ3ydakN6JtnknHeSeZN8IToIglAOY1Ikccvyb8iqM8nPTgUrDccKeefST2h3REmNCwI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760013954; c=relaxed/simple; bh=HbNovGCEeUKtNbjcTLv4eSL94xDsy5k2YBrciaio6zM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WQNnH0y9ljQJtXLHB65pff4QKtJm0qIW7E2rpo0kRlXIMRgevapKPZtzlZtp7HUYO56zBN/FIYksS1LQ+WPVFvXX60geXCiSuY8D8eAnSaXepNlBt1DuP5Buu2cT0gKdOM2hwY1UiOMoWuUMvYYvYrT8R1di87vmTyuCkuq0Hj8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F3232176A; Thu, 9 Oct 2025 05:45:42 -0700 (PDT) Received: from [10.1.34.29] (e122027.cambridge.arm.com [10.1.34.29]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1AE323F66E; Thu, 9 Oct 2025 05:45:48 -0700 (PDT) Message-ID: <4400c6b4-d2ad-429a-b84c-60a2f593cff1@arm.com> Date: Thu, 9 Oct 2025 13:45:47 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] drm/panfrost: Name scheduler queues after their job slots To: =?UTF-8?Q?Adri=C3=A1n_Larumbe?= , linux-kernel@vger.kernel.org Cc: healych@amazon.com, Boris Brezillon , Rob Herring , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , dri-devel@lists.freedesktop.org References: <20251009114313.1374948-1-adrian.larumbe@collabora.com> From: Steven Price Content-Language: en-GB In-Reply-To: <20251009114313.1374948-1-adrian.larumbe@collabora.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 09/10/2025 12:43, Adrián Larumbe wrote: > Drawing from commit d2624d90a0b7 ("drm/panthor: assign unique names to > queues"), give scheduler queues proper names that reflect the function > of their JM slot, so that this will be shown when gathering DRM > scheduler tracepoints. > > Signed-off-by: Adrián Larumbe Reviewed-by: Steven Price > --- > drivers/gpu/drm/panfrost/panfrost_drv.c | 16 ++++++---------- > drivers/gpu/drm/panfrost/panfrost_job.c | 8 +++++++- > drivers/gpu/drm/panfrost/panfrost_job.h | 2 ++ > 3 files changed, 15 insertions(+), 11 deletions(-) > > diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c > index 22350ce8a08f..607a5b8448d0 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_drv.c > +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c > @@ -668,23 +668,19 @@ static void panfrost_gpu_show_fdinfo(struct panfrost_device *pfdev, > * job spent on the GPU. > */ > > - static const char * const engine_names[] = { > - "fragment", "vertex-tiler", "compute-only" > - }; > - > - BUILD_BUG_ON(ARRAY_SIZE(engine_names) != NUM_JOB_SLOTS); > - > for (i = 0; i < NUM_JOB_SLOTS - 1; i++) { > if (pfdev->profile_mode) { > drm_printf(p, "drm-engine-%s:\t%llu ns\n", > - engine_names[i], panfrost_priv->engine_usage.elapsed_ns[i]); > + panfrost_engine_names[i], > + panfrost_priv->engine_usage.elapsed_ns[i]); > drm_printf(p, "drm-cycles-%s:\t%llu\n", > - engine_names[i], panfrost_priv->engine_usage.cycles[i]); > + panfrost_engine_names[i], > + panfrost_priv->engine_usage.cycles[i]); > } > drm_printf(p, "drm-maxfreq-%s:\t%lu Hz\n", > - engine_names[i], pfdev->pfdevfreq.fast_rate); > + panfrost_engine_names[i], pfdev->pfdevfreq.fast_rate); > drm_printf(p, "drm-curfreq-%s:\t%lu Hz\n", > - engine_names[i], pfdev->pfdevfreq.current_frequency); > + panfrost_engine_names[i], pfdev->pfdevfreq.current_frequency); > } > } > > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c > index c47d14eabbae..0cc80da12562 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.c > +++ b/drivers/gpu/drm/panfrost/panfrost_job.c > @@ -28,6 +28,10 @@ > #define job_write(dev, reg, data) writel(data, dev->iomem + (reg)) > #define job_read(dev, reg) readl(dev->iomem + (reg)) > > +const char * const panfrost_engine_names[] = { > + "fragment", "vertex-tiler", "compute-only" > +}; > + > struct panfrost_queue_state { > struct drm_gpu_scheduler sched; > u64 fence_context; > @@ -846,12 +850,13 @@ int panfrost_job_init(struct panfrost_device *pfdev) > .num_rqs = DRM_SCHED_PRIORITY_COUNT, > .credit_limit = 2, > .timeout = msecs_to_jiffies(JOB_TIMEOUT_MS), > - .name = "pan_js", > .dev = pfdev->dev, > }; > struct panfrost_job_slot *js; > int ret, j; > > + BUILD_BUG_ON(ARRAY_SIZE(panfrost_engine_names) != NUM_JOB_SLOTS); > + > /* All GPUs have two entries per queue, but without jobchain > * disambiguation stopping the right job in the close path is tricky, > * so let's just advertise one entry in that case. > @@ -887,6 +892,7 @@ int panfrost_job_init(struct panfrost_device *pfdev) > > for (j = 0; j < NUM_JOB_SLOTS; j++) { > js->queue[j].fence_context = dma_fence_context_alloc(1); > + args.name = panfrost_engine_names[j]; > > ret = drm_sched_init(&js->queue[j].sched, &args); > if (ret) { > diff --git a/drivers/gpu/drm/panfrost/panfrost_job.h b/drivers/gpu/drm/panfrost/panfrost_job.h > index 5a30ff1503c6..458666bf684b 100644 > --- a/drivers/gpu/drm/panfrost/panfrost_job.h > +++ b/drivers/gpu/drm/panfrost/panfrost_job.h > @@ -53,6 +53,8 @@ struct panfrost_jm_ctx { > struct drm_sched_entity slot_entity[NUM_JOB_SLOTS]; > }; > > +extern const char * const panfrost_engine_names[]; > + > int panfrost_jm_ctx_create(struct drm_file *file, > struct drm_panfrost_jm_ctx_create *args); > int panfrost_jm_ctx_destroy(struct drm_file *file, u32 handle); > > base-commit: 30531e9ca7cd4f8c5740babd35cdb465edf73a2d