mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: jmerkey@wolfmountaingroup.com
To: linux-kernel@vger.kernel.org
Subject: do_filp_open fails to detect dentry revalidate of 1 and crashes
Date: Thu, 2 Oct 2008 00:17:16 -0600 (MDT)	[thread overview]
Message-ID: <44010.166.70.238.43.1222928236.squirrel@webmail.wolfmountaingroup.com> (raw)


On assignment of a negative dentry, do_filp_open will crash with an oops
in do_sys_open because do_filp_open returns "1" from revalidate rather
than properly detect a negative dentry which has a dentry revalidate
function before the file actually exists.


Easy to reproduce.  Create negative dentry and attach a revalidate
function which returns 1 instead of 0 on non-existent file entry.   The
convoluted code in do_filp_open does not detect dentry errors in all cases
properly.

Jeff


             reply	other threads:[~2008-10-02  6:53 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-02  6:17 jmerkey [this message]
     [not found] ` <44010.166.70.238.43.1222928236.squirrel@webmail.wolfmountaingroup.com >
2008-10-02  6:41   ` jmerkey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44010.166.70.238.43.1222928236.squirrel@webmail.wolfmountaingroup.com \
    --to=jmerkey@wolfmountaingroup.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®