From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1794901153; b=3gzUsPcSoMZVJXZK1+umBsp0Be19ku8kP/20+Spl8HQWipSJHDTYe5QCLsZZctYgDI6m kup5dg5QAQPy9YPQfkQ8FNI17j4AA7oZqPmKVQ2iS6RHiZTHZKr5dxsSBkGsat4PnfLvI amp7HYsvGAyQaDMoYEn/JOR9IVPEenxxomVgMgzhZAe7rDW7JL/QTZItldbr7tFev0QVb NIma3GT1MxMxgd8XpUAZbsvVH+wnCaqoNMAyEdK75TKek1sTqE7UDMwjWXJbfHBAA6/BA ENGFMr79B8o28I00rCYvNz78NCGizWWzYeYFlO1qQYFpiiWIwxTDEk9Tl9kyUkf17Rg== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1794901153; h=DMARC-Filter:Received:DKIM-Signature:DKIM-Signature:DKIM-Signature: DKIM-Signature:Received:Received:Message-ID:Date:MIME-Version: User-Agent:Subject:To:Cc:References:Content-Language:From:Autocrypt: In-Reply-To:Content-Type:Content-Transfer-Encoding:X-Spamd-Result: X-Rspamd-Server:X-Rspamd-Action:X-Spam-Flag:X-Spam-Score:X-Spam-Level: X-Rspamd-Queue-Id; bh=ko8kK8CK0AxEYTo307S41GIHG82nmMlZKPRgZvR+tJA=; b=cM/dxb3KB051Vo/kmADUFrG3SYSLr1tkM7xtcyr7L0IGdkg9Lsgobbjc0ll6EIpdjJxZ 3T2kEzReAOdzqcktuh+xk3e/AueM/LIjaSVSoJ+gwmPOmpW+kUN8609/eyT/tHCEHZgcc akbcnvbxyDdyolssQ/t1rUJw2Jc7ksT93A9CgBKg5awocMg5dl4nGBCrPF3mP7suo5Zcj L+LiXpmcPaha1QQQvAE+p85DD+xdkURRdRkMFBqd8sVnATfpf9zGxrh352o8ahel5Ruos 5BGUWl+S/dnH4ooriPHnX62dSWKK7DCcaflE7ZteT3/P1xSKdjb89LWysPZpIWTqh7w== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=suse.de; spf=pass smtp.mailfrom=suse.de; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HxbcUCWa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=jxYj9cNa; dkim=pass header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=H0o5dT4A; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b="U1Z/wiFj"; arc=none smtp.remote-ip=195.135.223.131 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D4C33606A31C for ; Tue, 17 Nov 2026 07:39:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D4C33606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=suse.de Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=HxbcUCWa; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=jxYj9cNa; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=H0o5dT4A; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=U1Z/wiFj Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id B95A21F395; Tue, 17 Nov 2026 07:39:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794901144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ko8kK8CK0AxEYTo307S41GIHG82nmMlZKPRgZvR+tJA=; b=HxbcUCWa5BF3Gl7WeR+GvZczVOqzdlc1ZrFnM1B+esPXchkt2AinzJiJM6/I5JhP4ztS7D BIGZcdcSnBwNIWBJFSHbhLX3TekiGgO5+1h48o74Vz8DkHL7v2xjaBljYo/dd3srftb/O1 SRtopC4ipukD/Llv7RHfjTHxOPL+gcE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794901144; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ko8kK8CK0AxEYTo307S41GIHG82nmMlZKPRgZvR+tJA=; b=jxYj9cNaw1j62xfLj+7znbSPGaaSnY3c2aXrkFvlnNZVHcBhzMNflAXMqy742nJTztjxMN MjmehHIY163IH0AQ== Authentication-Results: smtp-out2.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=H0o5dT4A; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b="U1Z/wiFj" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1794901143; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ko8kK8CK0AxEYTo307S41GIHG82nmMlZKPRgZvR+tJA=; b=H0o5dT4A2znxpcZNgpXJhHL5Pq0ns9NSvtQsbjVKz6ZZPm8QTClRGG7OXfgE/CLqcX/t5A mgUp5/wai03HioVURmR4/G8fxGUSbz9Jllnvc7fJTK9ouwy7prErjbR/1KmLxz8L0ZhSrc LP5GcpQJAHy6g098Ql/Qpw9ooZVU31A= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1794901143; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=ko8kK8CK0AxEYTo307S41GIHG82nmMlZKPRgZvR+tJA=; b=U1Z/wiFjN43DTbD4Gq25eW7zOzKtSzB/rf7eWsGa3TF6nAlnBHdfh6n1BiyWR0iN+xjffo BBCRtE/5DKl06DDw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 44EAA13302; Tue, 17 Nov 2026 07:39:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id hkRCOZYE/GpXDgAAD6G6ig (envelope-from ); Tue, 17 Nov 2026 07:39:03 +0000 Message-ID: <4404265c-ae14-4d17-82ad-46ed6c123c6b@suse.de> Date: Tue, 17 Nov 2026 08:39:02 +0100 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] drm/verisilicon: nuke planes' atomic_enable hooks To: Icenowy Zheng , Maarten Lankhorst , Maxime Ripard Cc: David Airlie , Simona Vetter , Dmitry Baryshkov , Joey Lu , Han Gao , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org References: <20261102075710.1286456-1-zhengxingda@iscas.ac.cn> <20261102075710.1286456-3-zhengxingda@iscas.ac.cn> <8e3b36c6-e2d8-4746-aefe-462bba1a4b05@suse.de> <5830251f1420c152b2efc2ee37248057bdfc901d.camel@iscas.ac.cn> <55991183-ab5f-4445-afce-37a79310ef27@suse.de> <83aa9fb5be26fb407c7f1393bc01099d374cf51f.camel@iscas.ac.cn> <7e4b4fd185f47404bb5f18e7c2c8086d24e673f4.camel@iscas.ac.cn> <73f4e371c37c36581240ff355fef3de2afaaa033.camel@iscas.ac.cn> Content-Language: en-US From: Thomas Zimmermann Autocrypt: addr=tzimmermann@suse.de; keydata= xsBNBFs50uABCADEHPidWt974CaxBVbrIBwqcq/WURinJ3+2WlIrKWspiP83vfZKaXhFYsdg XH47fDVbPPj+d6tQrw5lPQCyqjwrCPYnq3WlIBnGPJ4/jreTL6V+qfKRDlGLWFjZcsrPJGE0 BeB5BbqP5erN1qylK9i3gPoQjXGhpBpQYwRrEyQyjuvk+Ev0K1Jc5tVDeJAuau3TGNgah4Yc hdHm3bkPjz9EErV85RwvImQ1dptvx6s7xzwXTgGAsaYZsL8WCwDaTuqFa1d1jjlaxg6+tZsB 9GluwvIhSezPgnEmimZDkGnZRRSFiGP8yjqTjjWuf0bSj5rUnTGiyLyRZRNGcXmu6hjlABEB AAHNJ1Rob21hcyBaaW1tZXJtYW5uIDx0emltbWVybWFubkBzdXNlLmRlPsLAjgQTAQgAOAIb AwULCQgHAgYVCgkICwIEFgIDAQIeAQIXgBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftODH AAoJEGgNwR1TC3ojx1wH/0hKGWugiqDgLNXLRD/4TfHBEKmxIrmfu9Z5t7vwUKfwhFL6hqvo lXPJJKQpQ2z8+X2vZm/slsLn7J1yjrOsoJhKABDi+3QWWSGkaGwRJAdPVVyJMfJRNNNIKwVb U6B1BkX2XDKDGffF4TxlOpSQzdtNI/9gleOoUA8+jy8knnDYzjBNOZqLG2FuTdicBXblz0Mf vg41gd9kCwYXDnD91rJU8tzylXv03E75NCaTxTM+FBXPmsAVYQ4GYhhgFt8S2UWMoaaABLDe 7l5FdnLdDEcbmd8uLU2CaG4W2cLrUaI4jz2XbkcPQkqTQ3EB67hYkjiEE6Zy3ggOitiQGcqp j//OwE0EWznS4AEIAMYmP4M/V+T5RY5at/g7rUdNsLhWv1APYrh9RQefODYHrNRHUE9eosYb T6XMryR9hT8XlGOYRwKWwiQBoWSDiTMo/Xi29jUnn4BXfI2px2DTXwc22LKtLAgTRjP+qbU6 3Y0xnQN29UGDbYgyyK51DW3H0If2a3JNsheAAK+Xc9baj0LGIc8T9uiEWHBnCH+RdhgATnWW GKdDegUR5BkDfDg5O/FISymJBHx2Dyoklv5g4BzkgqTqwmaYzsl8UxZKvbaxq0zbehDda8lv hFXodNFMAgTLJlLuDYOGLK2AwbrS3Sp0AEbkpdJBb44qVlGm5bApZouHeJ/+n+7r12+lqdsA EQEAAcLAdgQYAQgAIAIbDBYhBHIX+6yM6c9jRKFo5WgNwR1TC3ojBQJftOH6AAoJEGgNwR1T C3ojVSkIALpAPkIJPQoURPb1VWjh34l0HlglmYHvZszJWTXYwavHR8+k6Baa6H7ufXNQtThR yIxJrQLW6rV5lm7TjhffEhxVCn37+cg0zZ3j7zIsSS0rx/aMwi6VhFJA5hfn3T0TtrijKP4A SAQO9xD1Zk9/61JWk8OysuIh7MXkl0fxbRKWE93XeQBhIJHQfnc+YBLprdnxR446Sh8Wn/2D Ya8cavuWf2zrB6cZurs048xe0UbSW5AOSo4V9M0jzYI4nZqTmPxYyXbm30Kvmz0rYVRaitYJ 4kyYYMhuULvrJDMjZRvaNe52tkKAvMevcGdt38H4KSVXAylqyQOW5zvPc4/sq9c= In-Reply-To: <73f4e371c37c36581240ff355fef3de2afaaa033.camel@iscas.ac.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spamd-Result: default: False [-13.50 / 50.00]; SUSE_INTERNAL_BYPASS(-9.00)[]; BAYES_HAM(-3.00)[100.00%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; XM_UA_NO_VERSION(0.01)[]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,bootlin.com:url,suse.de:dkim,suse.com:url]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_ALL(0.00)[]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; FREEMAIL_ENVRCPT(0.00)[gmail.com]; RCVD_TLS_ALL(0.00)[]; TO_DN_SOME(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; FREEMAIL_CC(0.00)[gmail.com,ffwll.ch,oss.qualcomm.com,iscas.ac.cn,lists.freedesktop.org,vger.kernel.org]; MID_RHS_MATCH_FROM(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; RCPT_COUNT_SEVEN(0.00)[10]; DKIM_TRACE(0.00)[suse.de:+]; RCVD_VIA_SMTP_AUTH(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:rdns,imap1.dmz-prg2.suse.org:helo,bootlin.com:url,suse.de:dkim,suse.com:url] X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Action: no action X-Spam-Flag: NO X-Spam-Score: -13.50 X-Spam-Level: X-Rspamd-Queue-Id: B95A21F395 Hi Am 17.11.26 um 08:34 schrieb Icenowy Zheng: > 在 2026-11-17二的 08:25 +0100,Thomas Zimmermann写道: >> Hi >> >> Am 17.11.26 um 06:19 schrieb Icenowy Zheng: >> [...] >>>>> Sure, but is that a problem for this hardware? >>>> For the cursor plane, the unchecked coordinate might be improper >>>> for >>>> the registers. >>>> >>>> For the primary plane, if the plane is found to be totally off by >>>> drm_atomic_helper_check_plane_state(), the check for >>>> can_position, >>>> which is below the code snippet I referenced, would be bypassed, >>>> and >>>> such plane would be programmed to be visible by the atomic_update >>>> hook >>>> even if it shouldn't be visible. >>> Well I am now thinking that bound-but-invisible situation is >>> commonly >>> ignored by drivers. >>> >>> For drm/verisilicon, maybe I'd remove both atomic_disable and >>> atomic_enable; however I think the atomic helpers may need some >>> flag to >>> consider bound-but-invisible planes when calling >>> atomic_{dis,en}able. >> I don't think I really understand what you're up to, but it seems >> you're >> overthinking the whole thing. Other drivers only care about plane >> on/off > Well I don't know whether I am overthinking... > > Enabled but invisible planes are explicitly allowed in > drm_atomic_helper_check_plane_state(), and even the can_position check > is bypassed in such case (so such a configuration can even appear on > primary planes). In addition, in most implementations for atomic_check, > the invisible situations have the validity check explicitly skipped, so > just disallow enabled-but-invisible planes in atomic_check would make > the behavior quite different with most drivers. > > Maybe I should craft some "evil" programs to check for this situation. If you can make an igt test case for broken plane coordinates, go for it. Best regards Thomas > > Thanks, > Icenowy > >> and the contained image. That's also what the 3 callbacks are for. It >> usually works nicely. Hence me asking. But maybe verisilicon is >> different, IDK. >> >> My suggestion is therefore to remove _enable and _disable and keep >> all >> logic in _update. >> >> atomic_update() >> { >>      if (plane_state->visible) { >>          // do update >>          // enable hw plane >>      } else { >>          // disable hw plane >>      } >> } >> >> If you have any special cases where you want visible to be false (or >> true), detect them in atomic_check and set the flags accordingly. >> >> atomic_check() >> { >> drm_atomic_helper_check_plane_state()     if (awkward coords) >>           plane_state->visible = false; >> } >> >> Best regards >> Thomas >> >>> Thanks, >>> Icenowy >>> >>>> Thanks, >>>> Icenowy >>>> >>>>> Best regards >>>>> Thomas >>>>> >>>>>> The end of drm_atomic_helper_check_plane_state() says: >>>>>> >>>>>> ``` >>>>>> if (!plane_state->visible) >>>>>> /* >>>>>> * Plane isn't visible; some drivers can >>>>>> handle >>>>>> this >>>>>> * so we just return success here.  Drivers >>>>>> that >>>>>> can't >>>>>> * (including those that use the primary >>>>>> plane >>>>>> helper's >>>>>> * update function) will return an error >>>>>> from >>>>>> their >>>>>> * update_plane handler. >>>>>> */ >>>>>> return 0; >>>>>> ``` >>>>>> >>>>>> Thanks, >>>>>> Icenowy >>>>>> >>>>>>> [1] >>>>>>> https://elixir.bootlin.com/linux/v7.3.1/source/drivers/gpu/drm/drm_atomic_helper.c#L3030 >>>>>>> >>>>>>> Best regards >>>>>>> Thomas >>>>>>> >>>>>>>>     }; >>>>>>>> >>>>>>>> diff --git >>>>>>>> a/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>>>>>> b/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>>>>>> index 8e94491693019..fca692f4f7d5c 100644 >>>>>>>> --- a/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>>>>>> +++ b/drivers/gpu/drm/verisilicon/vs_primary_plane.c >>>>>>>> @@ -59,25 +59,6 @@ static void >>>>>>>> vs_primary_plane_commit(struct >>>>>>>> vs_dc >>>>>>>> *dc, unsigned int output) >>>>>>>>      VSDC_FB_CONFIG_EX_COMMIT); >>>>>>>>     } >>>>>>>> >>>>>>>> -static void vs_primary_plane_atomic_enable(struct >>>>>>>> drm_plane >>>>>>>> *plane, >>>>>>>> -    struct >>>>>>>> drm_atomic_commit *atomic_state) >>>>>>>> -{ >>>>>>>> - struct drm_plane_state *state = >>>>>>>> drm_atomic_get_new_plane_state(atomic_state, >>>>>>>> - >>>>>>>> >>>>>>>>        plane); >>>>>>>> - struct drm_crtc *crtc = state->crtc; >>>>>>>> - struct vs_crtc *vcrtc = >>>>>>>> drm_crtc_to_vs_crtc(crtc); >>>>>>>> - unsigned int output = vcrtc->id; >>>>>>>> - struct vs_dc *dc = vcrtc->dc; >>>>>>>> - >>>>>>>> - regmap_set_bits(dc->regs, >>>>>>>> VSDC_FB_CONFIG_EX(output), >>>>>>>> - VSDC_FB_CONFIG_EX_FB_EN); >>>>>>>> - regmap_update_bits(dc->regs, >>>>>>>> VSDC_FB_CONFIG_EX(output), >>>>>>>> - >>>>>>>> VSDC_FB_CONFIG_EX_DISPLAY_ID_MASK, >>>>>>>> - >>>>>>>> VSDC_FB_CONFIG_EX_DISPLAY_ID(output)); >>>>>>>> - >>>>>>>> - vs_primary_plane_commit(dc, output); >>>>>>>> -} >>>>>>>> - >>>>>>>>     static void vs_primary_plane_atomic_disable(struct >>>>>>>> drm_plane >>>>>>>> *plane, >>>>>>>>          struct >>>>>>>> drm_atomic_commit *atomic_state) >>>>>>>>     { >>>>>>>> @@ -144,13 +125,18 @@ static void >>>>>>>> vs_primary_plane_atomic_update(struct drm_plane *plane, >>>>>>>>      regmap_write(dc->regs, >>>>>>>> VSDC_FB_BLEND_CONFIG(output), >>>>>>>> >>>>>>>> VSDC_FB_BLEND_CONFIG_BLEND_DISABLE); >>>>>>>> >>>>>>>> + regmap_set_bits(dc->regs, >>>>>>>> VSDC_FB_CONFIG_EX(output), >>>>>>>> + VSDC_FB_CONFIG_EX_FB_EN); >>>>>>>> + regmap_update_bits(dc->regs, >>>>>>>> VSDC_FB_CONFIG_EX(output), >>>>>>>> + >>>>>>>> VSDC_FB_CONFIG_EX_DISPLAY_ID_MASK, >>>>>>>> + >>>>>>>> VSDC_FB_CONFIG_EX_DISPLAY_ID(output)); >>>>>>>> + >>>>>>>>      vs_primary_plane_commit(dc, output); >>>>>>>>     } >>>>>>>> >>>>>>>>     static const struct drm_plane_helper_funcs >>>>>>>> vs_primary_plane_helper_funcs = { >>>>>>>>      .atomic_check = vs_primary_plane_atomic_check, >>>>>>>>      .atomic_update = >>>>>>>> vs_primary_plane_atomic_update, >>>>>>>> - .atomic_enable = >>>>>>>> vs_primary_plane_atomic_enable, >>>>>>>>      .atomic_disable = >>>>>>>> vs_primary_plane_atomic_disable, >>>>>>>>     }; >>>>>>>> -- -- Thomas Zimmermann Graphics Driver Developer SUSE Software Solutions Germany GmbH Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com GF: Stefan Gaiser, Jochen Jaser, Abhinav Puri, (HRB 36809, AG Nürnberg)