Hi Alasdair, Alasdair G Kergon wrote: >>+static int open_dev(struct dm_dev *d, dev_t dev, struct gendisk *holder) >>+static int upgrade_mode(struct dm_dev *dd, int new_mode, struct gendisk *holder) >>+static void close_dev(struct dm_dev *d, struct gendisk *holder) > > Please pass the dm structure, struct mapped_device, around between dm functions > internally where you can, instead of struct gendisk. (Every time the new > parameter is passed it's wrapped with dm_disk(), so move the dm_disk() inside.) Thank you for the comment. I changed them and updated the patch. Could you check whether there is any other wrong thing? Thanks, -- Jun'ichi Nomura, NEC Solutions (America), Inc.