From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753151AbdJTLkr (ORCPT ); Fri, 20 Oct 2017 07:40:47 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:44630 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbdJTLkp (ORCPT ); Fri, 20 Oct 2017 07:40:45 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 77416606DC Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=mgautam@codeaurora.org Subject: Re: [PATCH v8] usb: dwc3: of-simple: Add support to get resets for the device To: Philipp Zabel , linux-usb@vger.kernel.org Cc: Felipe Balbi , Vivek Gautam , linux-kernel@vger.kernel.org, kernel@pengutronix.de References: <20171019114743.2966-1-p.zabel@pengutronix.de> From: Manu Gautam Message-ID: <4410e062-f874-993d-d390-6996321d77cc@codeaurora.org> Date: Fri, 20 Oct 2017 17:10:37 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20171019114743.2966-1-p.zabel@pengutronix.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 10/19/2017 5:17 PM, Philipp Zabel wrote: > From: Vivek Gautam > > Add support to get a list of resets available for the device. > These resets must be kept de-asserted until the device is > in use. > > Signed-off-by: Vivek Gautam > [p.zabel@pengutronix.de: switch to hidden reset control array] > Signed-off-by: Philipp Zabel > --- > v7: Rebased onto git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git testing/next > --- > drivers/usb/dwc3/dwc3-of-simple.c | 27 +++++++++++++++++++++++++-- > 1 file changed, 25 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c > index e129c32780818..ceea1619f8aa3 100644 > --- a/drivers/usb/dwc3/dwc3-of-simple.c > +++ b/drivers/usb/dwc3/dwc3-of-simple.c > @@ -28,11 +28,13 @@ > #include > #include > #include > +#include > > struct dwc3_of_simple { > struct device *dev; > struct clk **clks; > int num_clocks; > + struct reset_control *resets; > }; > > static int dwc3_of_simple_clk_init(struct dwc3_of_simple *simple, int count) > @@ -95,10 +97,21 @@ static int dwc3_of_simple_probe(struct platform_device *pdev) > platform_set_drvdata(pdev, simple); > simple->dev = dev; > > + simple->resets = of_reset_control_array_get_optional_exclusive(np); > + if (IS_ERR(simple->resets)) { > + ret = PTR_ERR(simple->resets); > + dev_err(dev, "failed to get device resets, err=%d\n", ret); > + return ret; > + } > + > + ret = reset_control_deassert(simple->resets); > + if (ret) > + goto err_resetc_put; > + Are these reset signals asserted by default after power on? I think correct way to handle this should be to have explicit reset_control_assert before deassert. > ret = dwc3_of_simple_clk_init(simple, of_count_phandle_with_args(np, > "clocks", "#clock-cells")); > if (ret) > - return ret; > + goto err_resetc_assert; -- The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project