mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kirill Korotaev <dev@sw.ru>
To: Al Viro <viro@ftp.linux.org.uk>
Cc: Kirill Korotaev <dev@openvz.org>, Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org,
	Andrey Savochkin <saw@saw.sw.com.sg>,
	devel@openvz.org
Subject: Re: [PATCH] ext3: ext3_symlink should use GFP_NOFS allocations inside
Date: Fri, 10 Mar 2006 11:46:40 +0300	[thread overview]
Message-ID: <44113CF0.7070005@sw.ru> (raw)
In-Reply-To: <20060310083136.GW27946@ftp.linux.org.uk>

>>+	page = find_or_create_page(mapping, 0,
>>+			mapping_gfp_mask(mapping) | gfp_mask);
> 
> 
>>+int page_symlink(struct inode *inode, const char *symname, int len)
>>+{
>>+	return __page_symlink(inode, symname, len, GFP_KERNEL);
> 
> 
> s/GFP_KERNEL/0/; if somebody has e.g. GFP_NOFS in their mapping flags,
> you end up breaking their code.  We really pass extra flags to be added
> to default ones; page_symlink() should pass 0.
thanks for noticing this.
fixed and resend.

Thanks,
Kirill



  reply	other threads:[~2006-03-10  8:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-10  8:08 Kirill Korotaev
2006-03-10  8:31 ` Al Viro
2006-03-10  8:46   ` Kirill Korotaev [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-03-09 17:19 Kirill Korotaev
2006-03-09 21:04 ` Al Viro
2006-03-10 13:02 ` Michael Tokarev
2006-03-10 20:21   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44113CF0.7070005@sw.ru \
    --to=dev@sw.ru \
    --cc=akpm@osdl.org \
    --cc=dev@openvz.org \
    --cc=devel@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=saw@saw.sw.com.sg \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome