From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757100AbcILHh3 (ORCPT ); Mon, 12 Sep 2016 03:37:29 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:62380 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754477AbcILHhZ (ORCPT ); Mon, 12 Sep 2016 03:37:25 -0400 From: Arnd Bergmann To: Michael Ellerman Cc: Borislav Petkov , dougthompson@xmission.com, mchehab@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH] drivers/edac: NO_IRQ removal from powerpc-only drivers Date: Mon, 12 Sep 2016 09:36:22 +0200 Message-ID: <4413035.eY2sIBJ9x6@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <874m5lrafq.fsf@concordia.ellerman.id.au> References: <1473501428-8217-1-git-send-email-mpe@ellerman.id.au> <20160910145320.bg6s6wo5ya7zzw2n@pd.tnic> <874m5lrafq.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:j1sY6QxuqBkCd/8t+6QN3XlHIAWnelZwnGGdReyX1zIuGuJcHOT gt2GSDx+VuUVVXjdK8FUD2kznO0vCHJLRwpErUUAS3uryhQKy59CaCBtjA9qCMKqmk9dO/P p/8BsMGUGfTIs8H4kBaGPtqViY/g8TomcRKucrvroY+85ihntSkRVJHaRVJ313RbcqJYh0H EYtNeB24HS7fYPzeP7cVg== X-UI-Out-Filterresults: notjunk:1;V01:K0:gAC8v3CxidU=:BuRjyTyUKOw6zGVJhNtKWl 8hHbvRJRxJ6ULtEkNngeqDc5ynb7nt6NnDDn4NHBO1lSiFSsaqrhxvgtfkLbzdbl6FtjZeDou kKuygI1ZrgEXNzDJpdwLFp1IjZsUewvcZSpAkPQw/IHIh3fmpUxSWaf0iTo1fYkUwQSJlmyFG V0E/+6vyYbHyK/VzPnrTF5sdHdGYc7QEyYeAbZln5tzmme+ZwqOp4LSX6Eqf+4dkg30TZgjyB yIYVWxbosuv0v0etXh2RBrC8JJvFfJL+VBySuEJByAxrCjAdHxZe37Dt/f5i7rgQ2s5ekyINU D/TQoqNE62BNYoq9mwRWqqOj0YlEB0yS8USjD2QPW7hln3+oBg7IPPgZ1Q1tFZQTjzv41LKex Bqdy/MEHJnkMqhBzL4FshwYqLhBktBoAUuNfRnhEYDWWKbeTy35h28yHez7tpwQwHDWGiVq/r 7XvzuCzQk60xyrZXg+QW95qjTDa9ChHYSnw5YdJSzTE27R5N/QSJHCk5va6ekoO56R5hQwU0T lFyIJZ5bq1D2LVPQj0Ur435KIu8k1kDKUJlAioIOukbvH9/NlccQAEhh5N1RehfjcjaZFzXoe 9vjPnLCKGHD9RK76fTYVAXwltwtTiIFcLUx9HTzXQs7cZJVgLazcDLWS+qUATXAS4Pt+3QccC qkUPAaTdz+4qXYZsJCV1CiaXycZLxh7oJ5WiiORaOcQ6Zn0r4DtBtm3qFZ7vOnpRwaXGxWVaC x8Dbq+o+bxTffEn1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, September 12, 2016 2:47:37 PM CEST Michael Ellerman wrote: > >> @@ -1058,7 +1058,7 @@ static int mpc85xx_mc_err_probe(struct platform_device *op) > >> > >> pdata = mci->pvt_info; > >> pdata->name = "mpc85xx_mc_err"; > >> - pdata->irq = NO_IRQ; > >> + pdata->irq = 0; > >> mci->pdev = &op->dev; > >> pdata->edac_idx = edac_mc_idx++; > >> dev_set_drvdata(mci->pdev, mci); > > > > That part went into drivers/edac/fsl_ddr_edac.c which is only the > > freescale memory controller being shared between ARM and PPC, see > > > > http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next > > > > But that shouldn't change the issue wrt ->irq as now it is implicitly 0. > > Ah OK. > > NO_IRQ is -1 on ARM (or at least it can be?), see arch/arm/include/asm/irq.h. > > So I'll leave that one alone for now. I don't think there is any way to build the mpc85xx on ARM, it depends on the powerpc-specific "FSL_SOC" symbol and it uses the in_be32/out_be32 MMIO helpers that are not defined on ARM. I've sent patches to remove all uses of NO_IRQ that happen on ARM. Please remove this instance too. Arnd