From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752017AbbJWM4U (ORCPT ); Fri, 23 Oct 2015 08:56:20 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:64776 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750970AbbJWM4S (ORCPT ); Fri, 23 Oct 2015 08:56:18 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Eric Auger , eric.auger@st.com, alex.williamson@redhat.com, b.reynal@virtualopensystems.com, thomas.lendacky@amd.com, Suravee.Suthikulpanit@amd.com, kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, linux-kernel@vger.kernel.org, christoffer.dall@linaro.org, patches@linaro.org Subject: Re: [PATCH v2] VFIO: platform: reset: AMD xgbe reset module Date: Fri, 23 Oct 2015 14:55:38 +0200 Message-ID: <4421151.hWFIfrRvFW@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1445604253-15384-1-git-send-email-eric.auger@linaro.org> References: <1445604253-15384-1-git-send-email-eric.auger@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:O6Uw/SzsiGpj9+kbTRips60R63YA9x2asc+gqiYsxehQY9VA7bK r/8I0QmzoFzO+R2Ocpdjcnp3/0/Ut3AYdazwtWXSsHwcXq7dzvq/wnIDvGKRc+kcglwE9BX J83XWAi/1i/v/29kb3bNYiLEycX/Mm4JEYxXQY7bl98QaVUn3WBV0rCefeS0dbBMr5Yu3m/ gnD5kVxeZnQi7eB9Afbrw== X-UI-Out-Filterresults: notjunk:1;V01:K0:u9wiYMuvqFA=:VXkBOAJYf2TDR038nDphuv YwQeG+t2rOF51o4P8e+vXjpSKJWfBiSYktyez/ZzBrb0JUSzSm2I2rHLsNcD8Kf753vozuoho cDyGuQi8ELfHTlughSKXeskamytGqgTeMLW557cIrGFN0bHxhrXAFLe1dO6ahFuYgsojYliEC a28KnvbyEJfcN2jpCfV+5cL49lCJH8SUkdT06brcFmubOvVOF0suMFXDOGSooG2FhUFV7AR1R v+nRX2u6AVX5n7gpiZdOb8A2OB9Cmd9BkAHR8ItgJtXP6VzYxOheS/ZL/23MqUxeKnM7b1SlI Yz6IQxHrfvlmS6pOf2xzdNPjSPZpVibD95YTLPKY+QbzYY72Wlq77bVi+yBECI0/IN9Ws3t8v QnQYYESrjcAVLqYph4rndrxAkHN4qAWH6QbvihfpOddvU7u3505pM55OE/l25zLTlTUC61gYB sQ2cqr0ZP9KZVZoszdWZyznhP9zE36Pz01vQBR9b2+IGojp+BMy3+TZ45Iki1hpaEKd9SUmzL MLeJ5SmKKWk9jAQSpRSrxsS63uqnHIx3l6reaRZE2DzQ0nXC0KEIUamcWwuJwYG/L+8UE35sq SS/QO/8saPNTvBpKvYyteiU/M3cYBEPyH0l1uxp/125zaYEF07u1WVYguk2ljetrz/Gmp/OF1 2/ko9tdQAiimLE79rzTqweOL7ZzIfOom+xitFsYxMCyg9EL+ccirI7DkLuPezds9n/wFxQJmV fzZBOCr/876Z8eUS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 23 October 2015 14:44:13 Eric Auger wrote: > This patch introduces a module that registers and implements a low-level > reset function for the AMD XGBE device. > > it performs the following actions: > - reset the PHY > - disable auto-negotiation > - disable & clear auto-negotiation IRQ > - soft-reset the MAC > > Those tiny pieces of code are inherited from the native xgbe driver. > > Signed-off-by: Eric Auger > > --- The code looks ok to me, just two small style issues. > > If you don't know what to do here, say N. > +config VFIO_PLATFORM_AMDXGBE_RESET > + tristate "VFIO support for AMD XGBE reset" > + depends on VFIO_PLATFORM > + help > + Enables the VFIO platform driver to handle reset for AMD XGBE > + > + If you don't know what to do here, say N. Please add an empty line before the newly introduced option. > +MODULE_VERSION(DRIVER_VERSION); > +MODULE_LICENSE("GPL v2"); > +MODULE_AUTHOR(DRIVER_AUTHOR); > +MODULE_DESCRIPTION(DRIVER_DESC); Best remove those macros and put the strings in here directly to make it easier to grep for. Arnd