mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Lendacky <thomas.lendacky@amd.com>
To: Ingo Molnar <mingo@kernel.org>,
	Ashwin Dayanand Kamat <kashwindayan@vmware.com>
Cc: linux-kernel@vger.kernel.org, bp@alien8.de,
	brijesh.singh@amd.com, tglx@linutronix.de, mingo@redhat.com,
	dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com,
	jroedel@suse.de, stable@vger.kernel.org, ganb@vmware.com,
	tkundu@vmware.com, vsirnapalli@vmware.com, akaher@vmware.com,
	amakhalov@vmware.com, namit@vmware.com
Subject: Re: [PATCH] x86/sev: Fix kernel crash due to late update to read-only ghcb_version
Date: Thu, 30 Nov 2023 10:07:24 -0600	[thread overview]
Message-ID: <44244ba4-9d18-4cbe-8592-a7a41e22d725@amd.com> (raw)
In-Reply-To: <ZWhWI2GvfleyGKsa@gmail.com>

On 11/30/23 03:30, Ingo Molnar wrote:
> 
> * Ashwin Dayanand Kamat <kashwindayan@vmware.com> wrote:
> 
>> From: Ashwin Dayanand Kamat <ashwin.kamat@broadcom.com>
>>
>> kernel crash was observed because of page fault, while running
>> cpuhotplug ltp testcases on SEV-ES enabled systems. The crash was
>> observed during hotplug after the CPU was offlined and the process
>> was migrated to different cpu. setup_ghcb() is called again which
>> tries to update ghcb_version in sev_es_negotiate_protocol(). Ideally this
>> is a read_only variable which is initialised during booting.
>> This results in pagefault.
> 
> Applied to tip:x86/urgent, thanks.
> 
> Tom: I've added your Suggested-by and Acked-by, which appeared to be the
> case given the v1 discussion, let me know if that's not accurate.

All good.

Thanks,
Tom

> 
> I've also tidied up the changelog - final version attached below.
> 
> Thanks,
> 
> 	Ingo
> 

  reply	other threads:[~2023-11-30 16:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 10:40 [PATCH v2] x86/sev: Update ghcb_version only once Ashwin Dayanand Kamat
2023-11-30  9:30 ` [PATCH] x86/sev: Fix kernel crash due to late update to read-only ghcb_version Ingo Molnar
2023-11-30 16:07   ` Tom Lendacky [this message]
2023-11-30  9:39 ` [tip: x86/urgent] " tip-bot2 for Ashwin Dayanand Kamat

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44244ba4-9d18-4cbe-8592-a7a41e22d725@amd.com \
    --to=thomas.lendacky@amd.com \
    --cc=akaher@vmware.com \
    --cc=amakhalov@vmware.com \
    --cc=bp@alien8.de \
    --cc=brijesh.singh@amd.com \
    --cc=dave.hansen@linux.intel.com \
    --cc=ganb@vmware.com \
    --cc=hpa@zytor.com \
    --cc=jroedel@suse.de \
    --cc=kashwindayan@vmware.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=mingo@redhat.com \
    --cc=namit@vmware.com \
    --cc=stable@vger.kernel.org \
    --cc=tglx@linutronix.de \
    --cc=tkundu@vmware.com \
    --cc=vsirnapalli@vmware.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®