From: Tim Chen <tim.c.chen@linux.intel.com>
To: pwil3058@bigpond.net.au
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] sched: smpnice try to wakeup modification
Date: Tue, 28 Mar 2006 18:49:16 -0800 [thread overview]
Message-ID: <4429F5AC.4000103@linux.intel.com> (raw)
Peter,
If there is no load on this_cpu, (i.e. tl_per_task is 0), we will fail the
"tl + target_load(cpu, idx) <= tl_per_task" check. I think the original intention was
to put task on this_cpu if it has no load and when there's already one task on
cpu. This helps spread tasks out for low load condition.
Thanks.
Tim
Signed-off-by: Tim Chen <tim.c.chen@linux.intel.com>
--- linux-2.6.16-mm2-a/kernel/sched.c 2006-03-28 16:00:37.091779904 -0800
+++ linux-2.6.16-mm2-b/kernel/sched.c 2006-03-28 16:09:08.237074008 -0800
@@ -1393,7 +1393,7 @@ static int try_to_wake_up(task_t *p, uns
if (this_sd->flags & SD_WAKE_AFFINE) {
unsigned long tl = this_load;
- unsigned long tl_per_task = cpu_avg_load_per_task(this_cpu);
+ unsigned long sl_per_task = cpu_avg_load_per_task(cpu);
/*
* If sync wakeup then subtract the (maximum possible)
@@ -1404,7 +1404,7 @@ static int try_to_wake_up(task_t *p, uns
tl -= current->load_weight;
if ((tl <= load &&
- tl + target_load(cpu, idx) <= tl_per_task) ||
+ tl + target_load(cpu, idx) <= sl_per_task) ||
100*(tl + p->load_weight) <= imbalance*load) {
/*
* This domain has SD_WAKE_AFFINE and
next reply other threads:[~2006-03-29 3:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-29 2:49 Tim Chen [this message]
2006-03-29 22:49 ` Peter Williams
2006-03-29 23:13 ` Tim Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4429F5AC.4000103@linux.intel.com \
--to=tim.c.chen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pwil3058@bigpond.net.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome